Hello community,
here is the log from the commit of package sessreg for openSUSE:Factory checked in at 2013-03-01 09:01:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/sessreg (Old)
and /work/SRC/openSUSE:Factory/.sessreg.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "sessreg", Maintainer is ""
Changes:
--------
--- /work/SRC/openSUSE:Factory/sessreg/sessreg.changes 2012-05-08 12:00:59.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.sessreg.new/sessreg.changes 2013-03-01 09:01:02.000000000 +0100
@@ -1,0 +2,12 @@
+Tue Feb 26 19:25:31 UTC 2013 - zaitor@opensuse.org
+
+- Update to version 1.0.8:
+ + Add -V option to print version number.
+ + Combine usage message into a single string.
+ + Fix some clang warnings about implicit conversions.
+ + Remove dubious code.
+ + Make the `line' variable local to main().
+ + Place NetBSD specific #defines in the proper place.
+ + Fix compilation on NetBSD - undefined *TMPX paths (fdo#50940).
+
+-------------------------------------------------------------------
Old:
----
sessreg-1.0.7.tar.bz2
New:
----
sessreg-1.0.8.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ sessreg.spec ++++++
--- /var/tmp/diff_new_pack.5txVEq/_old 2013-03-01 09:01:03.000000000 +0100
+++ /var/tmp/diff_new_pack.5txVEq/_new 2013-03-01 09:01:03.000000000 +0100
@@ -1,7 +1,7 @@
#
# spec file for package sessreg
#
-# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -15,13 +15,14 @@
# Please submit bugfixes or comments via http://bugs.opensuse.org/
#
+
Name: sessreg
-Version: 1.0.7
-Release: 1
-License: MIT
+Version: 1.0.8
+Release: 0
Summary: Utility to manage utmp/wtmp entries for X sessions
-Url: http://xorg.freedesktop.org/
+License: MIT
Group: System/X11/Utilities
+Url: http://xorg.freedesktop.org/
Source0: http://xorg.freedesktop.org/releases/individual/app/%{name}-%{version}.tar.bz2
BuildRequires: pkg-config
BuildRequires: pkgconfig(xorg-macros) >= 1.4
++++++ sessreg-1.0.7.tar.bz2 -> sessreg-1.0.8.tar.bz2 ++++++
++++ 8758 lines of diff (skipped)
++++ retrying with extended exclude list
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.0.7/ChangeLog new/sessreg-1.0.8/ChangeLog
--- old/sessreg-1.0.7/ChangeLog 2011-10-22 06:10:21.000000000 +0200
+++ new/sessreg-1.0.8/ChangeLog 2013-02-11 03:44:50.000000000 +0100
@@ -1,3 +1,116 @@
+commit 1d9c8df5bea05c2c4923fd985ce274104b42efeb
+Author: Alan Coopersmith
+Date: Sun Feb 10 18:43:41 2013 -0800
+
+ sessreg 1.0.8
+
+ Signed-off-by: Alan Coopersmith
+
+commit ec158dea0bdc8bf4767fe048056178a823a2033b
+Author: Alan Coopersmith
+Date: Sat Jan 19 16:37:00 2013 -0800
+
+ Add -V option to print version number
+
+ Signed-off-by: Alan Coopersmith
+
+commit 64db372b4988e4862acb328492b7bbe14851ebe0
+Author: Alan Coopersmith
+Date: Sat Jan 19 16:32:15 2013 -0800
+
+ Combine usage message into a single string
+
+ Signed-off-by: Alan Coopersmith
+
+commit 64e773800f70a4e9ebc0e606150beaff9b839fd9
+Author: Alan Coopersmith
+Date: Sun Dec 16 12:46:50 2012 -0800
+
+ Fix some clang warnings about implicit conversions
+
+ sessreg.c:360:43: warning: implicit conversion changes signedness:
+ 'unsigned long' to 'off_t' (aka 'long') [-Wsign-conversion]
+ sysnerr (lseek(llog, (long) pwd->pw_uid*sizeof(ll), 0)
+ ~~~~~ ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
+ sessreg.c:360:25: warning: implicit conversion changes signedness: 'long' to
+ 'unsigned long' [-Wsign-conversion]
+ sysnerr (lseek(llog, (long) pwd->pw_uid*sizeof(ll), 0)
+ ^~~~~~~~~~~~~~~~~~~
+
+ sessreg.c:405:7: warning: implicit conversion loses integer precision: 'size_t'
+ (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
+ i = strlen (line);
+ ~ ^~~~~~~~~~~~~
+ sessreg.c:406:9: warning: comparison of integers of different signs: 'int' and
+ 'unsigned long' [-Wsign-compare]
+ if (i >= sizeof (u->ut_id))
+ ~ ^ ~~~~~~~~~~~~~~~~~
+
+ sessreg.c:494:7: warning: implicit conversion loses integer precision: 'size_t'
+ (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
+ i = strlen (line);
+ ~ ^~~~~~~~~~~~~
+ sessreg.c:495:9: warning: comparison of integers of different signs: 'int' and
+ 'unsigned long' [-Wsign-compare]
+ if (i >= sizeof (u->ut_id))
+ ~ ^ ~~~~~~~~~~~~~~~~~
+
+ Signed-off-by: Alan Coopersmith
+
+commit 88bf1500095d7aaea9689a6d0367d6ff5c868292
+Author: Ed Schouten
+Date: Sat Sep 15 20:27:57 2012 +0200
+
+ Remove dubious code.
+
+ The NO_UTMP definition is set on non-FreeBSD, non-OpenBSD, BSD-based
+ systems. When looking at the commonly used BSD-based operating systems,
+ they either use utmpx, or I can't think of a reason why the utmp code
+ wouldn't work.
+
+ If it turns out some obscure operating system breaks because of this
+ change, we should replace this by something more accurate, such as an
+ Autoconf check or an #ifdef specific to that operating system.
+
+ Signed-off-by: Ed Schouten
+ Signed-off-by: Alan Coopersmith
+
+commit d6570f5188ac8b223a2ae8d1ef596f313938acca
+Author: Ed Schouten
+Date: Sat Sep 15 20:26:57 2012 +0200
+
+ Make the `line' variable local to main().
+
+ It is only used within main(). This prevents a compilation failure when
+ building with -Wshadow.
+
+ Signed-off-by: Ed Schouten
+ Signed-off-by: Alan Coopersmith
+
+commit 8963bc3df6d3e9627c82171c3c931616f27fd528
+Author: Ed Schouten
+Date: Sat Sep 15 20:11:20 2012 +0200
+
+ Place NetBSD specific #defines in the proper place.
+
+ For all the other databases (utmp, wtmp, lastlog) we already do it in
+ sessreg.h. There's no reason why we should place the utmpx specific ones
+ in sessreg.c.
+
+ Signed-off-by: Ed Schouten
+ Signed-off-by: Alan Coopersmith
+
+commit 1d609a5daa3fa1553111076561a1f800e462156d
+Author: Thomas Klausner
+Date: Fri Jun 15 11:36:07 2012 +0200
+
+ Fix compilation on NetBSD - undefined *TMPX paths
+
+ Make sure file name defines exist on NetBSD.
+ https://bugs.freedesktop.org/show_bug.cgi?id=50940
+
+ Signed-off-by: Alan Coopersmith
+
commit 7ac51a652bfb8423604bb1a120568d44516c9de9
Author: Alan Coopersmith
Date: Fri Oct 21 21:09:43 2011 -0700
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.0.7/configure.ac new/sessreg-1.0.8/configure.ac
--- old/sessreg-1.0.7/configure.ac 2011-10-22 06:09:30.000000000 +0200
+++ new/sessreg-1.0.8/configure.ac 2013-02-11 03:43:50.000000000 +0100
@@ -22,7 +22,7 @@
# Initialize Autoconf
AC_PREREQ([2.60])
-AC_INIT([sessreg], [1.0.7],
+AC_INIT([sessreg], [1.0.8],
[https://bugs.freedesktop.org/enter_bug.cgi?product=xorg], [sessreg])
AC_CONFIG_SRCDIR([Makefile.am])
AC_CONFIG_HEADERS([config.h])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.0.7/man/sessreg.man new/sessreg-1.0.8/man/sessreg.man
--- old/sessreg-1.0.7/man/sessreg.man 2011-01-21 08:23:48.000000000 +0100
+++ new/sessreg-1.0.8/man/sessreg.man 2013-02-11 03:43:50.000000000 +0100
@@ -38,6 +38,7 @@
[-s \fIslot-number\fP]
[-x \fIXservers-file\fP]
[-t \fIttys-file\fP]
+[-V]
[-a]
[-d]
\fIuser-name\fP
@@ -123,6 +124,8 @@
.IP "\fB-t\fP \fIttys-file\fP"
This specifies an alternate file which the \fI-x\fP option will use to count
the number of terminal sessions on a host.
+.IP "\fB-V\fP"
+This option causes the command to print its version and exit.
.IP "\fB-a\fP"
This session should be added to utmp/wtmp.
.IP "\fB-d\fP"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.0.7/sessreg.c new/sessreg-1.0.8/sessreg.c
--- old/sessreg-1.0.7/sessreg.c 2011-09-27 01:01:11.000000000 +0200
+++ new/sessreg-1.0.8/sessreg.c 2013-02-11 03:43:50.000000000 +0100
@@ -90,7 +90,6 @@
static int wflag, uflag, lflag;
static const char *wtmp_file, *utmp_file;
-static char *line;
#ifdef USE_UTMPX
#ifdef HAVE_UPDWTMPX
static const char *wtmpx_file = NULL;
@@ -99,6 +98,7 @@
static const char *utmpx_file = NULL;
#endif
#endif
+
static int utmp_none, wtmp_none;
/*
* BSD specific variables. To make life much easier for Xstartup/Xreset
@@ -130,13 +130,15 @@
usage (int x)
{
if (x) {
- fprintf (stderr, "%s: usage %s {-a -d} [-w wtmp-file] [-u utmp-file]", program_name, program_name);
+ fprintf (stderr,
+ "%s: usage %s {-a -d} [-w wtmp-file] [-u utmp-file]"
#ifdef USE_LASTLOG
- fprintf (stderr, " [-L lastlog-file]");
+ " [-L lastlog-file]"
#endif
- fprintf (stderr, "\n");
- fprintf (stderr, " [-t ttys-file] [-l line-name] [-h host-name]\n");
- fprintf (stderr, " [-s slot-number] [-x servers-file] user-name\n");
+ "\n"
+ " [-t ttys-file] [-l line-name] [-h host-name] [-V]\n"
+ " [-s slot-number] [-x servers-file] user-name\n",
+ program_name, program_name);
exit (1);
}
return x;
@@ -194,6 +196,7 @@
#ifdef USE_UTMPX
struct utmpx utmpx_entry;
#endif
+ char * line = NULL;
program_name = argv[0];
while (*++argv && **argv == '-') {
@@ -238,6 +241,9 @@
case 'd':
dflag++;
break;
+ case 'V':
+ printf("%s\n", PACKAGE_STRING);
+ exit (0);
default:
usage (1);
}
@@ -257,16 +263,12 @@
wtmpx_file = WTMPX_FILE;
#endif
}
-#ifndef NO_UTMP
if (!uflag) {
utmp_file = UTMP_FILE;
#if defined(USE_UTMPX) && defined(HAVE_UTMPXNAME)
utmpx_file = UTMPX_FILE;
#endif
}
-#else
- utmp_none = 1;
-#endif
#ifdef USE_LASTLOG
if (!Lflag)
llog_file = LLOG_FILE;
@@ -360,7 +362,7 @@
if (llog != -1) {
struct lastlog ll;
- sysnerr (lseek(llog, (long) pwd->pw_uid*sizeof(ll), 0)
+ sysnerr (lseek(llog, (long) (pwd->pw_uid*sizeof(ll)), 0)
!= -1, "seeking lastlog entry");
memset(&ll, 0, sizeof(ll));
ll.ll_time = current_time;
@@ -397,7 +399,7 @@
memset (u->ut_name, 0, sizeof (u->ut_name));
#ifdef HAVE_STRUCT_UTMP_UT_ID
if (line) {
- int i;
+ size_t i;
/*
* this is a bit crufty, but
* follows the apparent conventions in
@@ -486,7 +488,7 @@
memset (u->ut_user, 0, sizeof (u->ut_user));
if (line) {
- int i;
+ size_t i;
/*
* this is a bit crufty, but
* follows the apparent conventions in
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/sessreg-1.0.7/sessreg.h new/sessreg-1.0.8/sessreg.h
--- old/sessreg-1.0.7/sessreg.h 2011-06-26 18:30:31.000000000 +0200
+++ new/sessreg-1.0.8/sessreg.h 2013-02-11 03:43:50.000000000 +0100
@@ -75,13 +75,6 @@
# define USE_LASTLOG
#endif
-#ifdef CSRG_BASED
-#if !defined(__FreeBSD__) && !defined(__OpenBSD__)
-/* *BSD doesn't like a ':0' type entry in utmp */
-#define NO_UTMP
-#endif
-#endif
-
#ifndef WTMP_FILE
# ifdef _PATH_WTMP
# define WTMP_FILE _PATH_WTMP
@@ -106,3 +99,10 @@
#ifndef TTYS_FILE
# define TTYS_FILE "/etc/ttys"
#endif
+
+#ifndef WTMPX_FILE
+# define WTMPX_FILE _PATH_WTMPX
+#endif
+#ifndef UTMPX_FILE
+# define UTMPX_FILE _PATH_UTMPX
+#endif
--
To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-commit+help@opensuse.org