Hello community, here is the log from the commit of package gstreamer-0_10 for openSUSE:Factory checked in at 2012-12-14 07:49:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gstreamer-0_10 (Old) and /work/SRC/openSUSE:Factory/.gstreamer-0_10.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "gstreamer-0_10", Maintainer is "gnome-maintainers@suse.de" Changes: -------- --- /work/SRC/openSUSE:Factory/gstreamer-0_10/gstreamer-0_10.changes 2012-09-17 16:56:13.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.gstreamer-0_10.new/gstreamer-0_10.changes 2012-12-14 07:49:55.000000000 +0100 @@ -1,0 +2,6 @@ +Mon Dec 10 15:50:24 UTC 2012 - dimstar@opensuse.org + +- Add gstreamer-no-setlocale.patch: Don't set the locale in + gst_init() (bnc#779426, bgo#685650). + +------------------------------------------------------------------- New: ---- gstreamer-no-setlocale.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gstreamer-0_10-doc.spec ++++++ --- /var/tmp/diff_new_pack.L3dG6K/_old 2012-12-14 07:49:58.000000000 +0100 +++ /var/tmp/diff_new_pack.L3dG6K/_new 2012-12-14 07:49:58.000000000 +0100 @@ -34,6 +34,8 @@ Patch0: gstreamer-0_10-no-gtk-doc-for-reals.patch # PATCH-FEATURE-UPSTREAM gstreamer-0_10-rpm-prov.patch bgo#588783 dimstar@opensuse.org -- Add --rpm parameter to allow creation of rpm provides, patch from fedora Patch1: gstreamer-0_10-rpm-prov.patch +# PATCH-FIX-UPSTREAM gstreamer-no-setlocale.patch bnc#779426 bgo#685650 dimstar@opensuse.org -- Don't set the locale in gst_init(). +Patch2: gstreamer-no-setlocale.patch BuildRequires: bison BuildRequires: check-devel BuildRequires: fdupes @@ -189,6 +191,7 @@ %patch0 -p1 %endif %patch1 -p1 +%patch2 -p1 gnome-patch-translation-update po gstreamer-0.10 %build ++++++ gstreamer-0_10.spec ++++++ --- /var/tmp/diff_new_pack.L3dG6K/_old 2012-12-14 07:49:58.000000000 +0100 +++ /var/tmp/diff_new_pack.L3dG6K/_new 2012-12-14 07:49:58.000000000 +0100 @@ -34,6 +34,8 @@ Patch0: gstreamer-0_10-no-gtk-doc-for-reals.patch # PATCH-FEATURE-UPSTREAM gstreamer-0_10-rpm-prov.patch bgo#588783 dimstar@opensuse.org -- Add --rpm parameter to allow creation of rpm provides, patch from fedora Patch1: gstreamer-0_10-rpm-prov.patch +# PATCH-FIX-UPSTREAM gstreamer-no-setlocale.patch bnc#779426 bgo#685650 dimstar@opensuse.org -- Don't set the locale in gst_init(). +Patch2: gstreamer-no-setlocale.patch BuildRequires: bison BuildRequires: check-devel BuildRequires: fdupes @@ -189,6 +191,7 @@ %patch0 -p1 %endif %patch1 -p1 +%patch2 -p1 gnome-patch-translation-update po gstreamer-0.10 %build ++++++ gstreamer-no-setlocale.patch ++++++
From 9326124581e65c7f4dc6a729f12c1dca77d564f3 Mon Sep 17 00:00:00 2001 From: Sebastian Drö
Date: Tue, 20 Nov 2012 11:56:12 +0000 Subject: gst: Don't set the locale in gst_init()
The function init_pre() in gstreamer/gst/gst.c calls setlocale(LC_ALL, ""), which sets the locale to the values specified in the environment. This is wrong for two reasons: 1. It is absolutely not the task of a library to decide on the correct locale for a program. Some programs change the locale for various (good or bad) reasons, and libraries should respect that. Programs where GStreamer's overwriting of the locale causes bugs include Emacs [1, 2], Sublime Text [3], and Lua [4]. [1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12392 [2] http://bugzilla.novell.com/show_bug.cgi?id=779426 [3] http://www.sublimetext.com/forum/viewtopic.php?f=3&t=8543 [4] https://github.com/pavouk/lgi/issues/19 Note that setting the locale can cause problems for programs that are not even linked against GStreamer. In the case of Emacs, for example, GStreamer seems to be initialized through GTK via libcanberra. 2. Setting the locale is not thread-safe, and therefore should not be done in a library. https://bugzilla.gnome.org/show_bug.cgi?id=685650 --- Index: gstreamer-0.10.36/gst/gst.c =================================================================== --- gstreamer-0.10.36.orig/gst/gst.c +++ gstreamer-0.10.36/gst/gst.c @@ -588,7 +588,6 @@ init_pre (GOptionContext * context, GOpt _gst_debug_init (); #ifdef ENABLE_NLS - setlocale (LC_ALL, ""); bindtextdomain (GETTEXT_PACKAGE, LOCALEDIR); bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8"); #endif /* ENABLE_NLS */ -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org