Hello community,
here is the log from the commit of package yast2-dbus-client for openSUSE:Factory checked in at 2011-12-12 16:59:58
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-dbus-client (Old)
and /work/SRC/openSUSE:Factory/.yast2-dbus-client.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-dbus-client", Maintainer is "mvidner@suse.com"
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-dbus-client/yast2-dbus-client.changes 2011-09-23 12:53:07.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-dbus-client.new/yast2-dbus-client.changes 2011-12-12 17:05:47.000000000 +0100
@@ -1,0 +2,6 @@
+Tue Nov 15 16:17:46 CET 2011 - aschnell@suse.de
+
+- return result of dbus command (needed for bnc #727538)
+- 2.22.0
+
+-------------------------------------------------------------------
Old:
----
yast2-dbus-client-2.21.0.tar.bz2
New:
----
yast2-dbus-client-2.22.0.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-dbus-client.spec ++++++
--- /var/tmp/diff_new_pack.5b8tXJ/_old 2011-12-12 17:05:53.000000000 +0100
+++ /var/tmp/diff_new_pack.5b8tXJ/_new 2011-12-12 17:05:53.000000000 +0100
@@ -15,24 +15,21 @@
# Please submit bugfixes or comments via http://bugs.opensuse.org/
#
-# norootforbuild
Name: yast2-dbus-client
-Version: 2.21.0
-Release: 1
+Version: 2.22.0
+Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
-Source0: yast2-dbus-client-2.21.0.tar.bz2
-
-Prefix: /usr
+Source0: yast2-dbus-client-%{version}.tar.bz2
Group: System/YaST
-License: GPL v2 or later
+License: GPL-2.0+
# obviously
BuildRequires: gcc-c++
# needed for all yast packages
-BuildRequires: yast2-core-devel yast2-devtools
+BuildRequires: libtool yast2-core-devel yast2-devtools
# docbook docs
BuildRequires: docbook-xsl-stylesheets libxslt
@@ -46,26 +43,26 @@
from YaST scripts.
%prep
-%setup -n yast2-dbus-client-2.21.0
+%setup -n yast2-dbus-client-%{version}
%build
-%{prefix}/bin/y2tool y2autoconf
-%{prefix}/bin/y2tool y2automake
+%{_prefix}/bin/y2tool y2autoconf
+%{_prefix}/bin/y2tool y2automake
autoreconf --force --install
export CFLAGS="$RPM_OPT_FLAGS -DNDEBUG"
export CXXFLAGS="$RPM_OPT_FLAGS -DNDEBUG"
%{?suse_update_config:%{suse_update_config -f}}
-./configure --libdir=%{_libdir} --prefix=%{prefix} --mandir=%{_mandir}
+./configure --libdir=%{_libdir} --prefix=%{_prefix} --mandir=%{_mandir}
# V=1: verbose build in case we used AM_SILENT_RULES(yes)
# so that RPM_OPT_FLAGS check works
make %{?jobs:-j%jobs} V=1
%install
make install DESTDIR="$RPM_BUILD_ROOT"
-[ -e "%{prefix}/share/YaST2/data/devtools/NO_MAKE_CHECK" ] || Y2DIR="$RPM_BUILD_ROOT/usr/share/YaST2" make check DESTDIR="$RPM_BUILD_ROOT"
-for f in `find $RPM_BUILD_ROOT/%{prefix}/share/applications/YaST2/ -name "*.desktop"` ; do
+[ -e "%{_prefix}/share/YaST2/data/devtools/NO_MAKE_CHECK" ] || Y2DIR="$RPM_BUILD_ROOT/usr/share/YaST2" make check DESTDIR="$RPM_BUILD_ROOT"
+for f in `find $RPM_BUILD_ROOT/%{_prefix}/share/applications/YaST2/ -name "*.desktop"` ; do
d=${f##*/}
%suse_update_desktop_file -d ycc_${d%.desktop} ${d%.desktop}
done
@@ -87,6 +84,7 @@
%{_libdir}/YaST2/plugin/lib*.so.*
/usr/share/YaST2/scrconf/*.scr
-%doc %{prefix}/share/doc/packages/yast2-dbus-client
+%doc %{_prefix}/share/doc/packages/yast2-dbus-client
%doc %{_datadir}/doc/yastdoc
+
%changelog
++++++ yast2-dbus-client-2.21.0.tar.bz2 -> yast2-dbus-client-2.22.0.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-dbus-client-2.21.0/Makefile.am new/yast2-dbus-client-2.22.0/Makefile.am
--- old/yast2-dbus-client-2.21.0/Makefile.am 2011-05-31 16:06:45.000000000 +0200
+++ new/yast2-dbus-client-2.22.0/Makefile.am 2011-12-12 10:27:56.000000000 +0100
@@ -20,7 +20,6 @@
IS_DEVTOOLS = $(findstring yast2-devtools,$(RPMNAME))
DEVTOOLS_DIR = $(if $(IS_DEVTOOLS),$(srcdir)/devtools,$(Y2DEVTOOLS_PREFIX)/share/YaST2/data/devtools)
-ALL_PACKAGES = $(DEVTOOLS_DIR)/admin/all-packages
LEGALESE_DIR = $(if $(HAS_YAST_LICENSE),$(DEVTOOLS_DIR)/admin/copyright/yast,$(DEVTOOLS_DIR)/admin/copyright/gpl)
COPYRIGHT_files_gpl = README COPYING
@@ -155,7 +154,7 @@
$(Y2TOOL) create-spec < $$i > $$here/package/$${newname} ; \
done
-package: check-up-to-date check-tagversion check-all-packages check-textdomain package-local
+package: check-up-to-date check-tagversion check-textdomain package-local
TAGVERSION = $(Y2TOOL) tagversion
@@ -185,21 +184,6 @@
check-parse:
@echo "Not running parseycp."
-check-all-packages:
- @if [ ! -e "$(ALL_PACKAGES)" ]; then \
- echo ERROR: "Can't find $(ALL_PACKAGES)"; false; \
- fi
- @if ! grep -q "^$(RPMNAME)[[:space:]]" $(ALL_PACKAGES); then \
- echo ERROR: "$(RPMNAME) not in $(ALL_PACKAGES)"; false; \
- fi
- @if grep -q "^$(RPMNAME)[[:space:]]\+.*?" $(ALL_PACKAGES); then \
- echo ERROR: "$(RPMNAME) info in $(ALL_PACKAGES) contains some unknown (?) fields:"; \
- echo; \
- grep "^$(RPMNAME)[[:space:]]\+.*?" $(ALL_PACKAGES); \
- echo; \
- false; \
- fi
-
check-textdomain:
$(Y2TOOL) check-textdomain $(srcdir)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-dbus-client-2.21.0/Makefile.in new/yast2-dbus-client-2.22.0/Makefile.in
--- old/yast2-dbus-client-2.21.0/Makefile.in 2011-05-31 16:06:54.000000000 +0200
+++ new/yast2-dbus-client-2.22.0/Makefile.in 2011-12-12 10:28:07.000000000 +0100
@@ -321,7 +321,6 @@
# do we do Makefile.am for devtools? It is a little special...
IS_DEVTOOLS = $(findstring yast2-devtools,$(RPMNAME))
DEVTOOLS_DIR = $(if $(IS_DEVTOOLS),$(srcdir)/devtools,$(Y2DEVTOOLS_PREFIX)/share/YaST2/data/devtools)
-ALL_PACKAGES = $(DEVTOOLS_DIR)/admin/all-packages
LEGALESE_DIR = $(if $(HAS_YAST_LICENSE),$(DEVTOOLS_DIR)/admin/copyright/yast,$(DEVTOOLS_DIR)/admin/copyright/gpl)
COPYRIGHT_files_gpl = README COPYING
COPYRIGHT_files_yast = YAST_LICENSE README COPYING COPYRIGHT.english \
@@ -992,7 +991,7 @@
$(Y2TOOL) create-spec < $$i > $$here/package/$${newname} ; \
done
-package: check-up-to-date check-tagversion check-all-packages check-textdomain package-local
+package: check-up-to-date check-tagversion check-textdomain package-local
check-up-to-date check-cvs-up-to-date check-svn-up-to-date:
if [ -d $(srcdir)/CVS ]; then \
@@ -1020,21 +1019,6 @@
check-parse:
@echo "Not running parseycp."
-check-all-packages:
- @if [ ! -e "$(ALL_PACKAGES)" ]; then \
- echo ERROR: "Can't find $(ALL_PACKAGES)"; false; \
- fi
- @if ! grep -q "^$(RPMNAME)[[:space:]]" $(ALL_PACKAGES); then \
- echo ERROR: "$(RPMNAME) not in $(ALL_PACKAGES)"; false; \
- fi
- @if grep -q "^$(RPMNAME)[[:space:]]\+.*?" $(ALL_PACKAGES); then \
- echo ERROR: "$(RPMNAME) info in $(ALL_PACKAGES) contains some unknown (?) fields:"; \
- echo; \
- grep "^$(RPMNAME)[[:space:]]\+.*?" $(ALL_PACKAGES); \
- echo; \
- false; \
- fi
-
check-textdomain:
$(Y2TOOL) check-textdomain $(srcdir)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-dbus-client-2.21.0/VERSION new/yast2-dbus-client-2.22.0/VERSION
--- old/yast2-dbus-client-2.21.0/VERSION 2011-05-31 16:03:52.000000000 +0200
+++ new/yast2-dbus-client-2.22.0/VERSION 2011-11-15 16:19:14.000000000 +0100
@@ -1 +1 @@
-2.21.0
+2.22.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-dbus-client-2.21.0/agent-dbus/src/DbusAgent.cc new/yast2-dbus-client-2.22.0/agent-dbus/src/DbusAgent.cc
--- old/yast2-dbus-client-2.21.0/agent-dbus/src/DbusAgent.cc 2011-05-31 16:01:49.000000000 +0200
+++ new/yast2-dbus-client-2.22.0/agent-dbus/src/DbusAgent.cc 2011-11-08 12:04:32.000000000 +0100
@@ -164,6 +164,7 @@
if (dbus_error_is_set(&error))
{
+ y2error("dbus_connection_send_with_reply_and_block() failed (%s)", error.message);
dbus_error_free(&error);
return YCPError("dbus_connection_send_with_reply_and_block() failed");
}
@@ -173,9 +174,29 @@
return YCPError("dbus_connection_send_with_reply_and_block() failed");
}
+ YCPList result;
+
+ DBusMessageIter reply_iter;
+ dbus_message_iter_init(reply, &reply_iter);
+ while (dbus_message_iter_get_arg_type(&reply_iter) != DBUS_TYPE_INVALID)
+ {
+ switch (dbus_message_iter_get_arg_type(&reply_iter))
+ {
+ case DBUS_TYPE_STRING:
+ {
+ const char* tmp;
+ dbus_message_iter_get_basic(&reply_iter, &tmp);
+ result.add(YCPString(tmp));
+ break;
+ }
+ }
+
+ dbus_message_iter_next(&reply_iter);
+ }
+
dbus_message_unref(reply);
- return YCPBoolean(true);
+ return result;
}
return YCPError(string("Undefined subpath for Execute(") + path->toString() + ")");
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-dbus-client-2.21.0/configure new/yast2-dbus-client-2.22.0/configure
--- old/yast2-dbus-client-2.21.0/configure 2011-05-31 16:06:53.000000000 +0200
+++ new/yast2-dbus-client-2.22.0/configure 2011-12-12 10:28:05.000000000 +0100
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.68 for yast2-dbus-client 2.21.0.
+# Generated by GNU Autoconf 2.68 for yast2-dbus-client 2.22.0.
#
# Report bugs to http://bugs.opensuse.org/.
#
@@ -709,8 +709,8 @@
# Identity of this package.
PACKAGE_NAME='yast2-dbus-client'
PACKAGE_TARNAME='yast2-dbus-client'
-PACKAGE_VERSION='2.21.0'
-PACKAGE_STRING='yast2-dbus-client 2.21.0'
+PACKAGE_VERSION='2.22.0'
+PACKAGE_STRING='yast2-dbus-client 2.22.0'
PACKAGE_BUGREPORT='http://bugs.opensuse.org/'
PACKAGE_URL=''
@@ -1500,7 +1500,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures yast2-dbus-client 2.21.0 to adapt to many kinds of systems.
+\`configure' configures yast2-dbus-client 2.22.0 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1572,7 +1572,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of yast2-dbus-client 2.21.0:";;
+ short | recursive ) echo "Configuration of yast2-dbus-client 2.22.0:";;
esac
cat <<\_ACEOF
@@ -1688,7 +1688,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-yast2-dbus-client configure 2.21.0
+yast2-dbus-client configure 2.22.0
generated by GNU Autoconf 2.68
Copyright (C) 2010 Free Software Foundation, Inc.
@@ -2141,7 +2141,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by yast2-dbus-client $as_me 2.21.0, which was
+It was created by yast2-dbus-client $as_me 2.22.0, which was
generated by GNU Autoconf 2.68. Invocation command line was
$ $0 $@
@@ -3071,7 +3071,7 @@
# Define the identity of the package.
PACKAGE='yast2-dbus-client'
- VERSION='2.21.0'
+ VERSION='2.22.0'
cat >>confdefs.h <<_ACEOF
@@ -3193,7 +3193,7 @@
-VERSION="2.21.0"
+VERSION="2.22.0"
RPMNAME="yast2-dbus-client"
MAINTAINER="Arvin Schnell