Hello community, here is the log from the commit of package lightdm for openSUSE:Factory checked in at 2011-11-10 15:50:25 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lightdm (Old) and /work/SRC/openSUSE:Factory/.lightdm.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "lightdm", Maintainer is "" Changes: -------- --- /work/SRC/openSUSE:Factory/lightdm/lightdm.changes 2011-11-05 11:49:29.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.lightdm.new/lightdm.changes 2011-11-10 15:50:27.000000000 +0100 @@ -1,0 +2,9 @@ +Thu Nov 10 08:53:40 UTC 2011 - gber@opensuse.org + +- added lightdm-remove-xauthority-ownership-fix.patch which removes + the code correcting the ownership of .Xauthority files, it is + still not secure and the buggy LightDM version writing + .Xauthrotiy as root never was in a released openSUSE version + anyway + +------------------------------------------------------------------- New: ---- lightdm-remove-xauthority-ownership-fix.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lightdm.spec ++++++ --- /var/tmp/diff_new_pack.psFUuM/_old 2011-11-10 15:50:28.000000000 +0100 +++ /var/tmp/diff_new_pack.psFUuM/_new 2011-11-10 15:50:28.000000000 +0100 @@ -48,6 +48,8 @@ Patch5: lightdm-default-configuration.patch # PATCH-FIX-UPSTREAM lightdm-lock-screen-before-switch.patch gber@opensuse.org -- Try to lock the screen before switching users Patch7: lightdm-lock-screen-before-switch.patch +# PATCH-FIX-UPSTREAM lightdm-remove-xauthority-ownership-fix.patch gber@opensuse.org -- Remove the code correcting the ownership of .Xauthority files, it is still not secure and the buggy LightDM version writing .Xauthrotiy as root never was in a released openSUSE version anyway +Patch8: lightdm-remove-xauthority-ownership-fix.patch BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(xcb) BuildRequires: pkgconfig(xdmcp) @@ -173,6 +175,7 @@ %patch4 -p1 %patch5 -p1 %patch7 -p1 +%patch8 -p1 %build ./autogen.sh ++++++ lightdm-remove-xauthority-ownership-fix.patch ++++++ # HG changeset patch # Parent 50fa5a8c7f9d9a5b15b246ab29b0fedd373d42d4 removed the code correcting the ownership of .Xauthority files, it is still not secure and the buggy LightDM version writing .Xauthrotiy as root never was in a released openSUSE version anyway diff --git a/src/xsession.c b/src/xsession.c --- a/src/xsession.c +++ b/src/xsession.c @@ -102,16 +102,6 @@ xsession_setup (Session *session) else { path = g_build_filename (user_get_home_directory (session_get_user (session)), ".Xauthority", NULL); - - /* Workaround the case where the authority file might have been - * incorrectly written as root in a buggy version of LightDM */ - if (getuid () == 0) - { - int result; - result = lchown (path, user_get_uid (session_get_user (session)), user_get_gid (session_get_user (session))); - if (result < 0 && errno != ENOENT) - g_warning ("Failed to correct ownership of %s: %s", path, strerror (errno)); - } } session_set_env (session, "XAUTHORITY", path); -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org