commit PolicyKit for openSUSE:Factory

Hello community, here is the log from the commit of package PolicyKit for openSUSE:Factory checked in at Mon Jun 29 15:21:08 CEST 2009. -------- --- PolicyKit/PolicyKit.changes 2009-01-22 17:55:56.000000000 +0100 +++ PolicyKit/PolicyKit.changes 2009-06-20 18:04:32.000000000 +0200 @@ -1,0 +2,6 @@ +Sat Jun 20 16:04:06 UTC 2009 - lnussel@novell.com + +- don't ignore errors in polkit_context_is_caller_authorized + (bnc#509108) + +------------------------------------------------------------------- PolicyKit-doc.changes: same change calling whatdependson for head-i586 New: ---- PolicyKit-0.9-polkit_context_is_caller_authorized.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ PolicyKit-doc.spec ++++++ --- /var/tmp/diff_new_pack.P24503/_old 2009-06-29 15:17:58.000000000 +0200 +++ /var/tmp/diff_new_pack.P24503/_new 2009-06-29 15:17:58.000000000 +0200 @@ -36,13 +36,13 @@ %if !%build_doc PreReq: permissions /usr/sbin/groupadd /usr/sbin/useradd %endif -Url: http://www.freedesktop.org/wiki/Software/hal -License: X11/MIT -Group: Documentation/Other +Url: http://www.freedesktop.org/wiki/Software/PolicyKit +License: MIT License (or similar) +Group: System/Libraries Version: 0.9 -Release: 14 +Release: 16 AutoReqProv: on -Summary: Documentation for PolicyKit +Summary: Authorization Toolkit BuildRoot: %{_tmppath}/%{name}-%{version}-build %if %build_doc Requires: PolicyKit = %{version} @@ -57,6 +57,7 @@ Patch3: PolicyKit-0.9-unset-dbus-error-if-AuthenticationAgent-is-not-availa.diff Patch4: PolicyKit-0.9-allow-root-to-obtain-privileges.diff Patch5: PolicyKit-0.9-dbuspolicy.diff +Patch6: PolicyKit-0.9-polkit_context_is_caller_authorized.diff %description PolicyKit is a toolkit for defining and handling authorizations. It is @@ -72,7 +73,7 @@ %if !%build_doc %package -n PolicyKit-devel -License: X11/MIT +License: MIT License (or similar) Summary: Development files for PolicyKit Group: Development/Libraries/Other Requires: %{name} = %{version} dbus-1-glib-devel glib2-devel dbus-1-devel @@ -100,6 +101,7 @@ %patch3 -p1 %patch4 -p1 %patch5 -p1 +%patch6 -p1 %build %configure \ @@ -214,7 +216,7 @@ %{_datadir}/dbus-1/system-services/org.freedesktop.PolicyKit.service %config %{_sysconfdir}/dbus-1/system.d/org.freedesktop.PolicyKit.conf %{_prefix}/lib/PolicyKit/polkitd -%attr(644,root,root) %{_sysconfdir}/profile.d/polkit-bash-completion.sh +%config %attr(644,root,root) %{_sysconfdir}/profile.d/polkit-bash-completion.sh %files -n PolicyKit-devel %defattr(-,root,root) @@ -225,152 +227,3 @@ %endif %changelog -* Thu Jan 22 2009 lnussel@suse.de -- fix dbus policy (bnc#468386) -* Thu Nov 06 2008 lnussel@suse.de -- allow root to obtain privileges (bnc#431474) -* Tue Nov 04 2008 lnussel@suse.de -- another place where dbus error needs to be unset (bnc#439473) -* Fri Oct 31 2008 lnussel@suse.de -- unset dbus error is some non-error cases (bnc#439150) -* Thu Oct 02 2008 lnussel@suse.de -- don't set exe constraints if the resolve-exe-helper isn't setuid root -- fix permissions to match new setting in level 'secure' -* Wed Sep 10 2008 lnussel@suse.de -- conditional SELinux support to allow build on older distros -* Fri Aug 29 2008 jpr@suse.de -- Update to 0.9 - * need to link with libkit.la for some helpers - * build fixes - * always allow uid 0 to ask about authorizations for anyone - * fix up permissions / docs for certain helpers and files/directories - * remove watch on fd when reaching EOF -* Mon Aug 25 2008 dmueller@suse.de -- fix installed headers to compile with -pedantic -* Wed Aug 20 2008 prusnak@suse.cz -- enabled SELinux support [Fate#303662] -* Thu Apr 17 2008 kay.sievers@novell.com -- replace git snapshot with now released version 0.8 - print warning to stderr if a policy file is malformed -* Thu Apr 10 2008 ro@suse.de -- added baselibs.conf file to build xxbit packages - for multilib support -* Wed Apr 09 2008 kay.sievers@novell.com -- update to git snapshot - fixes format string vulnerability CVE-2008-1658 (bnc#375832) - fixes polkit-bash-completion.sh - fixes https://bugzilla.novell.com/show_bug.cgi?id=295341#c25 -* Wed Mar 12 2008 kay.sievers@novell.com -- change %%_libexecdir to %%_prefix/lib as requested in (bnc#295341) -* Sat Jan 26 2008 hmacht@suse.de -- PolicyKit-0.7-use-stat.patch: - On reiserfs, d_type from readdir() is set to DT_UNKNOWN, so use - stat -* Wed Jan 02 2008 kay.sievers@novell.com -- add Recommend: PolicyKit-doc package -- this sets the expected permissions, if the updated - /etc/permissions.* (bnc#295341) is not available at installation time: - [#] chown root:polkituser /usr/lib64/PolicyKit/polkit-* - [#] chmod 2755 /usr/lib64/PolicyKit/polkit-* - [#] chmod 4755 /usr/lib64/PolicyKit/polkit-grant-helper-pam -* Thu Dec 20 2007 kay.sievers@novell.com -- updated to v0.7 - - All code is now licensed under the MIT/X11 license - - libpolkit and libpolkit-dbus no longer depends on libglib. - - Unit test framework and coverage reporting. As of this release, 64% - of the codebase is currently tested during 'make check'. - - New system D-Bus service (activated on demand) providing the major - functionality of libpolkit.so from a mechanism point of view. This - is useful for chroot(2)'ed services like Avahi. - - A class for tracking D-Bus connections to minimize the amount - of IPC necessary. Useful for long running daemons. - - Pluggable authorization database backend. - - New API for interacting with the authorization database - - A very simple convenience API useful for (legacy) commandline tools. - - A way to specify that an implicit authorization can be one-shot - only. - - Vendor name, site and icon support in .policy files. - - Improved documentation. - - Negative authorizations. - - Bash completions for all command line tools. -- needs /etc/permissions.* update (bnc#295341) -* Wed Oct 17 2007 dkukawka@suse.de -- updated to v0.6: - - This is the fourth release of PolicyKit. There are no major - changes since 0.5 expect - a) better handling of unknown XML tags in the config and policy - files (we simply ignore unknown sub-trees) to make it easier to - add features in the future; - b) native support for more distributions; and - c) the addition of a tag to the .policy files. -- removed all previous patches -- moved man pages to -doc package due to dependency to xsltproc -* Sat Aug 11 2007 aj@suse.de -- Make separate spec file for PolicyKit-doc so that PolicyKit does - not require TeX for building. -* Sat Aug 11 2007 meissner@suse.de -- binaries are packed with permissions in "secure" mode. -- run fdupes -- require dbus-1-devel in -devel too -* Fri Aug 10 2007 coolo@suse.de -- remove Permissions script - went to permissions -* Fri Aug 03 2007 dkukawka@suse.de -- added already upstream send patches: - - polkit-allow-DBus_v0.61.diff: allow build against same DBus - versions as HAL - - polkit-fix-code_docu.diff - - polkit-fix-compilerWarning.diff - - polkit-fix-struct_naming.diff - - polkit-fix-uid_t-compilerwarning.diff -* Tue Jul 31 2007 kay.sievers@suse.de -- update to git HEAD - move PAM stack usage to very tiny separate setuid root helper - add waitpid() to get SIGCHLD in error path handling -* Sun Jul 29 2007 kay.sievers@suse.de -- add /etc/permissions.d/PolicyKit and enable setguid for helper -* Sun Jul 29 2007 kay.sievers@suse.de -- configure --with-os-type=suse -- install helper binaries in %%{_libexecdir}/PolicyKit/ -* Fri Jul 27 2007 kay.sievers@suse.de -- update to version 0.4 - complete rewrite, not a daemon anymore -- BETA checkin to prepare HAL and resmgr update - "chmod 2775 /usr/lib(64)/polkit-grant-helper" - is needed for now, until /etc/permissions.secure is updated -* Thu Mar 08 2007 lrupp@suse.de -- remove obsolete %%pre section -* Wed Mar 07 2007 sbrabec@suse.cz -- Created -devel and -doc subpackage (#248813). -* Fri Mar 02 2007 ro@suse.de -- do not rebuild docu, remove xmlto from build requires - (causes extreme build dependencies) -* Mon Nov 27 2006 dmueller@suse.de -- install documentation in %%_docdir, not somewhere else -* Tue Nov 14 2006 lnussel@suse.de -- also restart resmgr after PolicyKit restart in order to restore - desktop-console settings (#220265) -* Sun Nov 12 2006 dkukawka@suse.de -- fixed bugs: - - b.n.c #216805: added policykitd to runlevel 2 -* Thu Oct 26 2006 lnussel@suse.de -- fix pam config by telling configure that we are on suse (#203526) -* Wed Oct 25 2006 thoenig@suse.de -- Add patch: PolicyKit-dbus-reconnect-thoenig-01.patch: Make - PolicyKit survive D-Bus restarts (b.n.c #214905) -* Wed Sep 06 2006 lnussel@suse.de -- use resmgr for login tracking -* Mon Sep 04 2006 seife@suse.de -- fix init script to at least not throw up on syntax errors. -* Tue Aug 22 2006 dkukawka@suse.de -- updated to current git HEAD (git20060822) - - updated rc file -- removed upstream gone patches: - - PolicyKit-fix-compiler_warnings.diff - - fix to get 'make distcheck' running -* Wed Aug 09 2006 thoenig@suse.de -- BuildRequires (hal): replace dbus-1-devel by dbus-1-glib-devel -- BuildRequires (hal-devel): add dbus-1-glib-devel -* Thu Aug 03 2006 dkukawka@suse.de -- added a startscript for polkitd -* Tue Jul 25 2006 dkukawka@suse.de -- initial version ++++++ PolicyKit.spec ++++++ --- /var/tmp/diff_new_pack.P24503/_old 2009-06-29 15:17:58.000000000 +0200 +++ /var/tmp/diff_new_pack.P24503/_new 2009-06-29 15:17:58.000000000 +0200 @@ -37,10 +37,10 @@ PreReq: permissions /usr/sbin/groupadd /usr/sbin/useradd %endif Url: http://www.freedesktop.org/wiki/Software/PolicyKit -License: X11/MIT +License: MIT License (or similar) Group: System/Libraries Version: 0.9 -Release: 13 +Release: 15 AutoReqProv: on Summary: Authorization Toolkit BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -57,6 +57,7 @@ Patch3: PolicyKit-0.9-unset-dbus-error-if-AuthenticationAgent-is-not-availa.diff Patch4: PolicyKit-0.9-allow-root-to-obtain-privileges.diff Patch5: PolicyKit-0.9-dbuspolicy.diff +Patch6: PolicyKit-0.9-polkit_context_is_caller_authorized.diff %description PolicyKit is a toolkit for defining and handling authorizations. It is @@ -72,7 +73,7 @@ %if !%build_doc %package -n PolicyKit-devel -License: X11/MIT +License: MIT License (or similar) Summary: Development files for PolicyKit Group: Development/Libraries/Other Requires: %{name} = %{version} dbus-1-glib-devel glib2-devel dbus-1-devel @@ -100,6 +101,7 @@ %patch3 -p1 %patch4 -p1 %patch5 -p1 +%patch6 -p1 %build %configure \ @@ -214,7 +216,7 @@ %{_datadir}/dbus-1/system-services/org.freedesktop.PolicyKit.service %config %{_sysconfdir}/dbus-1/system.d/org.freedesktop.PolicyKit.conf %{_prefix}/lib/PolicyKit/polkitd -%attr(644,root,root) %{_sysconfdir}/profile.d/polkit-bash-completion.sh +%config %attr(644,root,root) %{_sysconfdir}/profile.d/polkit-bash-completion.sh %files -n PolicyKit-devel %defattr(-,root,root) @@ -225,152 +227,3 @@ %endif %changelog -* Thu Jan 22 2009 lnussel@suse.de -- fix dbus policy (bnc#468386) -* Thu Nov 06 2008 lnussel@suse.de -- allow root to obtain privileges (bnc#431474) -* Tue Nov 04 2008 lnussel@suse.de -- another place where dbus error needs to be unset (bnc#439473) -* Fri Oct 31 2008 lnussel@suse.de -- unset dbus error is some non-error cases (bnc#439150) -* Thu Oct 02 2008 lnussel@suse.de -- don't set exe constraints if the resolve-exe-helper isn't setuid root -- fix permissions to match new setting in level 'secure' -* Wed Sep 10 2008 lnussel@suse.de -- conditional SELinux support to allow build on older distros -* Fri Aug 29 2008 jpr@suse.de -- Update to 0.9 - * need to link with libkit.la for some helpers - * build fixes - * always allow uid 0 to ask about authorizations for anyone - * fix up permissions / docs for certain helpers and files/directories - * remove watch on fd when reaching EOF -* Mon Aug 25 2008 dmueller@suse.de -- fix installed headers to compile with -pedantic -* Wed Aug 20 2008 prusnak@suse.cz -- enabled SELinux support [Fate#303662] -* Thu Apr 17 2008 kay.sievers@novell.com -- replace git snapshot with now released version 0.8 - print warning to stderr if a policy file is malformed -* Thu Apr 10 2008 ro@suse.de -- added baselibs.conf file to build xxbit packages - for multilib support -* Wed Apr 09 2008 kay.sievers@novell.com -- update to git snapshot - fixes format string vulnerability CVE-2008-1658 (bnc#375832) - fixes polkit-bash-completion.sh - fixes https://bugzilla.novell.com/show_bug.cgi?id=295341#c25 -* Wed Mar 12 2008 kay.sievers@novell.com -- change %%_libexecdir to %%_prefix/lib as requested in (bnc#295341) -* Sat Jan 26 2008 hmacht@suse.de -- PolicyKit-0.7-use-stat.patch: - On reiserfs, d_type from readdir() is set to DT_UNKNOWN, so use - stat -* Wed Jan 02 2008 kay.sievers@novell.com -- add Recommend: PolicyKit-doc package -- this sets the expected permissions, if the updated - /etc/permissions.* (bnc#295341) is not available at installation time: - [#] chown root:polkituser /usr/lib64/PolicyKit/polkit-* - [#] chmod 2755 /usr/lib64/PolicyKit/polkit-* - [#] chmod 4755 /usr/lib64/PolicyKit/polkit-grant-helper-pam -* Thu Dec 20 2007 kay.sievers@novell.com -- updated to v0.7 - - All code is now licensed under the MIT/X11 license - - libpolkit and libpolkit-dbus no longer depends on libglib. - - Unit test framework and coverage reporting. As of this release, 64% - of the codebase is currently tested during 'make check'. - - New system D-Bus service (activated on demand) providing the major - functionality of libpolkit.so from a mechanism point of view. This - is useful for chroot(2)'ed services like Avahi. - - A class for tracking D-Bus connections to minimize the amount - of IPC necessary. Useful for long running daemons. - - Pluggable authorization database backend. - - New API for interacting with the authorization database - - A very simple convenience API useful for (legacy) commandline tools. - - A way to specify that an implicit authorization can be one-shot - only. - - Vendor name, site and icon support in .policy files. - - Improved documentation. - - Negative authorizations. - - Bash completions for all command line tools. -- needs /etc/permissions.* update (bnc#295341) -* Wed Oct 17 2007 dkukawka@suse.de -- updated to v0.6: - - This is the fourth release of PolicyKit. There are no major - changes since 0.5 expect - a) better handling of unknown XML tags in the config and policy - files (we simply ignore unknown sub-trees) to make it easier to - add features in the future; - b) native support for more distributions; and - c) the addition of a tag to the .policy files. -- removed all previous patches -- moved man pages to -doc package due to dependency to xsltproc -* Sat Aug 11 2007 aj@suse.de -- Make separate spec file for PolicyKit-doc so that PolicyKit does - not require TeX for building. -* Sat Aug 11 2007 meissner@suse.de -- binaries are packed with permissions in "secure" mode. -- run fdupes -- require dbus-1-devel in -devel too -* Fri Aug 10 2007 coolo@suse.de -- remove Permissions script - went to permissions -* Fri Aug 03 2007 dkukawka@suse.de -- added already upstream send patches: - - polkit-allow-DBus_v0.61.diff: allow build against same DBus - versions as HAL - - polkit-fix-code_docu.diff - - polkit-fix-compilerWarning.diff - - polkit-fix-struct_naming.diff - - polkit-fix-uid_t-compilerwarning.diff -* Tue Jul 31 2007 kay.sievers@suse.de -- update to git HEAD - move PAM stack usage to very tiny separate setuid root helper - add waitpid() to get SIGCHLD in error path handling -* Sun Jul 29 2007 kay.sievers@suse.de -- add /etc/permissions.d/PolicyKit and enable setguid for helper -* Sun Jul 29 2007 kay.sievers@suse.de -- configure --with-os-type=suse -- install helper binaries in %%{_libexecdir}/PolicyKit/ -* Fri Jul 27 2007 kay.sievers@suse.de -- update to version 0.4 - complete rewrite, not a daemon anymore -- BETA checkin to prepare HAL and resmgr update - "chmod 2775 /usr/lib(64)/polkit-grant-helper" - is needed for now, until /etc/permissions.secure is updated -* Thu Mar 08 2007 lrupp@suse.de -- remove obsolete %%pre section -* Wed Mar 07 2007 sbrabec@suse.cz -- Created -devel and -doc subpackage (#248813). -* Fri Mar 02 2007 ro@suse.de -- do not rebuild docu, remove xmlto from build requires - (causes extreme build dependencies) -* Mon Nov 27 2006 dmueller@suse.de -- install documentation in %%_docdir, not somewhere else -* Tue Nov 14 2006 lnussel@suse.de -- also restart resmgr after PolicyKit restart in order to restore - desktop-console settings (#220265) -* Sun Nov 12 2006 dkukawka@suse.de -- fixed bugs: - - b.n.c #216805: added policykitd to runlevel 2 -* Thu Oct 26 2006 lnussel@suse.de -- fix pam config by telling configure that we are on suse (#203526) -* Wed Oct 25 2006 thoenig@suse.de -- Add patch: PolicyKit-dbus-reconnect-thoenig-01.patch: Make - PolicyKit survive D-Bus restarts (b.n.c #214905) -* Wed Sep 06 2006 lnussel@suse.de -- use resmgr for login tracking -* Mon Sep 04 2006 seife@suse.de -- fix init script to at least not throw up on syntax errors. -* Tue Aug 22 2006 dkukawka@suse.de -- updated to current git HEAD (git20060822) - - updated rc file -- removed upstream gone patches: - - PolicyKit-fix-compiler_warnings.diff - - fix to get 'make distcheck' running -* Wed Aug 09 2006 thoenig@suse.de -- BuildRequires (hal): replace dbus-1-devel by dbus-1-glib-devel -- BuildRequires (hal-devel): add dbus-1-glib-devel -* Thu Aug 03 2006 dkukawka@suse.de -- added a startscript for polkitd -* Tue Jul 25 2006 dkukawka@suse.de -- initial version ++++++ PolicyKit-0.9-polkit_context_is_caller_authorized.diff ++++++

From f3f0bc45b499067dc7b07a1f61b7eb64837c23fa Mon Sep 17 00:00:00 2001 From: Ludwig Nussel Date: Wed, 17 Jun 2009 15:21:42 +0200 Subject: [PATCH] don't ignore errors in polkit_context_is_caller_authorized (bnc#509108)

--- src/polkit/polkit-context.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/polkit/polkit-context.c b/src/polkit/polkit-context.c index 14d08f0..3afd942 100644 --- a/src/polkit/polkit-context.c +++ b/src/polkit/polkit-context.c @@ -921,7 +921,12 @@ polkit_context_is_caller_authorized (PolKitContext *pk_context, revoke_if_one_shot, &from_authdb, &from_authdb_negative, - NULL /* TODO */)) { + error)) { + + if (error && polkit_error_is_set (*error)) { + goto out; + } + if (from_authdb) result_from_grantdb = POLKIT_RESULT_YES; } -- 1.6.2.1 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org