Mailinglist Archive: opensuse-commit (817 mails)

[root@xxxxxxxxxxxxxxx (h_root)]

Hello community,

here is the log from the commit of package uClibc for openSUSE:Factory
checked in at Mon Dec 15 15:10:38 CET 2008.


--------
--- uClibc/uClibc.changes       2008-11-13 10:44:18.000000000 +0100
+++ /mounts/work_src_done/STABLE/uClibc/uClibc.changes  2008-12-15 
10:43:04.000000000 +0100
@@ -1,0 +2,6 @@
+Mon Dec 15 10:42:25 CET 2008 - sassmann@xxxxxxx
+
+- add uClibc.static-segfault-fix.patch: fix segfault of static
+  binaries that don't stdio functions
+
+-------------------------------------------------------------------

calling whatdependson for head-i586


New:
----
  uClibc.static-segfault-fix.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ uClibc.spec ++++++
--- /var/tmp/diff_new_pack.tV1195/_old  2008-12-15 15:10:24.000000000 +0100
+++ /var/tmp/diff_new_pack.tV1195/_new  2008-12-15 15:10:24.000000000 +0100
@@ -21,7 +21,7 @@
 
 Name:           uClibc
 Version:        0.9.30
-Release:        1
+Release:        2
 Summary:        A full-featured C library optimized for size
 License:        LGPL v2.1 or later
 BuildRequires:  linux-kernel-headers ncurses-devel
@@ -43,6 +43,7 @@
 Source2:        gcc-uClibc.in
 Source3:        README.SUSE
 Patch0:         uClibc.Makefile-gcc-uClibc-wrapper.patch
+Patch1:         uClibc.static-segfault-fix.patch
 Group:          System/Libraries
 
 %description
@@ -62,6 +63,7 @@
 %prep
 %setup -q
 %patch0 -p1
+%patch1 -p1
 cp %{S:1} .config
 cp %{S:2} gcc-uClibc.in
 cp %{S:3} README.SUSE
@@ -127,6 +129,9 @@
 #/usr/lib/*-linux-uclibc/usr/lib/*.so
 
 %changelog
+* Mon Dec 15 2008 sassmann@xxxxxxx
+- add uClibc.static-segfault-fix.patch: fix segfault of static
+  binaries that don't stdio functions
 * Thu Nov 13 2008 sassmann@xxxxxxx
 - update to version 0.9.30
   * for full changelog check

++++++ uClibc.static-segfault-fix.patch ++++++
> From joe@xxxxxxxxxxxxx Thu Jul 17 18:36:26 2008

I noticed in your July 
13th blog entry that you've hit the uClibc static segfaulting bug.  I'm 
really surprised no one fixed this before because it was the first thing 
I did with my first uClibc toolchain.  'int main(){return 0;}' is like 
the Ur-loWorld of toolchainery, especially when one is concerned with 
static-binary-byte-bloat which seems to be an obsession of uClibbers.

Anyway, that was about 4 days ago so you've probably fixed it by now, 
but just in case you haven't I'm passing along my patch for it.  (Not to 
worry, I haven't released anything yet so there's no GPL violation, and 
I'm hereby putting my patch into the public domain in case you want to 
submit it to uClibc)

diff -ru uClibc-0.9.29-old/libc/misc/internals/__uClibc_main.c 
uClibc-0.9.29/libc/misc/internals/__uClibc_main.c
--- uClibc-0.9.29-old/libc/misc/internals/__uClibc_main.c       2007-01-11 
16:39:13.000000000 -0600
+++ uClibc-0.9.29/libc/misc/internals/__uClibc_main.c   2007-09-15 
07:13:18.000000000 -0500
@@ -79,13 +79,17 @@
  * Prototypes.
  */
 extern void weak_function _stdio_init(void) attribute_hidden;
+static void __weakstub (void) { return; }
+weak_alias (__weakstub, _stdio_init)
 extern int *weak_const_function __errno_location(void);
 extern int *weak_const_function __h_errno_location(void);
 #ifdef __UCLIBC_HAS_LOCALE__
 extern void weak_function _locale_init(void) attribute_hidden;
+weak_alias (__weakstub, _locale_init)
 #endif
 #ifdef __UCLIBC_HAS_THREADS__
 extern void weak_function __pthread_initialize_minimal(void);
+weak_alias (__weakstub, __pthread_initialize_minimal)
 #endif
 
 /* If __UCLIBC_FORMAT_SHARED_FLAT__, all array initialisation and finalisation
@@ -198,8 +202,7 @@
      * __pthread_initialize_minimal so we can use pthread_locks
      * whenever they are needed.
      */
-    if (likely(__pthread_initialize_minimal!=NULL))
-       __pthread_initialize_minimal();
+    __pthread_initialize_minimal();
 #endif
 
 #ifndef SHARED
@@ -222,8 +225,7 @@
 
 #ifdef __UCLIBC_HAS_LOCALE__
     /* Initialize the global locale structure. */
-    if (likely(_locale_init!=NULL))
-       _locale_init();
+    _locale_init();
 #endif
 
     /*
@@ -232,8 +234,7 @@
      * Thus we get a nice size savings because the stdio functions
      * won't be pulled into the final static binary unless used.
      */
-    if (likely(_stdio_init != NULL))
-       _stdio_init();
+    _stdio_init();
 
 }
 libc_hidden_def(__uClibc_init)
diff -ru uClibc-0.9.29-old/libc/stdlib/_atexit.c 
uClibc-0.9.29/libc/stdlib/_atexit.c
--- uClibc-0.9.29-old/libc/stdlib/_atexit.c     2007-05-04 09:13:17.000000000 
-0500
+++ uClibc-0.9.29/libc/stdlib/_atexit.c 2007-09-15 07:14:47.000000000 -0500
@@ -306,6 +306,8 @@
 
 #ifdef L_exit
 extern void weak_function _stdio_term(void) attribute_hidden;
+static void __weakstub (void) { return; }
+weak_alias (__weakstub, _stdio_term)
 attribute_hidden void (*__exit_cleanup) (int) = 0;
 __UCLIBC_MUTEX_INIT(__atexit_lock, PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP);
 
@@ -330,8 +332,7 @@
         * this will attempt to commit all buffered writes.  It may also
         * unbuffer all writable files, or close them outright.
         * Check the stdio routines for details. */
-       if (_stdio_term)
-           _stdio_term();
+       _stdio_term();
 
        _exit(rv);
 }

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++



Remember to have fun...

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-commit+help@xxxxxxxxxxxx