Hello community, here is the log from the commit of package abcde checked in at Mon Nov 3 11:53:00 CET 2008. -------- --- abcde/abcde.changes 2007-11-27 14:13:26.000000000 +0100 +++ /mounts/work_src_done/STABLE/abcde/abcde.changes 2008-10-31 10:39:16.271643000 +0100 @@ -1,0 +2,6 @@ +Fri Oct 31 10:39:00 CET 2008 - coolo@suse.de + +- apply patch from bnc#419800 to fix + "abcde quotes some variables incorrectly" + +------------------------------------------------------------------- calling whatdependson for head-i586 New: ---- abcde_2.3.99.6-quote.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ abcde.spec ++++++ --- /var/tmp/diff_new_pack.EO7075/_old 2008-11-03 11:52:15.000000000 +0100 +++ /var/tmp/diff_new_pack.EO7075/_new 2008-11-03 11:52:15.000000000 +0100 @@ -1,24 +1,34 @@ # # spec file for package abcde (Version 2.3.99.6) # -# Copyright (c) 2007 SUSE LINUX Products GmbH, Nuernberg, Germany. -# This file and all modifications and additions to the pristine -# package are under the same license as the package itself. +# Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany. # +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + # Please submit bugfixes or comments via http://bugs.opensuse.org/ # # norootforbuild + Name: abcde License: GPL v2 or later Group: Productivity/Multimedia/Sound/Utilities Version: 2.3.99.6 -Release: 1 +Release: 58 Summary: A Better CD Encoder Url: http://www.hispalinux.es/~data/abcde.php Source0: http://www.hispalinux.es/~data/files/%{name}_%{version}.orig.tar.gz Source1: http://lly.org/~rcw/cd-discid/cd-discid_0.9.orig.tar.gz +# bug 419800 +Patch0: abcde_2.3.99.6-quote.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build Provides: cd-discid Requires: wget cdparanoia vorbis-tools @@ -38,6 +48,7 @@ %prep %setup -a 1 +%patch0 %build export CFLAGS="$RPM_OPT_FLAGS" @@ -65,7 +76,10 @@ %config(noreplace) /etc/abcde.conf %changelog -* Tue Nov 27 2007 - coolo@suse.de +* Fri Oct 31 2008 coolo@suse.de +- apply patch from bnc#419800 to fix + "abcde quotes some variables incorrectly" +* Tue Nov 27 2007 coolo@suse.de - update to 2.3.99.6: tons of debian bug reports fixed, e.g. * Default to UNICODE (UTF8) tags and comments (Closes: #282332). - Added CDDBPROTO option in config file (Closes: #349951) @@ -75,7 +89,7 @@ file, even if we are not tagging. This way we can use the file as a source even if it is not tagged/named properly. * Fails to quote filenames properly (Closes: #355296) -* Thu Sep 07 2006 - coolo@suse.de +* Thu Sep 07 2006 coolo@suse.de - update to 2.3.3: * Rips done in a single track were getting tagged as Various. Corrected. * Possibly eliminated some bashisms from using a variable as a variable @@ -135,26 +149,26 @@ * Quotes missing when evaluating a value (Closes: #284018). * Spotted and solved a problem with the way the data tracks were detected (Closes: #282647). -* Wed Jan 25 2006 - mls@suse.de +* Wed Jan 25 2006 mls@suse.de - converted neededforbuild to BuildRequires -* Wed Nov 02 2005 - coolo@suse.de +* Wed Nov 02 2005 coolo@suse.de - make CDROM != /dev/cdrom work -* Fri Jan 21 2005 - coolo@suse.de +* Fri Jan 21 2005 coolo@suse.de - update to 2.2.0 -* Thu Aug 05 2004 - coolo@suse.de +* Thu Aug 05 2004 coolo@suse.de - update to 2.1.19 -* Fri Oct 31 2003 - coolo@suse.de +* Fri Oct 31 2003 coolo@suse.de - build as user -* Mon Oct 13 2003 - coolo@suse.de +* Mon Oct 13 2003 coolo@suse.de - update to 2.1.6 -* Fri Aug 15 2003 - coolo@suse.de +* Fri Aug 15 2003 coolo@suse.de - sent patch yesterday, today new version -* Wed Aug 13 2003 - coolo@suse.de +* Wed Aug 13 2003 coolo@suse.de - update to 2.1.4 - apply diff to avoid -1 syntax to tail,head,nice -* Tue Apr 22 2003 - coolo@suse.de +* Tue Apr 22 2003 coolo@suse.de - update to 2.1.2 -* Thu Apr 10 2003 - coolo@suse.de +* Thu Apr 10 2003 coolo@suse.de - updated to 2.1.1 -* Sun Aug 04 2002 - coolo@suse.de +* Sun Aug 04 2002 coolo@suse.de - Initial package ++++++ abcde_2.3.99.6-quote.patch ++++++ --- abcde.orig 2008-08-22 15:56:42.000000000 -0700 +++ abcde 2008-08-22 16:03:26.000000000 -0700 @@ -767,7 +767,7 @@ # COMMENT, DALBUM, DARTIST, CDYEAR, CDGENRE (and temporarily) ID3TAGV do_tag () { - COMMENTOUTPUT="$(eval echo ${COMMENT})" + COMMENTOUTPUT="$(eval echo \""${COMMENT}"\")" CDDBDISCID=$(echo $TRACKINFO | cut -d' ' -f1) run_command '' echo "Tagging track $1 of $TRACKS: $TRACKNAME..." # If we want to start the tracks with a given number, we need to modify the @@ -831,7 +831,7 @@ fi echo TRACKNUMBER=${TRACKNUM:-$1} echo CDDB=$CDDBDISCID - if [ "$(eval echo ${COMMENT})" != "" ]; then + if [ "$(eval echo \""${COMMENT}"\")" != "" ]; then case "$COMMENTOUTPUT" in *=*) echo "$COMMENTOUTPUT";; *) echo COMMENT="$COMMENTOUTPUT";; @@ -861,7 +861,7 @@ fi echo TRACKNUMBER="${TRACKNUM:-$1}" echo CDDB="$CDDBDISCID" - if [ "$(eval echo ${COMMENT})" != "" ]; then + if [ "$(eval echo \""${COMMENT}"\")" != "" ]; then case "$COMMENTOUTPUT" in *=*) echo "$COMMENTOUTPUT";; *) echo COMMENT="$COMMENTOUTPUT";; @@ -964,7 +964,7 @@ TEMPARG="PIPE_$MPPENCODER" ;; esac - IN="$( eval echo "\$$TEMPARG" )" + IN="$( eval echo \""\$$TEMPARG"\" )" else IN="$ABCDETEMPDIR/track$1.wav" case "$OUTPUT" in @@ -1063,7 +1063,7 @@ esac ;; spx) - if [ "$(eval echo ${COMMENT})" != "" ]; then + if [ "$(eval echo \""${COMMENT}"\")" != "" ]; then case "$COMMENT" in *=*) ;; *) COMMENT="COMMENT=$COMMENT" ;; @@ -1427,9 +1427,9 @@ GENRE="$(mungegenre "$GENRE")" YEAR=${CDYEAR:-$CDYEAR} if [ "$VARIOUSARTISTS" = "y" ] ; then - PLAYLISTFILE="$(eval echo "$VAPLAYLISTFORMAT")" + PLAYLISTFILE="$(eval echo \""$VAPLAYLISTFORMAT"\")" else - PLAYLISTFILE="$(eval echo "$PLAYLISTFORMAT")" + PLAYLISTFILE="$(eval echo \""$PLAYLISTFORMAT"\")" fi FINALPLAYLISTDIR="$(dirname "$OUTPUTDIR/$PLAYLISTFILE")" mkdir -p "$FINALPLAYLISTDIR" @@ -1439,7 +1439,7 @@ while [ "$DONE" != "y" ]; do read ERASEPLAYLIST case $ERASEPLAYLIST in - e|E|a|A|k|K) DONE=y ;; + e|E|a|A|k|K|'') DONE=y ;; *) ;; esac done @@ -2673,7 +2673,7 @@ CDDBTRACKNUM=$(expr $UTRACKNUM - 1) if [ "$USEPIPES" = "y" ]; then TEMPARG="PIPERIPPER_$CDROMREADERSYNTAX" - FILEARG="$( eval echo "\$$TEMPARG" )" + FILEARG="$( eval echo \""\$$TEMPARG"\" )" REDIR="" PIPE_MESSAGE="and encoding " else @@ -3663,16 +3663,16 @@ PIPEENCODERSVARCHECK="PIPE_$MPPENCODER" ;; esac decho "PIPERIPPERSVARCHECK: $( eval echo "\$$PIPERIPPERSVARCHECK" )" - if [ "$( eval echo "\$$PIPERIPPERSVARCHECK" )" = "$" ] || \ - [ "$( eval echo "\$$PIPERIPPERSVARCHECK" )" = "" ] ; then + if [ "$( eval echo \""\$$PIPERIPPERSVARCHECK"\" )" = "$" ] || \ + [ "$( eval echo \""\$$PIPERIPPERSVARCHECK"\" )" = "" ] ; then log error "no support for pipes with given ripper" log error "read the USEPIPES file from the source tarball to get help." log error "On a Debian system, it is under /usr/share/doc/abcde/USEPIPES.gz" exit 1; fi decho "PIPEENCODERSVARCHECK: $( eval echo "\$$PIPEENCODERSVARCHECK" )" - if [ "$( eval echo "\$$PIPEENCODERSVARCHECK" )" = "$" ] || \ - [ "$( eval echo "\$$PIPEENCODERSVARCHECK" )" = "" ] ; then + if [ "$( eval echo \""\$$PIPEENCODERSVARCHECK"\" )" = "$" ] || \ + [ "$( eval echo \""\$$PIPEENCODERSVARCHECK"\" )" = "" ] ; then log error "no support for pipes with given encoder" log error "read the USEPIPES file from the source tarball to help" log error "on a Debian system, read /usr/share/doc/abcde/USEPIPES.gz" ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org