Hello community, here is the log from the commit of package kde4-amarok checked in at Tue Sep 9 19:25:40 CEST 2008. -------- --- KDE/kde4-amarok/kde4-amarok.changes 2008-08-20 23:36:35.000000000 +0200 +++ /mounts/work_src_done/STABLE/kde4-amarok/kde4-amarok.changes 2008-09-09 11:10:08.000000000 +0200 @@ -1,0 +2,5 @@ +Tue Sep 9 11:09:59 CEST 2008 - dmueller@suse.de + +- fix uninitialized return value warnings + +------------------------------------------------------------------- New: ---- fix-uninitialized.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kde4-amarok.spec ++++++ --- /var/tmp/diff_new_pack.mQ5484/_old 2008-09-09 19:25:33.000000000 +0200 +++ /var/tmp/diff_new_pack.mQ5484/_new 2008-09-09 19:25:33.000000000 +0200 @@ -36,9 +36,10 @@ Group: Productivity/Multimedia/Sound/Players Summary: Media Player for KDE Version: 1.90 -Release: 1 +Release: 2 Source0: amarok-%version.tar.bz2 Patch0: fix-plugin-install.diff +Patch1: fix-uninitialized.diff BuildRoot: %{_tmppath}/%{name}-%{version}-build %kde4_runtime_requires @@ -59,6 +60,7 @@ %prep %setup -q -n amarok-%version %patch0 +%patch1 %build %cmake_kde4 -d build @@ -116,6 +118,8 @@ %_kde_share_dir/servicetypes/amarok_* %changelog +* Tue Sep 09 2008 dmueller@suse.de +- fix uninitialized return value warnings * Wed Aug 20 2008 dmueller@suse.de - update to 1.90 (2.0 Beta1) * Tue Jul 22 2008 dmueller@suse.de ++++++ fix-uninitialized.diff ++++++ --- src/browsers/servicebrowser/mp3tunes/Mp3tunesLocker.cpp +++ src/browsers/servicebrowser/mp3tunes/Mp3tunesLocker.cpp @@ -348,9 +348,9 @@ Mp3tunesLocker::tracksWithFileKeys( QStringList filekeys ) const keys.chop(1); char* c_keys = convertToChar ( keys ); - mp3tunes_locker_track_list_t *tracks_list; - mp3tunes_locker_list_item_t *track_item; - mp3tunes_locker_track_t *track; + mp3tunes_locker_track_list_t *tracks_list = 0; + mp3tunes_locker_list_item_t *track_item = 0; + mp3tunes_locker_track_t *track = 0; QList<Mp3tunesLockerTrack> tracksQList; // to be returned mp3tunes_locker_tracks_with_file_key ( m_locker, c_keys, &tracks_list ); --- src/browsers/servicebrowser/mp3tunes/Mp3tunesServiceQueryMaker.cpp +++ src/browsers/servicebrowser/mp3tunes/Mp3tunesServiceQueryMaker.cpp @@ -150,6 +150,7 @@ QueryMaker * Mp3tunesServiceQueryMaker::setQueryType( QueryType type ) case QueryMaker::Year: case QueryMaker::Custom: case QueryMaker::None: + default: //TODO: Implement. return this; } --- src/scriptengine/AmarokEngineScript.cpp +++ src/scriptengine/AmarokEngineScript.cpp @@ -133,6 +133,7 @@ namespace AmarokScript case Phonon::StoppedState: return 2; //Stopped case Phonon::ErrorState: + default: return -1; }; } ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org