Mailinglist Archive: opensuse-commit (2125 mails)
| < Previous | Next > |
commit libbeagle
- From: root@xxxxxxxxxxxxxxx (h_root)
- Date: Wed, 09 Apr 2008 00:13:17 +0200
- Message-id: <20080408221317.95353678182@xxxxxxxxxxxxxxx>
Hello community,
here is the log from the commit of package libbeagle
checked in at Wed Apr 9 00:13:17 CEST 2008.
--------
--- GNOME/libbeagle/libbeagle.changes 2008-03-25 00:35:22.000000000 +0100
+++ libbeagle/libbeagle.changes 2008-04-08 17:57:26.094584000 +0200
@@ -1,0 +2,9 @@
+Tue Apr 8 18:01:23 CEST 2008 - jpr@xxxxxxx
+
+- Update to version 0.3.5.1
+* Correctly deal with passed strings in functions. The earlier
+behaviour was inconsistent
+and could lead to crashes or leaks.
+* Fix memory leaks and remove redundant code.
+
+-------------------------------------------------------------------
Old:
----
libbeagle-0.3.4.tar.bz2
New:
----
libbeagle-0.3.5.1.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libbeagle.spec ++++++
--- /var/tmp/diff_new_pack.R24847/_old 2008-04-09 00:11:18.000000000 +0200
+++ /var/tmp/diff_new_pack.R24847/_new 2008-04-09 00:11:18.000000000 +0200
@@ -1,5 +1,5 @@
#
-# spec file for package libbeagle (Version 0.3.4)
+# spec file for package libbeagle (Version 0.3.5.1)
#
# Copyright (c) 2008 SUSE LINUX Products GmbH, Nuernberg, Germany.
# This file and all modifications and additions to the pristine
@@ -21,7 +21,7 @@
License: X11/MIT
Group: Development/Libraries/GNOME
AutoReqProv: on
-Version: 0.3.4
+Version: 0.3.5.1
Release: 1
Summary: Beagle C Interface
Url: http://www.gnome.org/projects/beagle/
@@ -34,6 +34,7 @@
%package -n libbeagle1
+License: X11/MIT
Summary: Beagle C Interface
Group: Development/Libraries/GNOME
# Added for openSUSE 11.0
@@ -46,6 +47,7 @@
%package devel
+License: X11/MIT
Summary: Beagle C interface development files
Group: Development/Libraries/GNOME
Requires: libbeagle1 = %{version} libxml2-devel glib2-devel glibc-devel
@@ -58,6 +60,7 @@
%package python
+License: X11/MIT
Summary: Beagle C Interface
Group: Development/Libraries/GNOME
Requires: %{name} = %{version}
@@ -69,6 +72,7 @@
%package doc
+License: X11/MIT
Summary: Beagle C documentation
Group: Development/Libraries/GNOME
Requires: %{name} = %{version}
@@ -122,6 +126,12 @@
%{py_sitedir}/*
%changelog
+* Tue Apr 08 2008 jpr@xxxxxxx
+- Update to version 0.3.5.1
+ * Correctly deal with passed strings in functions. The earlier
+ behaviour was inconsistent
+ and could lead to crashes or leaks.
+ * Fix memory leaks and remove redundant code.
* Tue Mar 25 2008 jpr@xxxxxxx
- Update to version 0.3.4
* Timeout in libbeagle if connection to beagled takes more than
@@ -130,7 +140,7 @@
* Fix glib-critical warnings in libbeagle (and python bindings)
when snippets with empty fragments were sent by beagled.
* Handle EAGAIN properly
-* Mon Jan 21 2008 jpr@xxxxxxx
+* Tue Jan 22 2008 jpr@xxxxxxx
- Update to 0.3.0
* Add/update beagle API calls for snippets, locales, errors
* Remove deprecated beagle API calls
@@ -138,10 +148,10 @@
- libbeagle is now a separate tarball
- Drop libbeagle-only.patch since the tarball is separate
- Add gtk-doc to build requires
-* Fri Sep 21 2007 joeshaw@xxxxxxx
+* Sat Sep 22 2007 joeshaw@xxxxxxx
- Add a patch to fix a crash when building the beagle-index
package. (Part of bnc #326808, bugs.freedesktop.org #12512)
-* Tue Sep 18 2007 maw@xxxxxxx
+* Wed Sep 19 2007 maw@xxxxxxx
- Respin fix-desktop-files.diff and rename %%{_datadir}/system-search.png
to %%{_datadir}/beagle-system-search.png (#307290).
* Mon Sep 17 2007 joeshaw@xxxxxxx
@@ -169,7 +179,7 @@
- Build with just splitted gmime-sharp.
* Fri Aug 03 2007 jpr@xxxxxxx
- Fix build with new evolution-sharp versions
-* Mon Jul 16 2007 coolo@xxxxxxx
+* Tue Jul 17 2007 coolo@xxxxxxx
- disable epiphany extension to fix build
* Wed Jun 06 2007 sbrabec@xxxxxxx
- Removed invalid desktop Category "Application" (#254654).
@@ -182,7 +192,7 @@
* Fri Apr 06 2007 maw@xxxxxxx
- Add epiphany-max-version.patch, allowing the epiphany extension
to be built against epiphany 2.18.
-* Thu Mar 29 2007 joeshaw@xxxxxxx
+* Fri Mar 30 2007 joeshaw@xxxxxxx
- Add a patch to handle empty OpenOffice documents. (bnc #259031)
- Add unzip to BuildRequires
* Tue Mar 20 2007 joeshaw@xxxxxxx
@@ -209,7 +219,7 @@
- Install HTML docs into new libbeagle-doc package.
* Sun Mar 11 2007 stbinner@xxxxxxx
- fix build (/etc/xdg/autostart ownership)
-* Tue Feb 27 2007 dmueller@xxxxxxx
+* Wed Feb 28 2007 dmueller@xxxxxxx
- adjust buildrequires: libexif -> libexif-devel
* Thu Feb 22 2007 joeshaw@xxxxxxx
- Update to 0.2.16.2:
@@ -307,7 +317,7 @@
[#355239], #348139, and probably most seriously #355932. Also
fixes a handful of other small bugs.
- Reenable the Epiphany extension now that it works with 2.16
-* Fri Sep 15 2006 joeshaw@xxxxxxx
+* Sat Sep 16 2006 joeshaw@xxxxxxx
- Add a call to intltoolize in our %%configure section to fix the
build with newer intltools.
* Tue Sep 12 2006 jhargadon@xxxxxxx
@@ -330,7 +340,7 @@
- Add upstream patch to fix libbeagle socket path for NFS
* Mon Jul 10 2006 joeshaw@xxxxxxx
- Add back in one of the patches which is still relevant.
-* Thu Jul 06 2006 joeshaw@xxxxxxx
+* Fri Jul 07 2006 joeshaw@xxxxxxx
- Upgrade package to 0.2.7; remove all the patches that have
accumulated over time.
* Thu Jun 29 2006 aj@xxxxxxx
@@ -343,7 +353,7 @@
* Fri Jun 23 2006 joeshaw@xxxxxxx
- Add a patch to catch exceptions when calling the GetChanges()
methods on calendars and addressbooks. bnc #187792.
-* Thu Jun 22 2006 gekker@xxxxxxx
+* Fri Jun 23 2006 gekker@xxxxxxx
- Update translations for zh_CN (#179555)
* Mon Jun 19 2006 joeshaw@xxxxxxx
- Add a patch to work around a mono bug so that dangling symlinks
@@ -356,7 +366,7 @@
- Add a patch to use SafeProcess to start the index helper
process, which will automatically (and immediately) reap zombie
child processes. Fixes bnc #185069.
-* Tue Jun 13 2006 sreeves@xxxxxxx
+* Wed Jun 14 2006 sreeves@xxxxxxx
- Fix for 182999 - Change beagle settings name
* Mon Jun 12 2006 joeshaw@xxxxxxx
- Don't split up a calendar's description field if it's empty.
@@ -367,7 +377,7 @@
[#181355].
* Tue Jun 06 2006 gekker@xxxxxxx
- Install the firefox plugin in /usr/lib (#181675)
-* Fri Jun 02 2006 gekker@xxxxxxx
+* Sat Jun 03 2006 gekker@xxxxxxx
- UPdate translations for de
* Tue May 30 2006 gekker@xxxxxxx
- Update translations for de,es,fr,hu,it,ja,pt_BR,zh_CN,zh_TW
@@ -406,7 +416,7 @@
- Add a patch to not hardcode the beagle-settings window size.
(bnc #169133, bgo #331161)
- Update beagle-hu.patch to fix broken markup. (bnc #169122)
-* Mon Apr 24 2006 joeshaw@xxxxxxx
+* Tue Apr 25 2006 joeshaw@xxxxxxx
- Update the calendar patch to correctly display dates in the
future.
* Mon Apr 24 2006 joeshaw@xxxxxxx
@@ -453,7 +463,7 @@
[#163237])
* Fri Mar 31 2006 gekker@xxxxxxx
- Fix crashes in beagle search (#161421,bgo#336708)
-* Fri Mar 24 2006 joeshaw@xxxxxxx
+* Sat Mar 25 2006 joeshaw@xxxxxxx
- Fix alignment of widgets in the search bar. Fixes bnc #153001.
* Wed Mar 22 2006 joeshaw@xxxxxxx
- Add a patch which fixes CWD checks in various shell scripts.
@@ -531,12 +541,12 @@
- fix build with new gmime
* Tue Jan 17 2006 meissner@xxxxxxx
- added -fstack-protector
-* Fri Jan 13 2006 gekker@xxxxxxx
+* Sat Jan 14 2006 gekker@xxxxxxx
- Fixup nfb and Requires for new gtk-sharp2 packaging
* Mon Jan 09 2006 joeshaw@xxxxxxx
- Don't reference Tiles.dll since we're not building it. Fixes
the Holmes build
-* Wed Jan 04 2006 gekker@xxxxxxx
+* Thu Jan 05 2006 gekker@xxxxxxx
- Don't install beagle.xpi, just it's contents (#120329)
- Fix build in x86_64
* Wed Jan 04 2006 joeshaw@xxxxxxx
@@ -600,11 +610,11 @@
- Fix handling of copied files more (116240 part 2)
* Sat Sep 10 2005 aj@xxxxxxx
- We need to su to the beagleindex user, so give it a shell.
-* Fri Sep 09 2005 gekker@xxxxxxx
+* Sat Sep 10 2005 gekker@xxxxxxx
- Fix handling of copied files (116240)
- Fix creation of beagleindex user
- Fix owner of /var/cache/beagle (113424)
-* Thu Sep 08 2005 gekker@xxxxxxx
+* Fri Sep 09 2005 gekker@xxxxxxx
- Fix CPU hogging problem (115566)
- Handle stop words properly (302906)
- Escape backslashes properly in mail backend (314353)
@@ -634,7 +644,7 @@
- Now requires gtk-sharp2 and gecko-sharp-2.0
- Fix autostart (102606)
- Add galago-sharp to requires (105722)
-* Wed Aug 17 2005 gekker@xxxxxxx
+* Thu Aug 18 2005 gekker@xxxxxxx
- Use beagle-index rather than nobody (104645).
* Tue Aug 16 2005 ro@xxxxxxx
- remove banshee from nfb: not needed
@@ -668,7 +678,7 @@
- Prefix clash fixes.
- Removed unneeded static modules and .la files for modules.
- Build more modules.
-* Thu Jul 07 2005 gekker@xxxxxxx
+* Fri Jul 08 2005 gekker@xxxxxxx
- Fixed the rest of the warnings.
* Tue Jul 05 2005 clahey@xxxxxxx
- Added libbeagle.
@@ -683,7 +693,7 @@
- Update to version 0.0.10.
* Sat May 14 2005 aj@xxxxxxx
- Update to version 0.0.9.
-* Thu May 05 2005 gekker@xxxxxxx
+* Fri May 06 2005 gekker@xxxxxxx
- Remove gtk-sharp-gapi from Requires.
* Sat Mar 19 2005 gekker@xxxxxxx
- Add beagle-uri-xml.patch, change best.desktop exec
@@ -703,7 +713,7 @@
- Remove wsdl-crash.patch, no longer need to work around crash in mcs
* Mon Mar 07 2005 gekker@xxxxxxx
- Update to version 0.0.7.100
-* Mon Feb 28 2005 thoenig@xxxxxxx
+* Tue Mar 01 2005 thoenig@xxxxxxx
- removed dbus-1-devel from Requires (not needed)
* Mon Feb 28 2005 clahey@xxxxxxx
- New version 0.0.6.200.
@@ -715,5 +725,5 @@
- Add wsdl-crash.diff
* Fri Feb 18 2005 gekker@xxxxxxx
- Update to version 0.0.6.1 (supports dbus-1-0.23.1).
-* Fri Feb 04 2005 gekker@xxxxxxx
+* Sat Feb 05 2005 gekker@xxxxxxx
- Initial import of beagle version 0.0.5
++++++ libbeagle-0.3.4.tar.bz2 -> libbeagle-0.3.5.1.tar.bz2 ++++++
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-error-response.c
new/libbeagle-0.3.5.1/beagle/beagle-error-response.c
--- old/libbeagle-0.3.4/beagle/beagle-error-response.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-error-response.c 2008-04-05
01:41:33.000000000 +0200
@@ -51,6 +51,7 @@
BeagleErrorResponsePrivate *priv = BEAGLE_ERROR_RESPONSE_GET_PRIVATE
(obj);
g_free (priv->message);
+ g_free (priv->details);
if (G_OBJECT_CLASS (parent_class)->finalize)
G_OBJECT_CLASS (parent_class)->finalize (obj);
@@ -113,6 +114,9 @@
static void
beagle_error_response_init (BeagleErrorResponse *response)
{
+ BeagleErrorResponsePrivate *priv = BEAGLE_ERROR_RESPONSE_GET_PRIVATE
(response);
+ priv->message = NULL;
+ priv->details = NULL;
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-hits-added-response.c
new/libbeagle-0.3.5.1/beagle/beagle-hits-added-response.c
--- old/libbeagle-0.3.4/beagle/beagle-hits-added-response.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-hits-added-response.c 2008-04-05
01:41:33.000000000 +0200
@@ -223,7 +223,12 @@
static void
beagle_hits_added_response_init (BeagleHitsAddedResponse *response)
{
-}
+ BeagleHitsAddedResponsePrivate *priv =
BEAGLE_HITS_ADDED_RESPONSE_GET_PRIVATE (response);
+ priv->hit = NULL;
+ priv->prop = NULL;
+ priv->hits = NULL;
+ priv->num_matches = 0;
+}
/**
* beagle_hits_added_response_get_hits:
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore
old/libbeagle-0.3.4/beagle/beagle-hits-subtracted-response.c
new/libbeagle-0.3.5.1/beagle/beagle-hits-subtracted-response.c
--- old/libbeagle-0.3.4/beagle/beagle-hits-subtracted-response.c
2008-02-11 17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-hits-subtracted-response.c
2008-04-05 01:41:33.000000000 +0200
@@ -101,7 +101,9 @@
static void
beagle_hits_subtracted_response_init (BeagleHitsSubtractedResponse *response)
{
-}
+ BeagleHitsSubtractedResponsePrivate *priv =
BEAGLE_HITS_SUBTRACTED_RESPONSE_GET_PRIVATE (response);
+ priv->uris = NULL;
+}
/**
* beagle_hits_subtracted_response_get_uris:
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore
old/libbeagle-0.3.4/beagle/beagle-indexing-service-request.c
new/libbeagle-0.3.5.1/beagle/beagle-indexing-service-request.c
--- old/libbeagle-0.3.4/beagle/beagle-indexing-service-request.c
2008-02-11 17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-indexing-service-request.c
2008-04-05 01:41:33.000000000 +0200
@@ -123,6 +123,10 @@
static void
beagle_indexing_service_request_init (BeagleIndexingServiceRequest
*indexing_service_request)
{
+ BeagleIndexingServiceRequestPrivate *priv =
BEAGLE_INDEXING_SERVICE_REQUEST_GET_PRIVATE (indexing_service_request);
+ priv->source = NULL;
+ priv->to_add = NULL;
+ priv->to_remove = NULL;
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore
old/libbeagle-0.3.4/beagle/beagle-indexing-status-response.c
new/libbeagle-0.3.5.1/beagle/beagle-indexing-status-response.c
--- old/libbeagle-0.3.4/beagle/beagle-indexing-status-response.c
2008-02-11 17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-indexing-status-response.c
2008-04-05 01:41:33.000000000 +0200
@@ -92,7 +92,9 @@
static void
beagle_indexing_status_response_init (BeagleIndexingStatusResponse *response)
{
-}
+ BeagleIndexingStatusResponsePrivate *priv =
BEAGLE_INDEXING_STATUS_RESPONSE_GET_PRIVATE (response);
+ priv->is_indexing = FALSE;
+}
/**
* beagle_indexing_status_response_is_indexing
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query.c
new/libbeagle-0.3.5.1/beagle/beagle-query.c
--- old/libbeagle-0.3.4/beagle/beagle-query.c 2008-02-11 17:25:00.000000000
+0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query.c 2008-04-05 01:41:33.000000000
+0200
@@ -239,6 +239,10 @@
/* FIXME: This is a good default when on an airplane. */
priv->domain = BEAGLE_QUERY_DOMAIN_LOCAL | BEAGLE_QUERY_DOMAIN_SYSTEM;
+
+ priv->parts = NULL;
+ priv->stemmed_text = NULL;
+ priv->exact_text = NULL;
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part.c 2008-04-05
01:41:33.000000000 +0200
@@ -66,7 +66,8 @@
static void
beagle_query_part_init (BeagleQueryPart *part)
{
-
+ BeagleQueryPartPrivate *priv = BEAGLE_QUERY_PART_GET_PRIVATE (part);
+ priv->logic = 0;
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part-date.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part-date.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part-date.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part-date.c 2008-04-05
01:41:33.000000000 +0200
@@ -34,7 +34,6 @@
#include "beagle-query-part-date.h"
typedef struct {
- char *key;
BeagleTimestamp *start_date;
BeagleTimestamp *end_date;
} BeagleQueryPartDatePrivate;
@@ -97,7 +96,9 @@
static void
beagle_query_part_date_init (BeagleQueryPartDate *part)
{
-
+ BeagleQueryPartDatePrivate *priv = BEAGLE_QUERY_PART_DATE_GET_PRIVATE
(part);
+ priv->start_date = NULL;
+ priv->end_date = NULL;
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part-human.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part-human.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part-human.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part-human.c 2008-04-05
01:41:33.000000000 +0200
@@ -34,7 +34,7 @@
#include "beagle-query-part-human.h"
typedef struct {
- const char *string;
+ char *string;
} BeagleQueryPartHumanPrivate;
#define BEAGLE_QUERY_PART_HUMAN_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE
((o), BEAGLE_TYPE_QUERY_PART_HUMAN, BeagleQueryPartHumanPrivate))
@@ -63,6 +63,11 @@
static void
beagle_query_part_human_finalize (GObject *obj)
{
+ BeagleQueryPartHuman *part = BEAGLE_QUERY_PART_HUMAN (obj);
+ BeagleQueryPartHumanPrivate *priv = BEAGLE_QUERY_PART_HUMAN_GET_PRIVATE
(part);
+
+ g_free (priv->string);
+
if (G_OBJECT_CLASS (parent_class)->finalize)
G_OBJECT_CLASS (parent_class)->finalize (obj);
}
@@ -84,7 +89,8 @@
static void
beagle_query_part_human_init (BeagleQueryPartHuman *part)
{
-
+ BeagleQueryPartHumanPrivate *priv = BEAGLE_QUERY_PART_HUMAN_GET_PRIVATE
(part);
+ priv->string = NULL;
}
/**
@@ -119,5 +125,6 @@
g_return_if_fail (string != NULL);
priv = BEAGLE_QUERY_PART_HUMAN_GET_PRIVATE (part);
- priv->string = string;
+ g_free (priv->string);
+ priv->string = g_strdup (string);
}
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part-or.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part-or.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part-or.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part-or.c 2008-04-05
01:41:33.000000000 +0200
@@ -100,7 +100,8 @@
static void
beagle_query_part_or_init (BeagleQueryPartOr *part)
{
-
+ BeagleQueryPartOrPrivate *priv = BEAGLE_QUERY_PART_OR_GET_PRIVATE
(part);
+ priv->subparts = NULL;
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part-property.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part-property.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part-property.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part-property.c 2008-04-05
01:41:33.000000000 +0200
@@ -34,8 +34,8 @@
#include "beagle-query-part-property.h"
typedef struct {
- const char *key;
- const char *value;
+ char *key;
+ char *value;
BeaglePropertyType prop_type;
} BeagleQueryPartPropertyPrivate;
@@ -79,6 +79,12 @@
static void
beagle_query_part_property_finalize (GObject *obj)
{
+ BeagleQueryPartProperty *part = BEAGLE_QUERY_PART_PROPERTY (obj);
+ BeagleQueryPartPropertyPrivate *priv =
BEAGLE_QUERY_PART_PROPERTY_GET_PRIVATE (part);
+
+ g_free (priv->key);
+ g_free (priv->value); /* No-op if NULL */
+
if (G_OBJECT_CLASS (parent_class)->finalize)
G_OBJECT_CLASS (parent_class)->finalize (obj);
}
@@ -100,6 +106,10 @@
static void
beagle_query_part_property_init (BeagleQueryPartProperty *part)
{
+ BeagleQueryPartPropertyPrivate *priv =
BEAGLE_QUERY_PART_PROPERTY_GET_PRIVATE (part);
+ priv->key = NULL;
+ priv->value = NULL;
+ priv->prop_type = BEAGLE_PROPERTY_TYPE_UNKNOWN;
}
/**
@@ -131,9 +141,11 @@
BeagleQueryPartPropertyPrivate *priv;
g_return_if_fail (BEAGLE_IS_QUERY_PART_PROPERTY (part));
+ g_return_if_fail (key != NULL);
priv = BEAGLE_QUERY_PART_PROPERTY_GET_PRIVATE (part);
- priv->key = key;
+ g_free (priv->key);
+ priv->key = g_strdup (key);
}
/**
@@ -153,7 +165,8 @@
g_return_if_fail (BEAGLE_IS_QUERY_PART_PROPERTY (part));
priv = BEAGLE_QUERY_PART_PROPERTY_GET_PRIVATE (part);
- priv->value = value;
+ g_free (priv->value);
+ priv->value = g_strdup (value);
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part-text.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part-text.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part-text.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part-text.c 2008-04-05
01:41:33.000000000 +0200
@@ -34,7 +34,7 @@
#include "beagle-query-part-text.h"
typedef struct {
- const char *text;
+ char *text;
gboolean search_full_text : 1;
gboolean search_properties : 1;
} BeagleQueryPartTextPrivate;
@@ -75,6 +75,11 @@
static void
beagle_query_part_text_finalize (GObject *obj)
{
+ BeagleQueryPartText *part = BEAGLE_QUERY_PART_TEXT (obj);
+ BeagleQueryPartTextPrivate *priv = BEAGLE_QUERY_PART_TEXT_GET_PRIVATE
(part);
+
+ g_free (priv->text);
+
if (G_OBJECT_CLASS (parent_class)->finalize)
G_OBJECT_CLASS (parent_class)->finalize (obj);
}
@@ -96,7 +101,10 @@
static void
beagle_query_part_text_init (BeagleQueryPartText *part)
{
-
+ BeagleQueryPartTextPrivate *priv = BEAGLE_QUERY_PART_TEXT_GET_PRIVATE
(part);
+ priv->text = NULL;
+ priv->search_full_text = FALSE;
+ priv->search_properties = FALSE;
}
/**
@@ -133,7 +141,8 @@
g_return_if_fail (text != NULL);
priv = BEAGLE_QUERY_PART_TEXT_GET_PRIVATE (part);
- priv->text = text;
+ g_free (priv->text);
+ priv->text = g_strdup (text);
}
/**
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part-uri.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part-uri.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part-uri.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part-uri.c 2008-04-05
01:41:33.000000000 +0200
@@ -34,7 +34,7 @@
#include "beagle-query-part-uri.h"
typedef struct {
- const char *uri;
+ char *uri;
} BeagleQueryPartUriPrivate;
#define BEAGLE_QUERY_PART_URI_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE
((o), BEAGLE_TYPE_QUERY_PART_URI, BeagleQueryPartUriPrivate))
@@ -63,6 +63,11 @@
static void
beagle_query_part_uri_finalize (GObject *obj)
{
+ BeagleQueryPartUri *part = BEAGLE_QUERY_PART_URI (obj);
+ BeagleQueryPartUriPrivate *priv = BEAGLE_QUERY_PART_URI_GET_PRIVATE
(part);
+
+ g_free (priv->uri);
+
if (G_OBJECT_CLASS (parent_class)->finalize)
G_OBJECT_CLASS (parent_class)->finalize (obj);
}
@@ -84,7 +89,8 @@
static void
beagle_query_part_uri_init (BeagleQueryPartUri *part)
{
-
+ BeagleQueryPartUriPrivate *priv = BEAGLE_QUERY_PART_URI_GET_PRIVATE
(part);
+ priv->uri = NULL;
}
/**
@@ -121,5 +127,6 @@
g_return_if_fail (uri != NULL);
priv = BEAGLE_QUERY_PART_URI_GET_PRIVATE (part);
- priv->uri = uri;
+ g_free (priv->uri);
+ priv->uri = g_strdup (uri);
}
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-query-part-wildcard.c
new/libbeagle-0.3.5.1/beagle/beagle-query-part-wildcard.c
--- old/libbeagle-0.3.4/beagle/beagle-query-part-wildcard.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-query-part-wildcard.c 2008-04-05
01:41:33.000000000 +0200
@@ -34,7 +34,7 @@
#include "beagle-query-part-wildcard.h"
typedef struct {
- const char *query_string;
+ char *query_string;
} BeagleQueryPartWildcardPrivate;
#define BEAGLE_QUERY_PART_WILDCARD_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE
((o), BEAGLE_TYPE_QUERY_PART_WILDCARD, BeagleQueryPartWildcardPrivate))
@@ -63,6 +63,11 @@
static void
beagle_query_part_wildcard_finalize (GObject *obj)
{
+ BeagleQueryPartWildcard *part = BEAGLE_QUERY_PART_WILDCARD (obj);
+ BeagleQueryPartWildcardPrivate *priv =
BEAGLE_QUERY_PART_WILDCARD_GET_PRIVATE (part);
+
+ g_free (priv->query_string);
+
if (G_OBJECT_CLASS (parent_class)->finalize)
G_OBJECT_CLASS (parent_class)->finalize (obj);
}
@@ -84,6 +89,8 @@
static void
beagle_query_part_wildcard_init (BeagleQueryPartWildcard *part)
{
+ BeagleQueryPartWildcardPrivate *priv =
BEAGLE_QUERY_PART_WILDCARD_GET_PRIVATE (part);
+ priv->query_string = NULL;
}
/**
@@ -126,5 +133,6 @@
g_return_if_fail (query_string != NULL);
priv = BEAGLE_QUERY_PART_WILDCARD_GET_PRIVATE (part);
- priv->query_string = query_string;
+ g_free (priv->query_string);
+ priv->query_string = g_strdup (query_string);
}
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-shutdown-request.c
new/libbeagle-0.3.5.1/beagle/beagle-shutdown-request.c
--- old/libbeagle-0.3.4/beagle/beagle-shutdown-request.c 2008-02-11
17:25:00.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-shutdown-request.c 2008-04-05
01:41:33.000000000 +0200
@@ -34,12 +34,6 @@
#include "beagle-shutdown-request.h"
#include "beagle-empty-response.h"
-typedef struct {
- gint foo;
-} BeagleShutdownRequestPrivate;
-
-#define BEAGLE_SHUTDOWN_REQUEST_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE
((o), BEAGLE_TYPE_SHUTDOWN_REQUEST, BeagleShutdownRequestPrivate))
-
static GObjectClass *parent_class = NULL;
static GString *
@@ -73,8 +67,6 @@
obj_class->finalize = beagle_shutdown_request_finalize;
request_class->to_xml = beagle_shutdown_request_to_xml;
- g_type_class_add_private (klass, sizeof (BeagleShutdownRequestPrivate));
-
_beagle_request_class_set_response_types (request_class,
"EmptyResponse",
BEAGLE_TYPE_EMPTY_RESPONSE,
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-snippet-request.c
new/libbeagle-0.3.5.1/beagle/beagle-snippet-request.c
--- old/libbeagle-0.3.4/beagle/beagle-snippet-request.c 2008-03-22
01:47:01.000000000 +0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-snippet-request.c 2008-04-05
01:41:33.000000000 +0200
@@ -127,6 +127,8 @@
g_return_if_fail (BEAGLE_IS_SNIPPET_REQUEST (snippet_request));
priv = BEAGLE_SNIPPET_REQUEST_GET_PRIVATE (snippet_request);
+ priv->query = NULL;
+ priv->hit = NULL;
priv->set_full_text = FALSE;
priv->ctx_length = -1;
priv->snp_length = -1;
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/beagle/beagle-util.c
new/libbeagle-0.3.5.1/beagle/beagle-util.c
--- old/libbeagle-0.3.4/beagle/beagle-util.c 2008-03-11 22:08:50.000000000
+0100
+++ new/libbeagle-0.3.5.1/beagle/beagle-util.c 2008-04-05 01:41:33.000000000
+0200
@@ -73,14 +73,14 @@
return beagle_home;
}
-const char *
+char *
beagle_util_get_storage_dir ()
{
const char *beagle_home;
- const char *beagle_storage_dir;
+ char *beagle_storage_dir;
/* Follow the C# API: First try BEAGLE_STORAGE */
- beagle_storage_dir = g_getenv ("BEAGLE_STORAGE");
+ beagle_storage_dir = g_strdup (g_getenv ("BEAGLE_STORAGE"));
/* Then try BEAGLE_HOME/.beagle */
if (beagle_storage_dir == NULL) {
@@ -96,7 +96,7 @@
char *
beagle_util_get_socket_path (const char *client_name)
{
- const gchar *beagle_storage_dir;
+ gchar *beagle_storage_dir;
gchar *socket_dir; /* this is same as remote_storage_dir in
PathFinder.cs */
gchar *socket_path;
struct stat buf;
@@ -112,11 +112,13 @@
gchar *tmp;
if (! g_file_test (remote_storage_dir_location_file,
G_FILE_TEST_EXISTS)) {
+ g_free (beagle_storage_dir);
g_free (remote_storage_dir_location_file);
return NULL;
}
if (! g_file_get_contents (remote_storage_dir_location_file,
&socket_dir, NULL, NULL)) {
+ g_free (beagle_storage_dir);
g_free (remote_storage_dir_location_file);
return NULL;
}
@@ -137,6 +139,7 @@
}
socket_path = g_build_filename (socket_dir, client_name, NULL);
+ g_free (beagle_storage_dir);
g_free (socket_dir);
if (stat (socket_path, &buf) == -1 || !S_ISSOCK (buf.st_mode)) {
g_free (socket_path);
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/ChangeLog
new/libbeagle-0.3.5.1/ChangeLog
--- old/libbeagle-0.3.4/ChangeLog 2008-03-23 22:34:31.000000000 +0100
+++ new/libbeagle-0.3.5.1/ChangeLog 2008-04-05 01:41:34.000000000 +0200
@@ -1,4 +1,131 @@
------------------------------------------------------------------------
+r4668 | arunsr | 2008-04-07 14:17:53 +0000 (Mon, 07 Apr 2008) | 2 lines
+Changed paths:
+ M /trunk/libbeagle/configure.in
+
+Increment API revision so we can unleash the latest changes on an unsuspecting
world
+
+------------------------------------------------------------------------
+r4667 | arunsr | 2008-04-07 08:38:08 +0000 (Mon, 07 Apr 2008) | 5 lines
+Changed paths:
+ M /trunk/libbeagle/beagle/beagle-error-response.c
+ M /trunk/libbeagle/beagle/beagle-hits-added-response.c
+ M /trunk/libbeagle/beagle/beagle-hits-subtracted-response.c
+ M /trunk/libbeagle/beagle/beagle-indexing-service-request.c
+ M /trunk/libbeagle/beagle/beagle-indexing-status-response.c
+ M /trunk/libbeagle/beagle/beagle-query-part-date.c
+ M /trunk/libbeagle/beagle/beagle-query-part-human.c
+ M /trunk/libbeagle/beagle/beagle-query-part-or.c
+ M /trunk/libbeagle/beagle/beagle-query-part-property.c
+ M /trunk/libbeagle/beagle/beagle-query-part-text.c
+ M /trunk/libbeagle/beagle/beagle-query-part-uri.c
+ M /trunk/libbeagle/beagle/beagle-query-part-wildcard.c
+ M /trunk/libbeagle/beagle/beagle-query-part.c
+ M /trunk/libbeagle/beagle/beagle-query.c
+ M /trunk/libbeagle/beagle/beagle-snippet-request.c
+
+Manually initialise all our private data
+
+While glib currently does this for us, it is not something that is documented
+(and thus, cannot be relied on).
+
+------------------------------------------------------------------------
+r4666 | arunsr | 2008-04-07 08:16:57 +0000 (Mon, 07 Apr 2008) | 2 lines
+Changed paths:
+ M /trunk/libbeagle/beagle/beagle-query-part-date.c
+ M /trunk/libbeagle/beagle/beagle-shutdown-request.c
+
+Removing some unused structures / structure members
+
+------------------------------------------------------------------------
+r4665 | arunsr | 2008-04-07 08:10:34 +0000 (Mon, 07 Apr 2008) | 8 lines
+Changed paths:
+ M /trunk/libbeagle/beagle/beagle-error-response.c
+ M /trunk/libbeagle/beagle/beagle-util.c
+
+Plug a couple memory leaks
+
+ * beagle_util_get_storage_dir() had two paths, one of which allocated a
+ string, and one did not. We never free'd the string if it was allocated.
+
+ * We were also allocating a string for each BeagleErrorResponse and not
+ freeing it.
+
+------------------------------------------------------------------------
+r4661 | arunsr | 2008-04-06 18:18:04 +0000 (Sun, 06 Apr 2008) | 4 lines
+Changed paths:
+ M /trunk/libbeagle/beagle/beagle-query-part-human.c
+ M /trunk/libbeagle/beagle/beagle-query-part-property.c
+ M /trunk/libbeagle/beagle/beagle-query-part-text.c
+ M /trunk/libbeagle/beagle/beagle-query-part-uri.c
+ M /trunk/libbeagle/beagle/beagle-query-part-wildcard.c
+
+Undo change r4659
+
+We don't need to use the "constructed" hook. There's already an init()
function.
+
+------------------------------------------------------------------------
+r4659 | arunsr | 2008-04-05 21:21:17 +0000 (Sat, 05 Apr 2008) | 6 lines
+Changed paths:
+ M /trunk/libbeagle/beagle/beagle-query-part-human.c
+ M /trunk/libbeagle/beagle/beagle-query-part-property.c
+ M /trunk/libbeagle/beagle/beagle-query-part-text.c
+ M /trunk/libbeagle/beagle/beagle-query-part-uri.c
+ M /trunk/libbeagle/beagle/beagle-query-part-wildcard.c
+
+Initialise private fields for various QueryPart classes to NULL
+
+While this is strictly not necessary (glib automatically zeroes out the memory
+for private data), it's probably better that we do this in case glib behaviour
+changes at some point.
+
+------------------------------------------------------------------------
+r4657 | arunsr | 2008-04-05 08:22:47 +0000 (Sat, 05 Apr 2008) | 8 lines
+Changed paths:
+ M /trunk/libbeagle/beagle/beagle-query-part-human.c
+ M /trunk/libbeagle/beagle/beagle-query-part-property.c
+ M /trunk/libbeagle/beagle/beagle-query-part-text.c
+ M /trunk/libbeagle/beagle/beagle-query-part-uri.c
+ M /trunk/libbeagle/beagle/beagle-query-part-wildcard.c
+
+Cleanups to previous commit
+
+ * Do a g_free() before g_strdup() so we don't leak memory on multiple calls
+ to the *_set_*() functions
+
+ * Don't warn on finding a NULL private field in finalize() -- if the object is
+ never used before being freed, the field will be NULL.
+
+------------------------------------------------------------------------
+r4655 | arunsr | 2008-04-04 18:34:28 +0000 (Fri, 04 Apr 2008) | 12 lines
+Changed paths:
+ M /trunk/libbeagle/beagle/beagle-query-part-human.c
+ M /trunk/libbeagle/beagle/beagle-query-part-property.c
+ M /trunk/libbeagle/beagle/beagle-query-part-text.c
+ M /trunk/libbeagle/beagle/beagle-query-part-uri.c
+ M /trunk/libbeagle/beagle/beagle-query-part-wildcard.c
+
+Make beagle_quert_part_foo_set_bar() function allocate/free their own strings
+
+Several of the beagle_query_part_foo_set_bar() functions used to take a string
+alloc'ed by clients and assume that these would not be free'd by the client.
+This is counter-intuitive and not the GObject way.
+
+What we now do is g_strdup() all strings that are passed as arguments and then
+free the dup'ed strings in the class' finalize() method. Clients must now
+manage the strings they pass to these functions themselves.
+
+We will need to bump the ABI version after some more testing.
+
+------------------------------------------------------------------------
+r4636 | dbera | 2008-03-23 21:35:50 +0000 (Sun, 23 Mar 2008) | 2 lines
+Changed paths:
+ M /trunk/libbeagle/ChangeLog
+ M /trunk/libbeagle/NEWS
+
+Upload changelog and news for libbeagle.
+
+------------------------------------------------------------------------
r4635 | dbera | 2008-03-23 17:12:08 -0400 (Sun, 23 Mar 2008) | 3 lines
Changed paths:
M /trunk/libbeagle/configure.in
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/configure
new/libbeagle-0.3.5.1/configure
--- old/libbeagle-0.3.4/configure 2008-03-22 04:30:08.000000000 +0100
+++ new/libbeagle-0.3.5.1/configure 2008-04-05 01:46:20.000000000 +0200
@@ -2434,7 +2434,7 @@
# Define the identity of the package.
PACKAGE=libbeagle
- VERSION=0.3.4
+ VERSION=0.3.5.1
cat >>confdefs.h <<_ACEOF
@@ -20408,7 +20408,7 @@
LIBBEAGLE_CURRENT=1
-LIBBEAGLE_REVISION=1
+LIBBEAGLE_REVISION=2
LIBBEAGLE_AGE=0
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/configure.in
new/libbeagle-0.3.5.1/configure.in
--- old/libbeagle-0.3.4/configure.in 2008-03-22 04:29:52.000000000 +0100
+++ new/libbeagle-0.3.5.1/configure.in 2008-04-05 01:46:08.000000000 +0200
@@ -4,7 +4,7 @@
AC_INIT(beagle/beagle.h)
AC_CANONICAL_SYSTEM
-AM_INIT_AUTOMAKE(libbeagle, 0.3.4)
+AM_INIT_AUTOMAKE(libbeagle, 0.3.5.1)
########################################################################
@@ -42,9 +42,9 @@
dnl Update when changing implementation of current API,
dnl reset to 0 when changing CURRENT. This is the revision of
dnl current API version
-LIBBEAGLE_REVISION=1
+LIBBEAGLE_REVISION=2
-dnl Increase of API change is ABI compatible, otherwise reset to 0
+dnl Increase if API change is ABI compatible, otherwise reset to 0
LIBBEAGLE_AGE=0
LIBBEAGLE_VERSION_INFO="$LIBBEAGLE_CURRENT:$LIBBEAGLE_REVISION:$LIBBEAGLE_AGE"
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/libbeagle-1.0.pc
new/libbeagle-0.3.5.1/libbeagle-1.0.pc
--- old/libbeagle-0.3.4/libbeagle-1.0.pc 2008-03-23 22:57:53.000000000
+0100
+++ new/libbeagle-0.3.5.1/libbeagle-1.0.pc 2008-04-05 01:46:30.000000000
+0200
@@ -5,7 +5,7 @@
Name: libbeagle
Description: C API for Beagle
-Version: 0.3.4
+Version: 0.3.5.1
Requires: libxml-2.0 gobject-2.0
Libs: -L${libdir} -lbeagle
Cflags: -I${includedir}/libbeagle
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn
--exclude=.svnignore old/libbeagle-0.3.4/NEWS new/libbeagle-0.3.5.1/NEWS
--- old/libbeagle-0.3.4/NEWS 2008-03-23 22:34:55.000000000 +0100
+++ new/libbeagle-0.3.5.1/NEWS 2008-04-05 01:41:34.000000000 +0200
@@ -1,6 +1,25 @@
+Version 0.3.5
+7 April 2008
+
+* Correctly deal with passed strings in functions. The earlier behaviour was
inconsistent
+and could lead to crashes or leaks.
+
+* Fix memory leaks and remove redundant code.
+
+Contributors to this release: Arun Raghavan
+
+Full set of changes:
+http://svn.gnome.org/viewvc/beagle/tags/BEAGLE_0_3_5/libbeagle/ChangeLog?view=markup
+
+-------------------------------------------
+
Version 0.3.4
23 March 2008
+See the Beagle NEWS file for more details
+
+-------------------------------------------
+
Version 0.3.0
1 December 2007
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Remember to have fun...
---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-commit+help@xxxxxxxxxxxx
| < Previous | Next > |