Mailinglist Archive: opensuse-commit (2092 mails)

[root@xxxxxxxxxxxxxxx (h_root)]

Hello community,

here is the log from the commit of package yast2
checked in at Tue Aug 28 19:26:55 CEST 2007.

--------
--- yast2/yast2.changes 2007-08-27 10:07:28.000000000 +0200
+++ /mounts/work_src_done/STABLE/yast2/yast2.changes    2007-08-28 15:56:12.000000000 +0200
@@ -1,0 +2,16 @@
+Tue Aug 28 15:54:17 CEST 2007 - mzugec@xxxxxxx
+
+- add filter and log for output of NetworkDevices::List() (#303858) 
+
+-------------------------------------------------------------------
+Tue Aug 28 12:12:49 CEST 2007 - locilka@xxxxxxx
+
+- Fixed SuSEFirewall to better handle erroneous data from
+  NetworkDevices module (#303858).
+
+-------------------------------------------------------------------
+Mon Aug 27 11:59:50 CEST 2007 - sh@xxxxxxx
+
+- Fixed bug #304776: save_y2logs usage message
+
+-------------------------------------------------------------------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2.spec ++++++
--- /var/tmp/diff_new_pack.dj8215/_old  2007-08-28 19:26:39.000000000 +0200
+++ /var/tmp/diff_new_pack.dj8215/_new  2007-08-28 19:26:39.000000000 +0200
@@ -12,7 +12,7 @@
 
 Name:           yast2
 Version:        2.15.48
-Release:        1
+Release:        3
 License:        GPL v2 or later
 Group:          System/YaST
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
@@ -214,6 +214,13 @@
 %doc %{prefix}/share/doc/packages/yast2/wizard
 
 %changelog
+* Tue Aug 28 2007 - mzugec@xxxxxxx
+- add filter and log for output of NetworkDevices::List() (#303858)
+* Tue Aug 28 2007 - locilka@xxxxxxx
+- Fixed SuSEFirewall to better handle erroneous data from
+  NetworkDevices module (#303858).
+* Mon Aug 27 2007 - sh@xxxxxxx
+- Fixed bug #304776: save_y2logs usage message
 * Fri Aug 24 2007 - mzugec@xxxxxxx
 - add "ath" into "netcard" macro in NetworkDevices (#288450)
 - 2.15.48

++++++ yast2-2.15.48.tar.bz2 ++++++
++++ 3547 lines of diff (skipped)
++++    retrying with extended exclude list
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-2.15.48/library/network/src/NetworkDevices.ycp new/yast2-2.15.48/library/network/src/NetworkDevices.ycp
--- old/yast2-2.15.48/library/network/src/NetworkDevices.ycp    2007-08-27 09:48:21.000000000 +0200
+++ new/yast2-2.15.48/library/network/src/NetworkDevices.ycp    2007-08-28 15:55:54.000000000 +0200
@@ -4,7 +4,7 @@
  * Summary:    Interface manipulation (/etc/sysconfig/network/ifcfg-*)
  * Authors:    Michal Svec <msvec@xxxxxxx>
  *
- * $Id: NetworkDevices.ycp 40449 2007-08-24 11:29:29Z mzugec $
+ * $Id: NetworkDevices.ycp 40542 2007-08-28 13:55:07Z mzugec $
  *
  * The new sysconfig naming is interface (eg. eth0) vs. device
  * (eg. NE2000 card), but historically yast has called them device
@@ -484,7 +484,6 @@
        return !regexpmatch(file, "[~]");
     });
     y2debug("devices=%1", devices);
-
     /* FIXME: devname
     devices = filter(string d, devices, {
        return regexpmatch(d, "[a-z][a-z-]*[0-9]*");
@@ -1285,8 +1284,12 @@
        maplist(string n, Map::Keys(d), {ret[size(ret)] = device_name(type,n);});
        */
     }
-
-    y2debug("ret=%1", ret);
+    ret = filter(string row, ret, {
+               if (row!=nil) return true;
+               y2error("Filtering out : %1", row);
+               return false;
+       });
+    y2milestone("List( %1 ) = %2", devregex, ret);
     return ret;
 }
 
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-2.15.48/library/network/src/SuSEFirewall.ycp new/yast2-2.15.48/library/network/src/SuSEFirewall.ycp
--- old/yast2-2.15.48/library/network/src/SuSEFirewall.ycp      2007-05-18 10:05:52.000000000 +0200
+++ new/yast2-2.15.48/library/network/src/SuSEFirewall.ycp      2007-08-28 15:26:51.000000000 +0200
@@ -1472,15 +1472,37 @@
        
        // All dial-up interfaces
        list <string> dialup_interfaces = NetworkDevices::List("dialup");
-       dialup_interfaces = filter(string interface, dialup_interfaces, ``{
-           return interface != "" && !issubstring(interface, "lo") && !issubstring(interface, "sit");
+       if (dialup_interfaces == nil) dialup_interfaces = [];
+
+       // bugzilla #303858 - wrong values from NetworkDevices
+       dialup_interfaces = filter (string one_iface, dialup_interfaces, {
+           if (one_iface == nil || one_iface == "") {
+               y2error ("Wrong interface definition '%1'", one_iface);
+               return false;
+           }
+           return true;
+       });
+
+       dialup_interfaces = filter (string interface, dialup_interfaces, ``{
+           return interface != "" && !issubstring (interface, "lo") && !issubstring (interface, "sit");
        });
 
        // All non-dial-up interfaces
        list <string> non_dialup_interfaces = NetworkDevices::List("");
-       non_dialup_interfaces = filter(string interface, non_dialup_interfaces, ``{
-           return interface != "" && !issubstring(interface, "lo") && !issubstring(interface, "sit")
-               && !contains(dialup_interfaces, interface);
+       if (non_dialup_interfaces == nil) non_dialup_interfaces = [];
+
+       // bugzilla #303858 - wrong values from NetworkDevices
+       non_dialup_interfaces = filter (string one_iface, non_dialup_interfaces, {
+           if (one_iface == nil || one_iface == "") {
+               y2error ("Wrong interface definition '%1'", one_iface);
+               return false;
+           }
+           return true;
+       });
+
+       non_dialup_interfaces = filter (string interface, non_dialup_interfaces, ``{
+           return interface != "" && !issubstring (interface, "lo") && !issubstring (interface, "sit")
+               && !contains (dialup_interfaces, interface);
        });
 
        foreach (string interface, dialup_interfaces, {
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/yast2-2.15.48/scripts/save_y2logs new/yast2-2.15.48/scripts/save_y2logs
--- old/yast2-2.15.48/scripts/save_y2logs       2007-06-04 12:21:18.000000000 +0200
+++ new/yast2-2.15.48/scripts/save_y2logs       2007-08-28 15:26:51.000000000 +0200
@@ -4,11 +4,11 @@
 #              to attach it to a Bugzilla bug report
 #
 # Author: Stefan Hundhammer <sh@xxxxxxx>
-# $Id: save_y2logs 38201 2007-05-30 11:49:50Z sh-sh-sh $
+# $Id: save_y2logs 40493 2007-08-27 10:02:44Z sh-sh-sh $
 
 usage()
 {
-    echo "Usage: $0 <tgz-file-name>"
+    echo "Usage: $0 <tgz-file-name>|<bzip2-file-name>"
     echo ""
     echo "Copies the YaST2 logs to a compressed tar archive."
     exit 1



++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++



Remember to have fun...

---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-commit+help@xxxxxxxxxxxx