commit perl-Params-Validate

Hello community, here is the log from the commit of package perl-Params-Validate checked in at Fri Mar 9 01:50:54 CET 2007. -------- --- perl-Params-Validate/perl-Params-Validate.changes 2007-01-25 20:47:15.000000000 +0100 +++ /mounts/work_src_done/STABLE/perl-Params-Validate/perl-Params-Validate.changes 2007-03-08 14:30:59.000000000 +0100 @@ -1,0 +2,8 @@ +Thu Mar 8 14:28:02 CET 2007 - anicka@suse.cz + +- update to 0.88 + * The XS version threw an error when it attempted to do "isa" or + "can" validation on a value that was not a string or object, + such as undef or a number. + +------------------------------------------------------------------- Old: ---- Params-Validate-0.87.tar.bz2 New: ---- Params-Validate-0.88.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Params-Validate.spec ++++++ --- /var/tmp/diff_new_pack.Or2010/_old 2007-03-09 01:50:47.000000000 +0100 +++ /var/tmp/diff_new_pack.Or2010/_new 2007-03-09 01:50:47.000000000 +0100 @@ -1,5 +1,5 @@ # -# spec file for package perl-Params-Validate (Version 0.87) +# spec file for package perl-Params-Validate (Version 0.88) # # Copyright (c) 2007 SUSE LINUX Products GmbH, Nuernberg, Germany. # This file and all modifications and additions to the pristine @@ -17,7 +17,7 @@ Requires: perl = %{perl_version} #Conflicts: perlmod Autoreqprov: on -Version: 0.87 +Version: 0.88 Release: 1 Source: Params-Validate-%{version}.tar.bz2 Summary: provides a system for validation method/function call parameters @@ -65,7 +65,12 @@ %{perl_vendorarch}/auto/Params %{_mandir}/man3/*.3pm.gz -%changelog -n perl-Params-Validate +%changelog +* Thu Mar 08 2007 - anicka@suse.cz +- update to 0.88 + * The XS version threw an error when it attempted to do "isa" or + "can" validation on a value that was not a string or object, + such as undef or a number. * Thu Jan 25 2007 - anicka@suse.cz - update to 0.87 * When determining the caller of a function in the XS version, use ++++++ Params-Validate-0.87.tar.bz2 -> Params-Validate-0.88.tar.bz2 ++++++ diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Params-Validate-0.87/Changes new/Params-Validate-0.88/Changes --- old/Params-Validate-0.87/Changes 2007-01-18 16:48:18.000000000 +0100 +++ new/Params-Validate-0.88/Changes 2007-03-07 15:53:04.000000000 +0100 @@ -1,3 +1,10 @@ +0.88 March 7, 2007 + +- The XS version threw an error when it attempted to do "isa" or "can" + validation on a value that was not a string or object, such as undef + or a number. Reported by Steffen Winkler. RT #25229. + + 0.87 January 18, 2007 - When determining the caller of a function in the XS version, use diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Params-Validate-0.87/lib/Params/Validate.pm new/Params-Validate-0.88/lib/Params/Validate.pm --- old/Params-Validate-0.87/lib/Params/Validate.pm 2007-01-18 02:27:04.000000000 +0100 +++ new/Params-Validate-0.88/lib/Params/Validate.pm 2007-03-07 15:44:37.000000000 +0100 @@ -16,7 +16,7 @@ @ISA = 'Exporter'; - $VERSION = '0.87'; + $VERSION = '0.88'; my %tags = ( types => diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Params-Validate-0.87/META.yml new/Params-Validate-0.88/META.yml --- old/Params-Validate-0.87/META.yml 2007-01-18 16:48:48.000000000 +0100 +++ new/Params-Validate-0.88/META.yml 2007-03-07 15:55:14.000000000 +0100 @@ -1,13 +1,16 @@ -# http://module-build.sourceforge.net/META-spec.html -#XXXXXXX This is a prototype!!! It will change in the future!!! XXXXX# -name: Params-Validate -version: 0.87 -version_from: lib/Params/Validate.pm -installdirs: site -requires: +--- #YAML:1.0 +name: Params-Validate +version: 0.88 +abstract: Validate method/function parameters +license: ~ +generated_by: ExtUtils::MakeMaker version 6.32 +distribution_type: module +requires: Attribute::Handlers: 0 Scalar::Util: 0 Test::More: 0 - -distribution_type: module -generated_by: ExtUtils::MakeMaker version 6.30_01 +meta-spec: + url: http://module-build.sourceforge.net/META-spec-v1.2.html + version: 1.2 +author: + - Dave Rolsky, diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Params-Validate-0.87/t/21-can.t new/Params-Validate-0.88/t/21-can.t --- old/Params-Validate-0.87/t/21-can.t 2006-01-21 18:57:25.000000000 +0100 +++ new/Params-Validate-0.88/t/21-can.t 2007-03-07 15:46:38.000000000 +0100 @@ -3,7 +3,7 @@ use strict; use Params::Validate qw(validate); -use Test::More tests => 9; +use Test::More tests => 13; { my @p = ( foo => 'ClassCan' ); @@ -107,6 +107,44 @@ like( $@, qr/does not have the method: 'thingy'/ ); } +{ + my @p = ( foo => {} ); + eval + { + validate( @p, + { foo => { can => 'thingy' } }, + ); + }; + like( $@, qr/does not have the method: 'thingy'/, 'unblessed ref ->can' ); + + @p = ( foo => 27 ); + eval + { + validate( @p, + { foo => { can => 'thingy' } }, + ); + }; + like( $@, qr/does not have the method: 'thingy'/, 'number can' ); + + @p = ( foo => 'A String' ); + eval + { + validate( @p, + { foo => { can => 'thingy' } }, + ); + }; + like( $@, qr/does not have the method: 'thingy'/, 'string can' ); + + @p = ( foo => undef ); + eval + { + validate( @p, + { foo => { can => 'thingy' } }, + ); + }; + like( $@, qr/does not have the method: 'thingy'/, 'undef can' ); +} + package ClassCan; diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Params-Validate-0.87/t/26-isa.t new/Params-Validate-0.88/t/26-isa.t --- old/Params-Validate-0.87/t/26-isa.t 2006-05-09 23:59:39.000000000 +0200 +++ new/Params-Validate-0.88/t/26-isa.t 2007-03-07 15:50:27.000000000 +0100 @@ -3,7 +3,7 @@ use strict; use Params::Validate qw(validate); -use Test::More tests => 9; +use Test::More tests => 13; { my @p = ( foo => 'ClassISA' ); @@ -101,6 +101,44 @@ like( $@, qr/was not a 'Thingy'/ ); } +{ + my @p = ( foo => {} ); + eval + { + validate( @p, + { foo => { isa => 'Thingy' } }, + ); + }; + like( $@, qr/was not a 'Thingy'/, 'unblessed ref ->isa' ); + + @p = ( foo => 27 ); + eval + { + validate( @p, + { foo => { isa => 'Thingy' } }, + ); + }; + like( $@, qr/was not a 'Thingy'/, 'number isa' ); + + @p = ( foo => 'A String' ); + eval + { + validate( @p, + { foo => { isa => 'Thingy' } }, + ); + }; + like( $@, qr/was not a 'Thingy'/, 'string isa' ); + + @p = ( foo => undef ); + eval + { + validate( @p, + { foo => { isa => 'Thingy' } }, + ); + }; + like( $@, qr/was not a 'Thingy'/, 'undef isa' ); +} + package ClassISA; diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Params-Validate-0.87/Validate.xs new/Params-Validate-0.88/Validate.xs --- old/Params-Validate-0.87/Validate.xs 2007-01-18 02:24:59.000000000 +0100 +++ new/Params-Validate-0.88/Validate.xs 2007-03-07 15:52:44.000000000 +0100 @@ -209,7 +209,9 @@ case SVt_PVMG: case SVt_PVIV: case SVt_PVNV: +#if PERL_VERSION <= 8 case SVt_PVBM: +#endif type = SCALARREF; break; case SVt_PVAV: @@ -355,14 +357,15 @@ } } -/* UNIVERSAL::isa alike validation */ +/* $value->isa alike validation */ static IV validate_isa(SV* value, SV* package, SV* id, HV* options) { SV* buffer; IV ok = 1; - if (SvOK(value)) { + SvGETMAGIC(value); + if (SvOK(value) && (sv_isobject(value) || (SvPOK(value) && ! looks_like_number(value)))) { dSP; SV* ret; @@ -424,7 +427,8 @@ { IV ok = 1; - if (SvOK(value)) { + SvGETMAGIC(value); + if (SvOK(value) && (sv_isobject(value) || (SvPOK(value) && ! looks_like_number(value)))) { dSP; SV* ret; ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org