Hello community,
here is the log from the commit of package perl-Set-Object
checked in at Fri Feb 16 18:41:51 CET 2007.
--------
--- perl-Set-Object/perl-Set-Object.changes 2007-01-25 20:48:47.000000000 +0100
+++ perl-Set-Object/perl-Set-Object.changes 2007-02-16 14:06:19.000000000 +0100
@@ -1,0 +2,12 @@
+Fri Feb 16 11:31:02 CET 2007 - anicka@suse.cz
+
+- update to 1.20
+ * The C<-E<gt>compare> function was returning "disjoint" for empty
+ sets.
+ * Document lots of methods that were previously not documented.
+ * Fix CSet::Object::Weak::set(). It was not passing its
+ arguments to C, which was very
+ broken.
+- fix misc/pod_coverage.t
+
+-------------------------------------------------------------------
Old:
----
Set-Object-1.19.tar.bz2
perl-Set-Object-1.19-return_value.diff
New:
----
Set-Object-1.20.tar.bz2
perl-Set-Object-1.20-return_value.diff
perl-Set-Object-1.20-test.diff
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Set-Object.spec ++++++
--- /var/tmp/diff_new_pack.r25344/_old 2007-02-16 18:40:05.000000000 +0100
+++ /var/tmp/diff_new_pack.r25344/_new 2007-02-16 18:40:05.000000000 +0100
@@ -1,5 +1,5 @@
#
-# spec file for package perl-Set-Object (Version 1.19)
+# spec file for package perl-Set-Object (Version 1.20)
#
# Copyright (c) 2007 SUSE LINUX Products GmbH, Nuernberg, Germany.
# This file and all modifications and additions to the pristine
@@ -11,7 +11,7 @@
# norootforbuild
Name: perl-Set-Object
-Version: 1.19
+Version: 1.20
Release: 1
Requires: perl = %{perl_version}
Autoreqprov: on
@@ -21,6 +21,7 @@
Summary: Set of objects
Source0: Set-Object-%{version}.tar.bz2
Patch: %{name}-%{version}-return_value.diff
+Patch1: %{name}-%{version}-test.diff
BuildRoot: %{_tmppath}/%{name}-%{version}-build
%description
@@ -36,6 +37,7 @@
%prep
%setup -q -n Set-Object-%{version}
%patch
+%patch1
%build
perl Makefile.PL OPTIMIZE="$RPM_OPT_FLAGS -Wall"
@@ -57,7 +59,16 @@
%{perl_vendorarch}/auto/Set
/var/adm/perl-modules/%{name}
-%changelog -n perl-Set-Object
+%changelog
+* Fri Feb 16 2007 - anicka@suse.cz
+- update to 1.20
+ * The C<-E<gt>compare> function was returning "disjoint" for empty
+ sets.
+ * Document lots of methods that were previously not documented.
+ * Fix CSet::Object::Weak::set(). It was not passing its
+ arguments to C, which was very
+ broken.
+- fix misc/pod_coverage.t
* Thu Jan 25 2007 - anicka@suse.cz
- update to 1.19
* New class CSet::Object::Weak, which all weak sets should get
++++++ Set-Object-1.19.tar.bz2 -> Set-Object-1.20.tar.bz2 ++++++
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/Changes.pod new/Set-Object-1.20/Changes.pod
--- old/Set-Object-1.19/Changes.pod 2007-01-23 02:01:25.000000000 +0100
+++ new/Set-Object-1.20/Changes.pod 2007-02-16 00:48:11.000000000 +0100
@@ -1,6 +1,26 @@
=head1 REVISION HISTORY FOR Set::Object
+=head1 1.20, 16 Feb 2007
+
+=over
+
+=item *
+
+The C<-E<gt>compare> function was returning "disjoint" for empty sets.
+RT#24965. (Nigel Metheringham)
+
+=item *
+
+Document lots of methods that were previously not documented.
+
+=item *
+
+Fix CSet::Object::Weak::set(). It was not passing its arguments to
+C, which was very broken.
+
+=back
+
=head1 1.19, 23 Jan 2007
=over
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/MANIFEST new/Set-Object-1.20/MANIFEST
--- old/Set-Object-1.19/MANIFEST 2007-01-23 02:06:18.000000000 +0100
+++ new/Set-Object-1.20/MANIFEST 2007-02-16 00:48:11.000000000 +0100
@@ -47,5 +47,7 @@
t/ingy/arrayref.t
t/misc/leaks.t
+t/misc/pod.t
+t/misc/pod_coverage.t
ppport.h
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/META.yml new/Set-Object-1.20/META.yml
--- old/Set-Object-1.19/META.yml 2007-01-23 02:08:59.000000000 +0100
+++ new/Set-Object-1.20/META.yml 2007-02-16 00:55:38.000000000 +0100
@@ -1,7 +1,7 @@
# http://module-build.sourceforge.net/META-spec.html
#XXXXXXX This is a prototype!!! It will change in the future!!! XXXXX#
name: Set-Object
-version: 1.19
+version: 1.20
version_from: lib/Set/Object.pm
installdirs: site
requires:
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/lib/Set/Object/Weak.pm new/Set-Object-1.20/lib/Set/Object/Weak.pm
--- old/Set-Object-1.19/lib/Set/Object/Weak.pm 2007-01-23 01:38:38.000000000 +0100
+++ new/Set-Object-1.20/lib/Set/Object/Weak.pm 2007-02-16 00:48:09.000000000 +0100
@@ -32,6 +32,17 @@
our @EXPORT_OK = qw(weak_set set);
+=head1 CONSTRUCTORS
+
+=over
+
+=item new
+
+This class method is exactly the same as C,
+except that it returns a weak set.
+
+=cut
+
sub new {
my $class = shift;
my $self = $class->SUPER::new();
@@ -40,18 +51,43 @@
$self;
}
+=item weak_set( ... )
+
+This optionally exported B<function> is a shortcut for saying
+C.
+
+=cut
+
+
sub weak_set {
__PACKAGE__->new(@_);
}
+=item set( ... )
+
+This method is exported so that if you see:
+
+ use Set::Object qw(set);
+
+You can turn it into using weak sets lexically with:
+
+ use Set::Object::Weak qw(set);
+
+Set::Object 1.19 had a bug in this method that meant that it would not
+add the passed members into it.
+
+=cut
+
sub set {
- __PACKAGE__->new();
+ __PACKAGE__->new(@_);
}
1;
__END__
+=back
+
=head1 SEE ALSO
LSet::Object
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/lib/Set/Object.pm new/Set-Object-1.20/lib/Set/Object.pm
--- old/Set-Object-1.19/lib/Set/Object.pm 2007-01-23 01:58:45.000000000 +0100
+++ new/Set-Object-1.20/lib/Set/Object.pm 2007-02-16 00:48:11.000000000 +0100
@@ -153,6 +153,10 @@
the invocant to CSet::Object::Weak. Override the method C
in your sub-class to control this behaviour.
+=head2 is_weak
+
+Returns a true value if this set is a weak set.
+
=head2 strengthen
Turns a weak set back into a normal one.
@@ -179,6 +183,20 @@
Return a textual Smalltalk-ish representation of the CSet::Object.
Also available as overloaded operator "".
+=head2 equal( I<set> )
+
+Returns a true value if I<set> contains exactly the same members as
+the invocant.
+
+Also available as overloaded operator C<==> (or C<eq>).
+
+=head2 not_equal( I<set> )
+
+Returns a false value if I<set> contains exactly the same members as
+the invocant.
+
+Also available as overloaded operator C (or C<ne>).
+
=head2 intersection( [I<list>] )
Return a new CSet::Object containing the intersection of the
@@ -231,6 +249,11 @@
Return C<true> if this CSet::Object is a proper superset of I<set>
Also available as operator C.
+=head2 is_null( I<set> )
+
+Returns a true value if this set does not contain any members, that
+is, if its size is zero.
+
=head1 Set::Scalar compatibility methods
By and large, LSet::Object is not and probably never will be
@@ -332,6 +355,34 @@
=back
+=head1 CLASS METHODS
+
+These class methods are probably only interesting to those
+sub-classing CSet::Object.
+
+=over
+
+=item strong_pkg
+
+When a set that was already weak is strengthened using
+C<-E<gt>strengthen>, it gets re-blessed into this package.
+
+=item weak_pkg
+
+When a set that was NOT already weak is weakened using
+C<-E<gt>weaken>, it gets re-blessed into this package.
+
+=item tie_array_pkg
+
+When the object is accessed as an array, tie the array into this
+package.
+
+=item tie_hash_pkg
+
+When the object is accessed as a hash, tie the hash into this package.
+
+=back
+
=head1 SERIALIZATION
It is possible to serialize CSet::Object objects via L<Storable> and
@@ -439,7 +490,7 @@
@EXPORT_OK = qw( ish_int is_int is_string is_double blessed reftype
refaddr is_overloaded is_object is_key set weak_set );
-$VERSION = '1.19';
+$VERSION = '1.20';
bootstrap Set::Object $VERSION;
@@ -959,7 +1010,12 @@
}
}
} else {
- return "disjoint";
+ if ($self->size || $other->size) {
+ return "disjoint";
+ } else {
+ # both sets are empty
+ return "equal";
+ }
}
}
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/t/misc/pod.t new/Set-Object-1.20/t/misc/pod.t
--- old/Set-Object-1.19/t/misc/pod.t 1970-01-01 01:00:00.000000000 +0100
+++ new/Set-Object-1.20/t/misc/pod.t 2007-02-16 00:05:46.000000000 +0100
@@ -0,0 +1,6 @@
+#!perl
+
+use Test::More;
+eval "use Test::Pod 1.00";
+plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
+all_pod_files_ok();
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/t/misc/pod_coverage.t new/Set-Object-1.20/t/misc/pod_coverage.t
--- old/Set-Object-1.19/t/misc/pod_coverage.t 1970-01-01 01:00:00.000000000 +0100
+++ new/Set-Object-1.20/t/misc/pod_coverage.t 2007-02-16 00:23:45.000000000 +0100
@@ -0,0 +1,29 @@
+#!perl
+
+BEGIN {
+ eval "use Test::Pod::Coverage tests => 2;";
+ if ( $@ ) {
+ require Test::More;
+ Test::More::skip_all ("Test::Pod::Coverage required for "
+ ."testing POD coverage");
+ exit;
+ }
+}
+
+use Set::Object;
+use Set::Object::Weak;
+
+pod_coverage_ok
+ ( "Set::Object",
+ { also_private => [ qr/^STORABLE_/, qr/^op_/,
+ "get_flat",
+ "rvrc", "rc", "is_object",
+ ], },
+ "Set::Object, except the functions we know are private",
+ );
+
+pod_coverage_ok
+ ( "Set::Object::Weak",
+ { also_private => [ qr/^[A-Z_]+$/ ], },
+ "Set::Object::Weak, with all-caps functions as privates",
+ );
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/t/object/weakref.t new/Set-Object-1.20/t/object/weakref.t
--- old/Set-Object-1.19/t/object/weakref.t 2007-01-23 01:49:58.000000000 +0100
+++ new/Set-Object-1.20/t/object/weakref.t 2007-02-16 00:48:05.000000000 +0100
@@ -1,6 +1,6 @@
# -*- perl -*-
-use Test::More tests => 36;
+use Test::More tests => 37;
use Set::Object qw(set refaddr);
use Storable qw(dclone);
use strict;
@@ -170,6 +170,9 @@
$ws = Set::Object::Weak->new( 0, "", {}, [], (bless {}, "Object") );
is($ws->size, 2, "made a weak set");
+$ws = Set::Object::Weak::set("one");
+is($ws->size, 1, "Set::Object::Weak::set() inserts its arguments");
+
{package Tie::Scalar::Null;
sub TIEHASH {
my ($class) = @_;
diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/Set-Object-1.19/t/scalar/compare.t new/Set-Object-1.20/t/scalar/compare.t
--- old/Set-Object-1.19/t/scalar/compare.t 2005-11-17 22:08:51.000000000 +0100
+++ new/Set-Object-1.20/t/scalar/compare.t 2007-02-15 23:58:51.000000000 +0100
@@ -10,7 +10,7 @@
my $n = Set::Object->new(qw());
my $o = Set::Object->new(qw());
-print "1..23\n";
+print "1..24\n";
print "not " unless $t == $u;
print "ok 1\n";
@@ -85,6 +85,10 @@
print "ok 23\n";
}
+# [cpan #24965]
+print "not " unless $n->compare($o) eq 'equal';
+print "ok 24\n";
+
sub show {
my $z = shift;
++++++ perl-Set-Object-1.19-return_value.diff -> perl-Set-Object-1.20-return_value.diff ++++++
++++++ perl-Set-Object-1.20-test.diff ++++++
--- t/misc/pod_coverage.t
+++ t/misc/pod_coverage.t
@@ -3,9 +3,8 @@
BEGIN {
eval "use Test::Pod::Coverage tests => 2;";
if ( $@ ) {
- require Test::More;
- Test::More::skip_all ("Test::Pod::Coverage required for "
- ."testing POD coverage");
+ eval 'use Test::More skip_all => "Test::Pod::Coverage required for "
+ ."testing POD coverage"';
exit;
}
}
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Remember to have fun...
---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-commit+help@opensuse.org
