Hello community, here is the log from the commit of package xbanner checked in at Thu Nov 16 12:06:18 CET 2006. -------- --- xbanner/xbanner.changes 2006-08-07 14:46:44.000000000 +0200 +++ /mounts/work_src_done/STABLE/xbanner/xbanner.changes 2006-11-16 10:03:18.000000000 +0100 @@ -1,0 +2,6 @@ +Thu Nov 16 10:02:39 CET 2006 - anosek@suse.cz + +- replaced dangerous gets() function by fgets() + [#219044] (gets.patch) + +------------------------------------------------------------------- New: ---- xbanner-1.31-gets.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ xbanner.spec ++++++ --- /var/tmp/diff_new_pack.NKT8fX/_old 2006-11-16 12:05:03.000000000 +0100 +++ /var/tmp/diff_new_pack.NKT8fX/_new 2006-11-16 12:05:03.000000000 +0100 @@ -12,15 +12,16 @@ Name: xbanner BuildRequires: xorg-x11-devel -License: GPL, Other License(s), see package +License: GNU General Public License (GPL), Other License(s), see package Group: Amusements/Toys/Background Autoreqprov: on Version: 1.31 -Release: 874 +Release: 893 Summary: X Window System background writings and images URL: http://www.hijinks.com/~spade/linux/XBanner/ Source: XBanner%{version}.tar.bz2 Patch: XBanner%{version}.dif +Patch1: xbanner-%{version}-gets.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build %description @@ -43,6 +44,7 @@ %prep %setup -n XBanner%{version} %patch +%patch1 %build xmkmf -a @@ -87,6 +89,9 @@ %config /usr/share/X11/app-defaults/XBanner %changelog -n xbanner +* Thu Nov 16 2006 - anosek@suse.cz +- replaced dangerous gets() function by fgets() + [#219044] (gets.patch) * Mon Aug 07 2006 - mmarek@suse.cz - moved from /usr/X11R6 to /usr to build with new Xorg * Sat May 27 2006 - schwab@suse.de ++++++ xbanner-1.31-gets.patch ++++++ --- xb_check.c +++ xb_check.c @@ -280,6 +280,7 @@ int i,j,k; char namelist[MAX_CYCS][MAX_CYCNAME]; char appname[LNLEN]="xbanner"; + char *p; if (argc>1) { @@ -303,8 +304,9 @@ } } - while(gets(line)!=NULL) + while(fgets(line, sizeof line, stdin)!=NULL) { + if ((p = strchr(line, '\n')) != NULL) *p = '\0'; if(line[0]=='!') continue; strcpy(elem1,elem(line,0)); ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org