Mailinglist Archive: opensuse-commit (1262 mails)

< Previous Next >
commit itrace
  • From: root@xxxxxxx (h_root)
  • Date: Fri, 8 Sep 2006 18:05:29 +0200 (CEST)
  • Message-id: <20060908160529.66AB318B118@xxxxxxxxxxxxxxx>

Hello community,

here is the log from the commit of package itrace
checked in at Fri Sep 8 18:05:29 CEST 2006.

--------
--- arch/ppc/itrace/itrace.changes 2006-08-16 08:46:09.000000000 +0200
+++ itrace/itrace.changes 2006-09-08 16:54:16.000000000 +0200
@@ -1,0 +2,5 @@
+Fri Sep 8 16:54:04 CEST 2006 - olh@xxxxxxx
+
+- fix build warnings
+
+-------------------------------------------------------------------

New:
----
itrace.warnings.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ itrace.spec ++++++
--- /var/tmp/diff_new_pack.LlpD3s/_old 2006-09-08 18:04:54.000000000 +0200
+++ /var/tmp/diff_new_pack.LlpD3s/_new 2006-09-08 18:04:54.000000000 +0200
@@ -12,7 +12,7 @@

Name: itrace
Version: 0.9
-Release: 12
+Release: 13
BuildRequires: kernel-source kernel-syms
URL: http://perfinsp.sourceforge.net/itrace_ppc.html
Summary: Instruction Tracing Tool
@@ -27,6 +27,7 @@
Patch4: itrace-post-main.patch
Patch5: itrace-power5-only.patch
Patch6: itrace-is_stepping_safe_ss.patch
+Patch7: itrace.warnings.patch
ExclusiveArch: ppc ppc64
Requires: itrace-kmp-ppc64
%suse_kernel_module_package kdump um xen xenpae default smp debug bigsmp iseries64
@@ -83,6 +84,7 @@
%patch4 -p1
#patch5 -p1
%patch6 -p1
+%patch7 -p1

%build
autoreconf -i --force
@@ -129,6 +131,8 @@
%{_mandir}/*/*

%changelog -n itrace
+* Fri Sep 08 2006 - olh@xxxxxxx
+- fix build warnings
* Wed Aug 16 2006 - olh@xxxxxxx
- enable is_stepping_safe_ss r13 exception hack for all kernels
* Fri Aug 11 2006 - olh@xxxxxxx

++++++ itrace.warnings.patch ++++++
swtrace.c:217: warning: return type defaults to 'int'
swtrace.c: In function 'open_driver':
swtrace.c:220: warning: implicit declaration of function 'Open_PIPerf_Driver'
swtrace.c:231: warning: implicit declaration of function 'Get_Driver_Info'
swtrace.c:234: warning: implicit declaration of function 'Close_PIPerf_Driver'
swtrace.c:239: warning: 'return' with no value, in function returning non-void
swtrace.c: In function 'append_kallsyms_and_modules':
swtrace.c:280: warning: ignoring return value of 'system', declared with attribute warn_unused_result
swtrace.c:296: warning: ignoring return value of 'system', declared with attribute warn_unused_result
swtrace.c:312: warning: ignoring return value of 'system', declared with attribute warn_unused_result
swtrace.c:334: warning: ignoring return value of 'fread', declared with attribute warn_unused_result
swtrace.c:344: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result
swtrace.c: In function 'main':
swtrace.c:458: warning: implicit declaration of function 'TraceFree'
swtrace.c:517: warning: statement with no effect
swtrace.c:552: warning: unused variable 'i'
swtrace.c:590: warning: implicit declaration of function 'GetMecTable'
swtrace.c:854: warning: implicit declaration of function 'ITrace_Install'
swtrace.c:882: warning: implicit declaration of function 'ITrace_Remove'
swtrace.c:906: warning: implicit declaration of function 'ITrace_On'
swtrace.c:940: warning: too many arguments for format
swtrace.c:944: warning: implicit declaration of function 'ITrace_PID_On'
swtrace.c:362: warning: unused variable 'version'
swtrace.c:358: warning: unused variable 'swtrace_version'
swtrace.c:357: warning: unused variable 'count'
swtrace.c: At top level:
swtrace.c:55: warning: 'pcontrol' defined but not used

perfutil.c: In function 'open_driver':
perfutil.c:47: warning: implicit declaration of function 'Open_PIPerf_Driver'
perfutil.c: In function 'TraceHook':
perfutil.c:103: warning: pointer targets in assignment differ in signedness
perfutil.c:115: warning: pointer targets in assignment differ in signedness
perfutil.c:123: warning: implicit declaration of function 'ioctl'
perfutil.c: In function 'ReadCyclesOnProcessor':
perfutil.c:190: warning: implicit declaration of function 'sched_getaffinity'
perfutil.c:197: warning: statement with no effect
perfutil.c:198: warning: implicit declaration of function 'sched_setaffinity'
perfutil.c: In function 'GetMecTable':
perfutil.c:619: warning: unused variable 'pid'
perfutil.c:618: warning: unused variable 'pr'
perfutil.c: In function 'PTTGetThreadTime':
perfutil.c:789: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'PTTGetThreads':
perfutil.c:812: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'PTTGetStats':
perfutil.c:834: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'SetMemProbe':
perfutil.c:856: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'StopMemProbe':
perfutil.c:876: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'GetMemSummary':
perfutil.c:896: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'PTTGetCurrentThreadTimeEx':
perfutil.c:939: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'getVersion':
perfutil.c:972: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'ITrace_On':
perfutil.c:1140: warning: unused variable 'pr'
perfutil.c: In function 'PttInit':
perfutil.c:1250: warning: unused variable 'i'
perfutil.c: In function 'PttGetStats':
perfutil.c:1291: warning: 'return' with no value, in function returning non-void
perfutil.c: In function 'PttGetCurrentThreadData':
perfutil.c:1310: warning: 'return' with no value, in function returning non-void
perfutil.c:1304: warning: unused variable 'my_ptt'
perfutil.c:1303: warning: unused variable 'pid2'
perfutil.c:1303: warning: unused variable 'pid1'
perfutil.c:1302: warning: unused variable 't'
perfutil.c:1301: warning: unused variable 'temp'
perfutil.c: In function 'SwitchToProcessor':
perfutil.c:1420: warning: statement with no effect

---
src/perfutil/perfutil.c | 25 +++++++++++++------------
src/swtrace/pipcntr.c | 2 +-
src/swtrace/ptt.c | 2 +-
src/swtrace/swtrace.c | 5 ++---
4 files changed, 17 insertions(+), 17 deletions(-)

Index: itrace_ppc64-0.9/src/perfutil/perfutil.c
===================================================================
--- itrace_ppc64-0.9.orig/src/perfutil/perfutil.c
+++ itrace_ppc64-0.9/src/perfutil/perfutil.c
@@ -31,6 +31,7 @@
#include <fcntl.h>
#include <errno.h>
#include <sched.h>
+#include <sys/ioctl.h>
#include "piperf_hardware.h"
#include "perfutil.h"
#include "pitrace.h"
@@ -41,7 +42,7 @@
static int pfn = 0; /* file number of driver by pid*/


-int open_driver(void)
+static int open_driver(void)
{
if (pfn == 0 ) {
pfn = Open_PIPerf_Driver();
@@ -786,7 +787,7 @@ int PTTGetThreadTime(int pid, int tid,
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}
}

@@ -809,7 +810,7 @@ int PTTGetThreads(unsigned long *buffer)
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}
}

@@ -831,7 +832,7 @@ int PTTGetStats(unsigned long *buffer, u
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}
}

@@ -853,7 +854,7 @@ int SetMemProbe()
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}
}

@@ -873,7 +874,7 @@ int StopMemProbe()
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}
}

@@ -893,7 +894,7 @@ int GetMemSummary(unsigned long *buffer,
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}
}

@@ -936,7 +937,7 @@ int PTTGetCurrentThreadTimeEx(PTT_TIMEX
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}
}
pr->parm1 = (ulong)t;
@@ -969,7 +970,7 @@ int getVersion( ulong *version )
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if (pfn <= 0 ) {
- return;
+ return -1;
}
}

@@ -1288,7 +1289,7 @@ int PttGetStats(unsigned long *buffer, u
// Driver not opened.
pfn = Open_PIPerf_Driver();
if (pfn <= 0)
- return;
+ return -1;
}
pr->parm1 = (ulong)buffer;
pr->size = size;
@@ -1307,7 +1308,7 @@ int PttGetCurrentThreadData(PTT_THREAD_D
/* Driver not opened. */
pfn = Open_PIPerf_Driver();
if ( pfn <= 0 ) {
- return;
+ return -1;
}

}
@@ -1417,7 +1418,7 @@ int GetLastSampledThread(int cpunum)
void SwitchToProcessor(int cpunum, int tid)
{
unsigned long mask = 1;
- mask << cpunum;
+ mask <<= cpunum;
sched_setaffinity(tid, sizeof(unsigned long), &mask);
sleep(0);
}
Index: itrace_ppc64-0.9/src/swtrace/swtrace.c
===================================================================
--- itrace_ppc64-0.9.orig/src/swtrace/swtrace.c
+++ itrace_ppc64-0.9/src/swtrace/swtrace.c
@@ -213,7 +213,7 @@ void usage(void)
return;
}

-open_driver()
+static void open_driver(void)
{

/* Go open the device driver. */
@@ -937,8 +937,7 @@ int main(int argc, char *argv[])
if (temp == 0) {
fprintf(stderr,
"ERROR (itrace): Failed to turn on tracing \n");
- fprintf(stderr, " Illegal PID\n",
- argv[0]);
+ fprintf(stderr, " Illegal PID\n");
exit(1);
}
rc = ITrace_PID_On(temp);
Index: itrace_ppc64-0.9/src/swtrace/pipcntr.c
===================================================================
--- itrace_ppc64-0.9.orig/src/swtrace/pipcntr.c
+++ itrace_ppc64-0.9/src/swtrace/pipcntr.c
@@ -125,7 +125,7 @@ void usage(void){
#endif
}

-open_driver()
+static void open_driver(void)
{

/* Go open the device driver. */
Index: itrace_ppc64-0.9/src/swtrace/ptt.c
===================================================================
--- itrace_ppc64-0.9.orig/src/swtrace/ptt.c
+++ itrace_ppc64-0.9/src/swtrace/ptt.c
@@ -223,7 +223,7 @@ void reports(void) {
}

/***********************/
-open_driver() {
+static void open_driver(void) {
fn = Open_PIPerf_Driver();

if(fn <= 0) {

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++



Remember to have fun...

---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-commit+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-commit+help@xxxxxxxxxxxx

< Previous Next >
This Thread
  • No further messages