Hello community, here is the log from the commit of package control-center2 checked in at Wed May 10 18:37:37 CEST 2006. -------- --- GNOME/control-center2/control-center2.changes 2006-05-07 22:57:56.000000000 +0200 +++ STABLE/control-center2/control-center2.changes 2006-05-09 20:52:02.000000000 +0200 @@ -1,0 +2,6 @@ +Tue May 9 20:50:51 CEST 2006 - dobey@suse.de + +- Add fixes for CRITICAL warnings from background-properties + See bug https://bugzilla.novell.com/show_bug.cgi?id=83196 + +------------------------------------------------------------------- New: ---- control-center-background-properites-fixes.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ control-center2.spec ++++++ --- /var/tmp/diff_new_pack.evMUAV/_old 2006-05-10 18:37:04.000000000 +0200 +++ /var/tmp/diff_new_pack.evMUAV/_new 2006-05-10 18:37:04.000000000 +0200 @@ -21,7 +21,7 @@ Obsoletes: fontilus themus acme Provides: fontilus themus acme Version: 2.12.2 -Release: 59 +Release: 61 Summary: The GNOME Control Center for the GNOME 2.x Desktop Source: %{_name}-%{version}.tar.bz2 Source1: control-center-art.tar.bz2 @@ -46,6 +46,7 @@ Patch18: control-center2-multiple-displays.patch Patch19: control-center2-gst-0-10.patch Patch20: control-center2-compiz-keybindings.patch +Patch21: control-center-background-properites-fixes.patch URL: http://www.gnome.org BuildRoot: %{_tmppath}/%{name}-%{version}-build PreReq: filesystem gconf2 shared-mime-info permissions @@ -97,6 +98,7 @@ %patch18 %patch19 %patch20 +%patch21 gnome-patch-translation-update %build @@ -236,6 +238,9 @@ %{prefix}/share/idl/*.idl %changelog -n control-center2 +* Tue May 09 2006 - dobey@suse.de +- Add fixes for CRITICAL warnings from background-properties + See bug https://bugzilla.novell.com/show_bug.cgi?id=83196 * Sun May 07 2006 - danw@suse.de - Add cube unfold binding to control-center2-compiz-keybindings.patch * Tue May 02 2006 - sbrabec@suse.cz ++++++ control-center-background-properites-fixes.patch ++++++ Index: capplets/background/gnome-wp-capplet.c =================================================================== RCS file: /cvs/gnome/gnome-control-center/capplets/background/gnome-wp-capplet.c,v retrieving revision 1.36 retrieving revision 1.43 diff -u -p -r1.36 -r1.43 --- capplets/background/gnome-wp-capplet.c 1 Oct 2005 21:29:39 -0000 1.36 +++ capplets/background/gnome-wp-capplet.c 11 Feb 2006 06:28:53 -0000 1.43 @@ -81,7 +81,9 @@ static void gnome_wp_capplet_scroll_to_i GtkTreePath * path; g_return_if_fail (capplet != NULL); - g_return_if_fail (item != NULL); + + if (item == NULL) + return; path = gtk_tree_row_reference_get_path (item->rowref); gtk_tree_view_set_cursor (GTK_TREE_VIEW (capplet->treeview), path, Index: capplets/background/gnome-wp-info.c =================================================================== RCS file: /cvs/gnome/gnome-control-center/capplets/background/gnome-wp-info.c,v retrieving revision 1.8 retrieving revision 1.10 diff -u -p -r1.8 -r1.10 --- capplets/background/gnome-wp-info.c 14 Jul 2005 03:06:24 -0000 1.8 +++ capplets/background/gnome-wp-info.c 27 Jan 2006 03:01:58 -0000 1.10 @@ -95,6 +95,10 @@ GnomeWPInfo * gnome_wp_info_new (const g GnomeWPInfo * gnome_wp_info_dup (const GnomeWPInfo * info) { GnomeWPInfo * new; + + if (info == NULL) { + return NULL; + } new = g_new0 (GnomeWPInfo, 1); Index: capplets/background/gnome-wp-xml.c =================================================================== RCS file: /cvs/gnome/gnome-control-center/capplets/background/gnome-wp-xml.c,v retrieving revision 1.15 retrieving revision 1.17 diff -u -p -r1.15 -r1.17 --- capplets/background/gnome-wp-xml.c 1 Oct 2005 21:29:39 -0000 1.15 +++ capplets/background/gnome-wp-xml.c 18 Mar 2006 19:35:40 -0000 1.17 @@ -286,7 +286,7 @@ void gnome_wp_xml_load_list (GnomeWPCapp datadir = g_build_filename (xdgdirs[i], "gnome-background-properties", NULL); - if (g_file_test (datadir, G_FILE_TEST_EXISTS | G_FILE_TEST_IS_DIR)) { + if (g_file_test (datadir, G_FILE_TEST_IS_DIR)) { gnome_vfs_directory_list_load (&list, datadir, GNOME_VFS_FILE_INFO_DEFAULT | GNOME_VFS_FILE_INFO_FOLLOW_LINKS); @@ -313,7 +313,7 @@ void gnome_wp_xml_load_list (GnomeWPCapp g_strfreev (xdgdirs); g_free (xdgdirslist); - if (g_file_test (WALLPAPER_DATADIR, G_FILE_TEST_EXISTS | G_FILE_TEST_IS_DIR)) { + if (g_file_test (WALLPAPER_DATADIR, G_FILE_TEST_IS_DIR)) { gnome_vfs_directory_list_load (&list, WALLPAPER_DATADIR, GNOME_VFS_FILE_INFO_DEFAULT | GNOME_VFS_FILE_INFO_FOLLOW_LINKS); ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun...