Mailinglist Archive: opensuse-buildservice (89 mails)

< Previous Next >
Re: [opensuse-buildservice] Re: Request 329144 created by dimstar_suse (submit openSUSE:Factory/tevent)
On Mon, 2015-09-07 at 15:16 +0200, Lars Mueller wrote:
Hi Dominique,

On Mon, Sep 07, 2015 at 02:55:21PM +0200, Dominique Leuenberger /
DimStar wrote:
On Mon, 2015-09-07 at 14:45 +0200, Lars Mueller wrote:


++++++ new changes file:
--- tevent-man.changes
+++ tevent-man.changes

This split causes an minor issue to the
network:samba:STABLE/tevent/
tevent.spec file. In the header we there now have too:

#
# spec file for package tevent-man
#


That seems to be one of the source services (likely
format_spec_file)
to do some magic which it is not supposed to do.

In most such cases I've actually seen the 'main' package name being
used across all .spec files.

The tevent spec was quite "clean" till someone modified it recently.
;)

Yeah; me me me... doxygen has been a pain for a while already.. and
this only, because they decided to switch to cmake as their build
system; how stupid can it get.

If you really mind the comment in the .spec file, we can change the
pre_checkin.sh to update the Name: field in the spec and not have this
conditionally set based on build_man... this would be another option of
course (attached patch should be able to handle it)

DominiqueIndex: pre_checkin.sh
===================================================================
--- pre_checkin.sh (revision bc4333a2aca0e590b02092cb03e94756)
+++ pre_checkin.sh (working copy)
@@ -1,4 +1,4 @@
#!/bin/bash

-sed 's/%define.*build_man.*0/%define build_man 1/' tevent.spec >
tevent-man.spec
+sed -e 's/%define.*build_man.*0/%define build_man 1/' -e
's/^Name:.*%{_name}$/Name: %{_name}-man/' tevent.spec >
tevent-man.spec
cp tevent.changes tevent-man.changes
Index: tevent-man.spec
===================================================================
--- tevent-man.spec (revision bc4333a2aca0e590b02092cb03e94756)
+++ tevent-man.spec (working copy)
@@ -22,11 +22,10 @@
%define build_man 1
%define _name tevent

+Name: %{_name}-man
%if %{build_man}
-Name: %{_name}-man
BuildRequires: doxygen
%else
-Name: %{_name}
#!BuildIgnore: libtalloc
BuildRequires: libtalloc-devel >= %{talloc_version}
%if 0%{?suse_version} > 1020
Index: tevent.spec
===================================================================
--- tevent.spec (revision bc4333a2aca0e590b02092cb03e94756)
+++ tevent.spec (working copy)
@@ -1,5 +1,5 @@
#
-# spec file for package tevent-man
+# spec file for package tevent
#
# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
#
@@ -22,11 +22,10 @@
%define build_man 0
%define _name tevent

+Name: %{_name}
%if %{build_man}
-Name: %{_name}-man
BuildRequires: doxygen
%else
-Name: %{_name}
#!BuildIgnore: libtalloc
BuildRequires: libtalloc-devel >= %{talloc_version}
%if 0%{?suse_version} > 1020

< Previous Next >
Follow Ups