Mailinglist Archive: opensuse-buildservice (111 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] [backend] added noservice parameter to sourceinfo
On 2014-07-24 11:23:34 +0200, Michael Schroeder wrote:
On Thu, Jul 24, 2014 at 11:11:35AM +0200, Marcus Hüwe wrote:
On 2014-06-16 00:29:45 +0200, Marcus Huewe wrote:
This enables osc to speedup "osc up" in a project working
copy (in some cases) (by using the getprojectsourceinfo route).
---
src/backend/bs_srcserver | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

Any comments/objections to this patch? If preferred, I can also
create a pull request on github.

No complaints from my side, except that I'm not 100% happy about the
name "noservice", as noservice is already used in all the commit
routes to mean "noservicerun".
So I'm considering "ignoreservice" or "skipservice" or something
like that.

Ok. Then I'll change it to "ignoreservice" (ignore* is already used in
some of the backend routes).

(I'm also wondering if there shouldn't be an option to turn off
link expansion.)

For my use case this is not necessarily needed. If you like, I can also
add a something like a "noexpand" parameter (tbh I would prefer something
like an "expand" parameter to explicitly enable link expansion, because
this would be consistent with all other routes where we have a parameter
to control link expansion) - but this would change sourceinfo's default
behavior...


Marcus
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-buildservice+owner@xxxxxxxxxxxx

< Previous Next >
Follow Ups