Mailinglist Archive: opensuse-buildservice (88 mails)

< Previous Next >
Re: [opensuse-buildservice] kiwi prepare call optimization

On Feb 18, 2014, at 14:41 , Kanstantsin Shautsou <gentoo.integer@xxxxxxxxx>
wrote:


On Feb 18, 2014, at 12:52 , Adrian Schröter <adrian@xxxxxxx> wrote:

On Dienstag, 18. Februar 2014, 00:34:05 wrote Kanstantsin Shautsou:
Why OBS call prepare step for every image type?
https://github.com/openSUSE/obs-build/blob/4326a1ae347a8a9cd8abe57433f9beb2d8f7b01c/build_kiwi.sh#L116-L119
According to http://doc.opensuse.org/projects/kiwi/doc :
"Successful completion of the prepare step is a the pre-requisite for the
create step of the image build process. With the successful completion of
the image preparation the unpacked root tree is considered complete and
consistent. Creating the packed, or final image requires the execution of
the create step. Multiple images can be created using the same unpacked
root tree, for example it is possible to create a self installing OEM image
and a virtual machine image from one unpacked root tree, under the
condition that both image types are specified in the config.xml when the
prepare step is executed. “

OBS can copy image tree if it worry about ‘images.sh’ differences between
different image types.

there were times when building the image modified the tree. Maybe not kiwi
itself, but some config.sh scripts or alike.

In any case it was needed to change in the way as it is today.



This could be because of images.sh that is called during create and needed
for tree customizations for specified image type.
I think OBS can just copy prepared once image tree to specified type and then
call create (any COW on fs?) .
So my suggestions:
1) for build_kiwi.sh: --prepare once, then duplicate prepared tree for any
—create image type
2) for kiwi: un-hardcode “images.sh” to configurable value in kiwi config. It
will exclude need for duplicating kiwi package for different image types.--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-buildservice+owner@xxxxxxxxxxxx

< Previous Next >