Mailinglist Archive: opensuse-buildservice (156 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] [backend] fix error msg when using external tool.
  • From: Jeremiah Foster <jeremiah.foster@xxxxxxxxxxxxxx>
  • Date: Fri, 13 Apr 2012 09:18:14 +0200
  • Message-id: <CADVDRBh7RoOUvYT2YBXxMOQymfJiiQYRpnev5JiLBfVSE=Rj0g@mail.gmail.com>
On Thu, Apr 12, 2012 at 7:17 PM, Hector Oron
<hector.oron@xxxxxxxxxxxxxxx> wrote:
 Fix typo on error message when using external publisher program.

Signed-off-by: Hector Oron <hector.oron@xxxxxxxxxxxxxxx>
---
 src/backend/bs_publish |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/backend/bs_publish b/src/backend/bs_publish
index afa1bbb..f549261 100755
--- a/src/backend/bs_publish
+++ b/src/backend/bs_publish
@@ -1430,7 +1430,7 @@ sub publish {
      return;
    }
    if (system($BSConfig::publishprogram->{$prp}, $prp, $extrep)) {
-      die("      $BSConfig::publishprogram{$prp} failed: $?\n");
+      die("      $BSConfig::publishprogram->{$prp} failed: $?\n");
    }
    goto publishprog_done;


goto? Is goto really a good programming practice? I've always
understood it as an anti-pattern.

Regards,

Jeremiah
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
To contact the owner, e-mail: opensuse-buildservice+owner@xxxxxxxxxxxx

< Previous Next >
References