Mailinglist Archive: opensuse-buildservice (256 mails)

< Previous Next >
Re: [opensuse-buildservice] Re: [PATCH] [api] remove obsolete or wrong FIXME comments. Move some to 3.0 release.
  • From: Sascha Peilicke <saschpe@xxxxxxx>
  • Date: Tue, 23 Aug 2011 14:31:03 +0200
  • Message-id: <1415327.7VmhUlGXdX@bort>
On Tuesday 23 August 2011 14:18:52 Adrian Schröter wrote:
Am Dienstag, 23. August 2011, 14:11:30 schrieb Sascha Peilicke:
On Tuesday 23 August 2011 13:40:27 you wrote:
From: Adrian Schröter <adrian@xxxxxxx>

--- a/src/api/app/controllers/request_controller.rb
+++ b/src/api/app/controllers/request_controller.rb
@@ -50,8 +50,6 @@ class RequestController < ApplicationController

end

# Filter by request type (submit, delete, ...)

- #FIXME/FIXME2.3: This should be params[:type] instead but for
whatever reason, all - # webui controllers already set
params[:type] to 'request' (always).

Is that issue solved already?

We decided to use "types" here, because it supports the multiple items
notation (similar to "states", "reviewstates"). As a side effect we don't
have the conflict with "type" anymore.
I know, I was part of the descision, but the issue is that several (if not
all) controllers declare params[:type] to 'request' for no obvious reason. I
suspect it's some before_filter gone mad. Even if we don't conflict with that
anymore, it's still worth fixing.

There is a different place where we would like to use "type", I renamed it
there as FIXME3.0, so we can re-evaluate with Rails 3. And we can not change
the API before 3.0 anyway.
--
With kind regards,
Sascha Peilicke
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)
< Previous Next >
Follow Ups