Mailinglist Archive: opensuse-buildservice (327 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] Also check if files are tracked by osc
On 15.4.2011 14:05, Ruediger Oertel wrote:
On Friday 15 April 2011 11:06:22 Michal Marek wrote:
Hi Rudi, can you have a look at this patch? I also created a merge
request on gitorious:
https://gitorious.org/opensuse/osc-source_validator/merge_requests/1

well, this just opens up another hole to keep arbitrary files in the sources
without having them mentioned in the specfile.
What's the rationale to do this (and potentially not being able to rebuild
a package from it's src-rpm) ?

I don't understand you now. What I'm trying to achieve is to check not only if a referenced file is in the source directory, but if it is also tracked by osc (i.e. if the packager didn't accidentally forget to 'osc add' it). The opposite check, if everything in the source directory is also referenced by the specfile, comes a few lines later (after "# now check if everything is marked in spec files.") and I didn't modify it. At least I didn't intend to :).

The rationale for this is that a similar check exists in osc and they overlap a bit, so I'm removing the osc check and adding the missing bits here.

Michal
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups