Mailinglist Archive: opensuse-buildservice (327 mails)

< Previous Next >
[opensuse-buildservice] [PATCH v2] Do not check for untracked files before commit
This duplicates the work of the source validator and is just annoying.

Suggested-by: Michal Vyskocil <mvyskocil@xxxxxxx>
Signed-off-by: Michal Marek <mmarek@xxxxxxx>
---
osc/commandline.py | 3 ---
osc/core.py | 27 ---------------------------
2 files changed, 0 insertions(+), 30 deletions(-)

diff --git a/osc/commandline.py b/osc/commandline.py
index 0e4673c..b0831be 100644
--- a/osc/commandline.py
+++ b/osc/commandline.py
@@ -3418,9 +3418,6 @@ Please submit there instead, or use --nodevelproject to
force direct submission.

pacs = findpacs(args)

- if conf.config['check_filelist'] and not opts.force:
- check_filelist_before_commit(pacs)
-
if conf.config['do_package_tracking'] and len(pacs) > 0:
prj_paths = {}
single_paths = []
diff --git a/osc/core.py b/osc/core.py
index f41661e..f083753 100644
--- a/osc/core.py
+++ b/osc/core.py
@@ -5903,33 +5903,6 @@ def get_commit_msg(wc_dir, pacs):
store_unlink_file(wc_dir, '_commit_msg')
return msg

-def check_filelist_before_commit(pacs):
-
- # warn if any of files has a ? status (usually a patch, or new source was
not added to meta)
- for p in pacs:
- # no files given as argument? Take all files in current dir
- if not p.todo:
- p.todo = p.filenamelist + p.filenamelist_unvers
- p.todo.sort()
- for f in [f for f in p.todo if not os.path.isdir(f)]:
- if not f.startswith('_service:') and not f.startswith('_service_')
and p.status(f) in ('?', '!'):
- print 'File "%s" found, but not listed in package meta.' % f
- resp = raw_input('(s)kip/(r)emove/(e)dit file
lists/(c)ommit/(A)bort? ')
- if resp in ('s', 'S'):
- continue
- elif resp in ('r', 'R', 'd', 'D'):
- p.process_filelist(['r ? %s' % f])
- elif resp in ('e', 'E'):
- try:
- p.edit_filelist()
- except ValueError:
- print >>sys.stderr, "Error during processiong of file
list."
- raise oscerr.UserAbort()
- elif resp in ('c', 'C'):
- break
- else:
- raise oscerr.UserAbort()
-
def print_request_list(apiurl, project, package = None, states =
('new','review',), force = False):
"""
prints list of pending requests for the specified project/package if
"check_for_request_on_action"
--
1.7.4.1

--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups
References