Mailinglist Archive: opensuse-buildservice (327 mails)

< Previous Next >
[opensuse-buildservice] RFC: [PATCH] --offline skips the GPG verification too
Hi,

now as we are in funny times with BuildService and iChain, I use a
--offline option a lot. But without --no-verify it does not make a
sense, because GPG verification needs API. The --offline implies me API
won't be queried, so I've made this small patch, which skips the GPG
verification as well.

Any comments?

Regards
Michal Vyskocil


The --offline arguments implies API will not be touched, so this will
skip the GPG verification as well.
---
osc/build.py | 2 +-
osc/commandline.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/osc/build.py b/osc/build.py
index 66d74ef..635d102 100644
--- a/osc/build.py
+++ b/osc/build.py
@@ -761,7 +761,7 @@ def main(apiurl, opts, argv):
os.symlink(sffn, tffn)

if bi.pacsuffix == 'rpm':
- if opts.no_verify:
+ if opts.no_verify or opts.offline:
print 'Skipping verification of package signatures'
else:
print 'Verifying integrity of cached packages'
diff --git a/osc/commandline.py b/osc/commandline.py
index ff85f72..50666db 100644
--- a/osc/commandline.py
+++ b/osc/commandline.py
@@ -4471,7 +4471,7 @@ Please submit there instead, or use --nodevelproject to
force direct submission.
@cmdln.option('--clean', action='store_true',
help='Delete old build root before initializing it')
@cmdln.option('-o', '--offline', action='store_true',
- help='Start with cached prjconf and packages without
contacting the api server')
+ help='Start with cached prjconf and packages without
contacting the api server and skip GPG verification')
@cmdln.option('-l', '--preload', action='store_true',
help='Preload all files into the chache for offline
operation')
@cmdln.option('--no-changelog', action='store_true',
--
1.7.4.1

< Previous Next >