Mailinglist Archive: opensuse-buildservice (145 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] support additional request types in notifications

On 31 Jan 2011, at 05:54, Adrian Schröter wrote:

Am Montag, 31. Januar 2011, 05:48:45 schrieb Anas Nashif:
On 31 Jan 2011, at 00:00, Adrian Schröter wrote:
Am Sonntag, 30. Januar 2011, 11:41:39 schrieb Anas Nashif:
Hi,
This patch adds additional request types in notifications, especially
requests to change a role.

The big part is okay, what concerns me a bit is the rename of the
"event" to "eventtype". This is an incompatible change. But only for
rabbit (and I think you are the single user of that atm, so not a
blocker for me).

Why was that renamed (due to a clash?) ? could it have worked before ?

Yes, due to a clash, requests have 'type' already and we are overwriting it
with the the event type. Other should also be changed, I just change rabbit
now so I wont break anybody else scripts, i.e. hermes.

okay, I will merge your patch.

Btw, if you create an account on gitorious.org, I could add you to the push
permissions ;)

I have an account, 'nashif' :)

Anas



thanks
adrian

--
Adrian Schroeter
SUSE Linux Products GmbH
email: adrian@xxxxxxx


--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >