Mailinglist Archive: opensuse-buildservice (158 mails)
| < Previous | Next > |
[opensuse-buildservice] [PATCH] build: Fix signature verification
- From: Michal Marek <mmarek@xxxxxxx>
- Date: Fri, 31 Dec 2010 15:48:52 +0100
- Message-id: <1293806932-24003-1-git-send-email-mmarek@xxxxxxx>
There is no 'en_EN' locale, so osc build fails with
The following package could not be verified:
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_EN)
Firthermore, it is not a good idea to treat any warning message as
error, so do not fail of there is something different than the expected
rpm -K output.
Signed-off-by: Michal Marek <mmarek@xxxxxxx>
---
osc/fetch.py | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/osc/fetch.py b/osc/fetch.py
index 2e39833..c565bfb 100644
--- a/osc/fetch.py
+++ b/osc/fetch.py
@@ -268,7 +268,7 @@ def verify_pacs_old(pac_list):
# save locale first (we rely on English rpm output here)
saved_LC_ALL = os.environ.get('LC_ALL')
- os.environ['LC_ALL'] = 'en_EN'
+ os.environ['LC_ALL'] = 'C'
o = subprocess.Popen(['rpm', '-K'] + pac_list, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT, close_fds=True).stdout
@@ -280,10 +280,7 @@ def verify_pacs_old(pac_list):
for line in o.readlines():
if not 'OK' in line:
- print
- print >>sys.stderr, 'The following package could not be verified:'
print >>sys.stderr, line
- sys.exit(1)
if 'NOT OK' in line:
print
--
1.7.3.4
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx
The following package could not be verified:
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_EN)
Firthermore, it is not a good idea to treat any warning message as
error, so do not fail of there is something different than the expected
rpm -K output.
Signed-off-by: Michal Marek <mmarek@xxxxxxx>
---
osc/fetch.py | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/osc/fetch.py b/osc/fetch.py
index 2e39833..c565bfb 100644
--- a/osc/fetch.py
+++ b/osc/fetch.py
@@ -268,7 +268,7 @@ def verify_pacs_old(pac_list):
# save locale first (we rely on English rpm output here)
saved_LC_ALL = os.environ.get('LC_ALL')
- os.environ['LC_ALL'] = 'en_EN'
+ os.environ['LC_ALL'] = 'C'
o = subprocess.Popen(['rpm', '-K'] + pac_list, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT, close_fds=True).stdout
@@ -280,10 +280,7 @@ def verify_pacs_old(pac_list):
for line in o.readlines():
if not 'OK' in line:
- print >>sys.stderr, 'The following package could not be verified:'
print >>sys.stderr, line
- sys.exit(1)
if 'NOT OK' in line:
--
1.7.3.4
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx
| < Previous | Next > |