Am Montag, 27. Dezember 2010, 19:35:56 schrieb Marcus Huewe:
Hi,
I just wrote a patch to fix some small issues with acl+remoteprojects:
Ok, please apply.
- app/controllers/build_controller.rb * def index: added support for remoteprojects (also added acl code for hidden remoteprojects) - app/controllers/source_controller.rb * def index_project: added acl code for hidden remoteprojects - app/models/db_project.rb * def is_remote_project?, def find_remote_project: added "skip_access=false" parameter to skip acl checks (by default they're enabled)
I'm a bit unhappy with the easy override. Perhaps use an own function name ? But up to you.
- added new testcases
Btw sometimes it's possible to "detect" hidden projects. For instance compare the output of
GET /source/<hiddenproject> and GET /source/<non-existent>
(I'm not quite sure if this is intended)
No, not intended. Error messages should and will be synchronized to rule out such a case. Best, Jan-Simon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org