Mailinglist Archive: opensuse-buildservice (158 mails)

[Angelos Tzotsos <gcpp.kalxas@xxxxxxxxx>]

Thanks Marcus and Malcolm,

Problem solved.

Regards,
Angelos

On 12/03/2010 08:49 PM, Marcus Rueckert wrote:
> On 2010-12-03 20:38:34 +0200, Angelos Tzotsos wrote:
> > %files
> > %defattr(-,root,root,-)
> > %if %suse_version<= 1120
> > %dir %{_bindir}
> > %{_bindir}/*
> > %dir %{_libdir}/otb
> > %{_libdir}/otb/lib*.so.*
> > %else
> > %{_bindir}/*
> > %{_libdir}/otb/lib*.so.*
> > %endif
> >
> > %files devel
> > %defattr(-,root,root,-)
> > %if %suse_version<= 1120
> > %dir %{_includedir}/otb/
> > %{_includedir}/otb/*
> > %dir %{_libdir}/otb
> > %{_libdir}/otb/lib*.so
> > %{_libdir}/otb/*.cmake
> > %else
> > %{_includedir}/otb/
> > %{_libdir}/otb/lib*.so
> > %{_libdir}/otb/*.cmake
> > %endif
> just ARGH
>
> just because the other distros do not complain about that, doesnt mean
> it is correct on them
> %files
> %defattr(-,root,root,-)
> %{_bindir}/*
> %dir %{_libdir}/otb
> %{_libdir}/otb/lib*.so.*
>
> %files devel
> %{_includedir}/otb/
> %{_libdir}/otb/lib*.so
> %{_libdir}/otb/*.cmake
>
> 1. _bindir is covered by the filesystems package. same as _libdir and
>     _includedir.
>
> 2. just %{_includedir}/otb/.
> not %dir %{_includedir}/otb/ not %{_includedir}/otb/*, just %{_includedir}/otb/
> why? because rpm will include all subdirs and files in the directory
> automatically.
>
> 3. the %dir %{_libdir}/otb is also not needed. you require the main
>     package and that owns the subdir already.
>
> a general advice .... if a solution looks complicated and ugly, it
> mostlikely is wrong. think simple and direct.
>
>      darix


--
Angelos Tzotsos
Remote Sensing Laboratory
National Technical University of Athens
http://users.ntua.gr/tzotsos

--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx