Mailinglist Archive: opensuse-buildservice (272 mails)

< Previous Next >
Re: [opensuse-buildservice] Re: [PATCH] Revert "[backend] Indentation fixes."
  • From: Sascha Peilicke <speilicke@xxxxxxx>
  • Date: Tue, 2 Nov 2010 16:43:03 +0100
  • Message-id: <201011021643.07865.speilicke@xxxxxxx>
On Tuesday 02 November 2010 16:31:40 Michael Schroeder wrote:
On Tue, Nov 02, 2010 at 04:26:10PM +0100, Sascha Peilicke wrote:
On Tuesday 02 November 2010 16:14:40 you wrote:
On Tue, Nov 02, 2010 at 04:10:36PM +0100, Sascha Peilicke wrote:
This is rather odd, currently the Perl code consists of an ugly mix
of whitespaces and tabs. The code has ~95% whitespaces, so IMO the
above should be rephrased to 'please use whitespaces as everyone
else'.

No, we're using perl not python in the backend.

That was below the belt and I don't see the relation. Currently, the
_Perl_ backend uses a 2 spaces indentation scheme AFAICS. This is also
followed quite well with the exceptions of some tabs here and there,
which the reverted patch tried to fix, simply.

The *indentation scheme* is 2 spaces, but that has nothing to do
with used tabs.

Sorry, can't follow you. If there is an indentation scheme and some code in
the repository violates that scheme, what is so wrong in fixing that?

Lemme guess, your problem is that the tabs between code and comments are
converted also? If that's the case this could've been resolved waay easier ;-)

Vi automatically converts the leading spaces to
tabs, assuming the standard tab setting at every 8 characters.

What Vi converts is highly dependant on personal settings. IMHO someone had
code committed accidentally with the wrong settings or another editor, who
cares. Even more so, the code in BSXML assumes that a leading tab equals 3
spaces ...
--
Mit freundlichen Grüßen,
Sascha Peilicke
SUSE Linux Products GmbH
< Previous Next >
Follow Ups