Mailinglist Archive: opensuse-buildservice (245 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH] [webui] paths order can now be changed in the project repository configuration
  • From: Thomas Schmidt <tom@xxxxxxxxxxxx>
  • Date: Mon, 18 Oct 2010 16:53:59 +0200
  • Message-id: <4CBC5F87.8050800@xxxxxxxxxxxx>
On 14.10.2010 17:44, Sascha Peilicke wrote:
Hi all,

this patch allows to change the order of repository paths directly in the
project configuration. Currently, this is only possible via editing the raw
config. As the screenie shows, some (hopefully self-explaining) icons where
added (deliberately stolen from the bento icon theme, which deliberately stole
it elsewhere :-). Writing tests for the controller parts remains to be done
though.

As I'm fairly new to the intricacies of webui, this may not be the most ruby-
esque way of doing it. Therefore I'd like to get some comments on it before
committing.

There is a problem in the way the new paths are added to the project xml:
They are added after the architecture elements which does no validate.

Beside that, it looks good, I added some flash messages to show the user
some response what happened after clicking.

Greetings

--
Thomas Schmidt (tom [at] opensuse.org)
openSUSE Boosters Team
"Don't Panic", Douglas Adams (1952 - 11.05.2001)
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
References