Montag 16 August 2010 sent OBS build:
From: Adrian Schröter
--- src/backend/bs_sched | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/src/backend/bs_sched b/src/backend/bs_sched index 189417e..2c255dd 100755 --- a/src/backend/bs_sched +++ b/src/backend/bs_sched @@ -4592,6 +4592,18 @@ relsynccheck: unlink("$reporoot/$prp/$myarch/:repostate"); }
+ # building jobs may have changed back to blocked, kill the jobs + my $prpjobs = jobname($prp, ''); + for (grep {!/(?::dir|:status)$/} grep {/^\Q$prpjobs\E/} ls($myjobsdir)) { + my $job = $_; + if ($job =~ /^\Q$prpjobs\E(.*)-[0-9a-f]{32}$/) { + if ($packstatus{$1} and $packstatus{$1} eq 'blocked') { + print " killing old job, now in blocked state $job\n"; + killjob($job); + } + } + } + # notify remote build services of repository changes or block state # changes # we alse send it if we finish a prp to give linked aggregates a
Hi, I think this change is bad if I understand it correctly. When Factory rebuilds, packages become blocked because of rebuild counter sync even though the running build jobs are not harmed - they are just displayed incorrectly. The scheduler will "unblock" as soon as the build is done. So I would propose only to remove scheduled jobs that became blocked, but do not kill running jobs. The harm appears larger than the benefit. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org