Mailinglist Archive: opensuse-buildservice (258 mails)

< Previous Next >
Re: [opensuse-buildservice][PATCH] patch to enhance "osc vc" command to support MeeGo style changelog
  • From: Marcus Hüwe <suse-tux@xxxxxx>
  • Date: Fri, 20 Aug 2010 14:49:12 +0200
  • Message-id: <20100820124912.GA4411@xxxxxxxxxxxxx>
Hi,

On 2010-08-20 20:10:40 +0800, JF Ding wrote:
Please help me to review this patch to make "osc vc" to
support the MeeGo style changelog, thanks!

I've some small remarks about the your patch:

+ fn_changelog = glob.glob('*.changes')[0]

You should also take the "args" argument into consideration.
"args" can be a path to dir, a path to a *.changes file or it's
omitted. Otherwise this code might break the old behaviour if
there are multiple *.changes files in the package.

+ if not meego_style:
+ if opts.just_edit:
+ cmd_list.append("-e")

It's probably better to do something like:

if meego_style and opts.just_edit:
raise oscerr.WrongOptions(...)
elif opts.just_edit:
cmd_list.append('-e')

Otherwise the patch looks good to me.


Marcus
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups
References