Mailinglist Archive: opensuse-buildservice (332 mails)

< Previous Next >
Re: [opensuse-buildservice] [Patch] [1/2] First ACL testsuite bits / search_controller
  • From: Adrian Schröter <adrian@xxxxxxx>
  • Date: Mon, 12 Jul 2010 09:49:49 +0200
  • Message-id: <201007120949.49576.adrian@xxxxxxx>
On Friday 09 July 2010 19:53:40 Jan-Simon Möller wrote:
...
diff --git a/src/api/test/fixtures/roles_static_permissions.yml
b/src/api/test/fixtures/roles_static_permissions.yml
index 80e5207..79a65f8 100644
--- a/src/api/test/fixtures/roles_static_permissions.yml
+++ b/src/api/test/fixtures/roles_static_permissions.yml
@@ -59,3 +59,19 @@ maintainer_9:
maintainer_10:
role_id: 2
static_permission_id: 10
+
+maintainer_11:
+ role_id: 2
+ static_permission_id: 11
+
+maintainer_12:
+ role_id: 2
+ static_permission_id: 12
+
+maintainer_13:
+ role_id: 2
+ static_permission_id: 13
+
+maintainer_16:
+ role_id: 2
+ static_permission_id: 16

A bit more speaking names would maybe nicer, if possible. Like
"private_source_owner" or "outside_user".

Maybe you could also re-use existing user definitions ?

But no objections.

diff --git a/src/api/test/fixtures/static_permissions.yml
b/src/api/test/fixtures/static_permissions.yml
index cf994ae..d41fb04 100644
--- a/src/api/test/fixtures/static_permissions.yml
+++ b/src/api/test/fixtures/static_permissions.yml
@@ -50,3 +50,18 @@ local_create_package:
id: 10
title: create_package

+download_binaries:
+ id: 11
+ title: download_binaries
+
+source_access:
+ id: 12
+ title: source_access
+
+private_view:
+ id: 13
+ title: private_view
+
+access:
+ id: 16
+ title: access


Can you please document here (in comments), what these roles are ?

Esp. the difference between source_access and access is unclear to me. It is
imho
not obvious from the "access" name what it is supposed to do.

thanks
adrian

--

Adrian Schroeter
SUSE Linux Products GmbH
email: adrian@xxxxxxx

--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups