Mailinglist Archive: opensuse-buildservice (306 mails)

[Marcus Hüwe <suse-tux@xxxxxx>]

On 2010-06-07 09:40:03 +0200, Adrian Schröter wrote:
> On Donnerstag, 3. Juni 2010 20:47:11 Marcus Hüwe wrote:
> > Sorry for the late response...
> >
> > On 2010-05-31 11:28:10 +0200, Michael Schroeder wrote:
> > > On Sat, May 29, 2010 at 09:34:37AM +0200, Adrian Schröter wrote:
> > > > On Freitag, 28. Mai 2010 23:36:39 Marcus Hüwe wrote:
> > > > > Hi,
> > > > >
> > > > > I just updated my patch which enables basic proxy support in the
> > > > > backend.
> > > > > Are there any objections against committing it to git master?
> > > >
> > > > Please change it in a way that $proxy can be just commented out by
> > > > default in BSConfig.pm.
> > > >
> > > > Otherwise all updaters will run into problems, because BSConfig.pm
> > > > get not touched on update usually.
> > >
> > > Doesn't that already work with the patch?
> > It should work for updaters, too. If "proxy" isn't defined in BSConfig.pm
> > it'll "default" to undef (which should be correct).
> > Anyway I just committed it.
>
> No, it would error out, because the proxy object does not exist.
Hmm consider the following example:

# Foo.pm:
package Foo;
use strict;
use warnings;
1;

# some other perl script which uses Foo:
#!/usr/bin/perl -w
use strict;
use warnings;
use Data::Dumper;

my $x = $Foo::xxx;
print Dumper($x);
# avoid typo warning...
$x = $Foo::xxx;

In this case $Foo::xxx evaluates to "undef".

> It is fixed now. (there were also some typos, so this code could never have 
> worked).
Thanks for spotting the typos!


Marcus
-- 
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx