RE: [opensuse-buildservice] Working on Fate#309351: osc multiple package submit request

24 May 2010

      Hello,

When I'm going to make change for backend and api server, I found this feature -- https://features.opensuse.org/308759, and its status was done.

Also I found relevant code in api server. So I'll just make change for OSC. Is that okay?

----------------
Best Regards,
Brook Hong
...
-----Original Message-----
From: ext Adrian Schröter [mailto:adrian@suse.de]
Sent: Thursday, May 20, 2010 12:51 PM
To: opensuse-buildservice@opensuse.org
Cc: Hong Brook (Nokia-D/Beijing)
Subject: Re: [opensuse-buildservice] Working on Fate#309351: osc
multiple package submit request
Am Donnerstag, 20. Mai 2010, 05:40:03 schrieb brook.hong@nokia.com:
...
Ok, here will be the new syntax for createrequest.
osc creq [OPTIONS] [ \
                -a submit SOURCEPRJ SOURCEPKG DESTPRJ [DESTPKG] \
                -a delete PROJECT [PACKAGE] \
                -a change_devel PROJECT PACKAGE DEVEL_PROJECT
[DEVEL_PACKAGE] \
                -a add_role  PROJECT [PACKAGE]
We have some more roles beside these two and admins can also define
their owns.
So, this should not be limitted to these both.
...
-a set_bugowner PROJECT [PACKAGE]
                ]
There is still another question, when a maintainer who already has
write access to some project runs this command, will a request also be
created for that?
...
Since the action could be done directly, I suggest that no request
will be created while with some warning message printed out to notify
user.
...
What do you think it?
Hm, that might not be expected when you running a script using osc. You
may still want to have the request in this case.
good morning
adrian
...
----------------
Best Regards,
Brook Hong
...
-----Original Message-----
From: ext Adrian Schröter [mailto:adrian@suse.de]
Sent: Wednesday, May 19, 2010 3:04 PM
To: opensuse-buildservice@opensuse.org
Cc: Hong Brook (Nokia-D/Beijing)
Subject: Re: [opensuse-buildservice] Working on Fate#309351: osc
multiple package submit request
Am Mittwoch, 19. Mai 2010, 03:50:07 schrieb brook.hong@nokia.com:
...
...
The requests are to set you with a role in projects, where you
don't
...
...
...
...
have write access (yet).
Huh, then it does make sense. But I can't find any code related
with
those requests in the obs api layer.
Does it mean that these requests have NOT been implemented on
server
side?
If it does, we need to figure out the requests' xml presentation.
May
be like
Please check docs/api/api/request.xml and docs/api/api/request.xsd
There are these examples inside:
<action type="add_role">
  <target project="openSUSE:10.3" package="kraft.old" />
  <person name="adrian" role="maintainer" />
</action>
<action type="add_role">
  <target project="openSUSE:10.3" package="kraft.old" />
  <group name="security-team" role="reviewer" />
</action>
<action type="set_bugowner">
  <target project="openSUSE:10.3" package="kraft.old" />
  <person name="karl-heinz"  />
</action>
...
<action type="add_role">
    <target project="hello_test" package="hello_people" />
    <user name="someone" role="bugowner|maintainer">
  </action>
And set_bugowner can be covered by add_role. Do we need to add a
new
request type as "remove_role"?
set_bugowner is removing all other bugowner entries (because bugzilla
can handle only on bugowner).
So I decided to have a special request for this to make it more
visible
that "set" is removing
old entries (while "add" makes the impression just to add more).
remove_role could get implemented, but so far I heard no request or
need
for it. Dunno if we have
a usecase where it makes sense (when you are maintainer you can
remove
your entry anyway without a request).
bye
adrian
--
Adrian Schroeter
SUSE Linux Products GmbH
email: adrian@suse.de
--
To unsubscribe, e-mail: opensuse-
buildservice+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-
buildservice+help@opensuse.org
--
Adrian Schroeter
SUSE Linux Products GmbH
email: adrian@suse.de
-- 
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org
For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

RE: [opensuse-buildservice] Working on Fate#309351: osc multiple package submit request

brook.hong＠nokia.com