Mailinglist Archive: opensuse-buildservice (348 mails)

< Previous Next >
Re: [opensuse-buildservice] [Patch] Add --offline and --preload to osc build - v1
Hi,

On 2010-04-15 23:16:35 +0200, Jan-Simon Möller wrote:
Ever wanted to work offline e.g. in train on a package ? So after being
encased hours in such a vehicle, here it is ...

The attached patch for review and improvement adds this functionality:

Your patch looks good - I really like the "--preload" option :) but I've
some small remarks:
- currently it probably doesn't work as expected because it'll still fetch
missing binaries even if "--offline" is specified
- "--offline" and "--preload" (and "--no-init") should be mutually
exclusive
- there's no need to add an "offline" parameter to the parse_repoarchdescr()
method. Simply use
"self.parse_repoarchdescr(args, opts.noinit or opts.offline, ...)"

Please push your changes and I'll "fix" it afterwards. Thanks!


Marcus
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
References