Mailinglist Archive: opensuse-buildservice (348 mails)

< Previous Next >
Re: [opensuse-buildservice] [PATCH 4/6] obs-server, webui: update SPARC definitions
  • From: "Jan-Simon Möller" <dl9pf@xxxxxx>
  • Date: Tue, 13 Apr 2010 19:39:27 +0200
  • Message-id: <201004131939.27692.dl9pf@xxxxxx>
Am Dienstag, 13. April 2010 19:20:00 schrieb Ludwig Nussel:
Martin Mohring wrote:
Ludwig Nussel wrote:
Martin Mohring wrote:
Ludwig Nussel wrote:
There's a hack for ARM in the build script, it looks at
'changetarget' in prjconf in order to define the target I think.
Maybe that feature could be used here too.

This is not a hack, it is due to the behavior of rpm. We found no other
way working with all rpm versions to handle this. And: the problem
solved with this is not limited to ARM.


Atm it is both a hack (conflicts with ABUILD_TARGET_ARCH AFAICS) and
is limited to ARM :-)

1613 # case arm, extract changetarget
1614 # this is restricted to arm to make sure it doesn't
interfere with x86
1615 if [ "$BUILD_ARCH" != "${BUILD_ARCH#arm}" ]; then


Ok. Let me say it another way: Yes, it is of course a hack (and the #arm
is a hack). But how does the "solution" instead of the hack look like? I
the only solution we found is to pass in worst case the full triple to
rpm. If the implementation of this is a hack, lets fix it.

Well, I guess that solution is fine if it integrates with
ABUILD_TARGET_ARCH. I'd probably rename the option to
'defaulttarget' or just 'target' instead of 'changetarget' though.

So if we just talk about _naming_ ... where's the issue ?
I'd be fine with e.g. "targetplatform" at this this is what it actually
contains.
(an btw. 'changetarget' is what it does ... )

And yes, we can merge any double variables setting --target in the end.

And the "#arm" was done by intention at that time do don't play with the
"wrong" arches on build.o.o .

My 0,02 € ...

Best,
Jan-Simon
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >