Re: [opensuse-buildservice] Re: [PATCH] - allow diff against a nonexistent (source/target) project/package

On Mon, Apr 12, 2010 at 10:38:49AM +0200, Michael Schroeder wrote:

On Sat, Apr 10, 2010 at 03:28:07PM +0200, OBS build-service wrote:

...

From: Marcus Huewe [...] - my ($projid, $packid, $rev, $linked) = @_; + my ($projid, $packid, $rev, $linked, $missingok) = @_; my $proj = remoteprojid($projid); if (!$proj) { + return {'project' => $projid, 'package' => $packid, 'srcmd5' => 'empty'} if $missingok; [...]

What exactly are you trying to solv with that flag?

I want to support a diff against a non-existent project/package. For instance if you create a new submitrequest which would create a new package in the target project you won't be able to view the diff because the package doesn't exist in the target project. The missingok flag is used to tell remote_getrev() not to die if the project and/or package doesn't exist. Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org