Mailinglist Archive: opensuse-buildservice (260 mails)

< Previous Next >
RE: [opensuse-buildservice] [patch] build: sparc support
  • From: <Michael_E_Brown@xxxxxxxx>
  • Date: Mon, 14 Dec 2009 08:01:57 -0600
  • Message-id: <F757EE5C3631ED4DBDFD7709119219FE012DB2189A@xxxxxxxxxxxxxxxxxxxxxxxxxx>
But it does not match existing coding style. To me it is somewhat rude to
ignore coding style of the surrounding code when submitting patches. Especially
code on the immediately preceding line. :)
--
Michael
________________________________________
From: Jan Engelhardt [jengelh@xxxxxxxxxx]
Sent: Monday, December 14, 2009 5:07 AM
To: Michael Schroeder
Cc: Ludwig Nussel; opensuse-buildservice@xxxxxxxxxxxx
Subject: Re: [opensuse-buildservice] [patch] build: sparc support

On Monday 2009-12-14 12:03, Michael Schroeder wrote:
diff --git a/common_functions b/common_functions
index 8a67511..f27c1be 100644
--- a/common_functions
+++ b/common_functions
@@ -14,6 +14,8 @@ set_build_arch()
i586) BUILD_ARCH="i586:i486:i386" ;;
i486) BUILD_ARCH="i486:i386" ;;
x86_64) BUILD_ARCH="x86_64:i686:i586:i486:i386" ;;
+ (sparc64*)
BUILD_ARCH="sparc64v:sparc64:sparcv9v:sparcv9:sparcv8:sparc";;
+ (sparc*) BUILD_ARCH="sparcv9v:sparcv9:sparcv8:sparc";;
^ intentional?

Yes. Everything that's not 64 is 32. Though you could of course say
that trying to build for sparcv8 (which nobody would do these days)
must not use sparcv9s. Dunno if it really matters.

I think Ludwig meant the leading '('...

That too is intended. bash, dash and ash supports this, and is
good for balancing.
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >