Mailinglist Archive: opensuse-buildservice (260 mails)

< Previous Next >
Re: [opensuse-buildservice] first draft of a dod implementation
  • From: Marcus Hüwe <suse-tux@xxxxxx>
  • Date: Wed, 2 Dec 2009 15:02:47 +0100
  • Message-id: <20091202140247.GA3342@xxxxxxxxxxxxxxxxxxxxxx>
On 2009-12-02 12:09:52 +0100, Michael Schroeder wrote:
4) the dod solvables should have a hdrid of "dododo..."

Hmm why do we need this? e.g. for the getbinaryversions() call in
bs_repserver? (at least in the scheduler this isn't needed because
when it starts to calculate the meta all hdrid's are already available)

It makes thinks cleaner, you don't need to special case dod packages,
e.g. the "$pkgid = "dodododododododododododododododo" unless $pkgid;"
line in the scheduler.

Ah ok that makes sense.

(Maybe we should set the buildservice_id to "dod" as well. Hmm.)

I'm fine with this too but then we also need to change the check in
create_considered() so that it prefers solvables with a
buildservice_id != "dod". But that's no problem it's just a strcmp()...

I also think that currently dod repos are kind of slow, as
addrepo_dod() doesn't look at the old solv file like addrepo_scan.
We could move the dod handling into addrepo_scan, i.e.:

This would convert the dod data only at the first time and afterwards
just use the standard code to manage the non-dod solvables.

That sounds good and much cleaner:)

The drawback is that you have to delete the solv file if you change
the metadata.

I think the "speedup" outweighs the drawback because addrepo_(dod|scan)
is often called if you start with an empty dod repo. So if you have a
couple of dod repos it might be "important".


Marcus
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups