Re: [opensuse-buildservice] Keyring support in osc

Am Donnerstag, 7. Mai 2009 11:06:59 schrieb Petit Eric:

2009/5/7 Marcus Hüwe :

...

Hi,

On 2009-05-07 10:25:55 +0200, Michal Čihař wrote:

...

some time ago I wrote a patch for storing osc credentials in Gnome keyring instead of ~/.oscrc. It uses keyring only if available otherwise it falls back to using configuration file.

Any comments on committing this into svn?

The patch is available in bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=460540

I thought about this patch for some time. Overall the patch looks good to me but "design wise" I'm a bit hesitant. There might be someone who wants support for kwallet or another password manager so he adds his kwallet specific code to the conf.py module. So it might be a good idea to add something like a base class for all these user/password stuff, e.g. class OscPasswdMgr(): def getUser(...) def setUser(...) etc. class OscGnomeKeyring(OscPasswdMgr): ...

This way we would have a "clean" conf.py. This might be something for the future... feel free to commit your patch (at least there are no objections from my side:) ).

This is not more simply to crypt/decrypt password before read/write password in ~/.oscrc , like i do in MonoOSC ?

And where do store the crypt/decrypt key ? Or do you want to ask always the user to enter it ? -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org