Mailinglist Archive: opensuse-buildservice (250 mails)

< Previous Next >
Re: [opensuse-buildservice] osc vc: configurable email adress
  • From: Michal Vyskocil <mvyskocil@xxxxxxx>
  • Date: Fri, 17 Apr 2009 16:34:09 +0200
  • Message-id: <200904171634.09620.mvyskocil@xxxxxxx>
On Friday 17 of April 2009 14:58:12 Marcus Hüwe wrote:
Hi,

On 2009-04-17 11:03:36 +0200, Michal Vyskocil wrote:
On Thursday 16 of April 2009 18:18:58 Dominique Leuenberger wrote:
[snip]

That sounds good:)

Just a small remark:
+ # user's email
+ apiurl = conf.config['apiurl']

Is it likely that "osc vc" will be executed in a non package dir/working
copy? If not it would be nice if you use something like:

# note if cwd is no working copy it'll bail out
apiurl = findpacs(os.getcwd())[0].apiurl

or

apiurl = conf.config['apiurl']
if is_package_dir(os.getcwd()):
apiurl = store_read_apiurl(os.getcwd())

This way osc always uses the correct apiurl.

Thanks, I'll fix that.

Regards
Michal Vyskocil
--
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >