Mailinglist Archive: opensuse-buildservice (351 mails)

< Previous Next >
Re: [opensuse-buildservice] osc submitreq accept broken
  • From: Michael Schroeder <mls@xxxxxxx>
  • Date: Wed, 16 Jul 2008 11:56:06 +0200
  • Message-id: <20080716095606.GB29104@xxxxxxx>
On Tue, Jul 15, 2008 at 04:06:09PM +0200, Marcus Rueckert wrote:
On 2008-07-15 15:44:44 +0200, Michael Schroeder wrote:
On Tue, Jul 15, 2008 at 03:41:25PM +0200, Marcus Rueckert wrote:
quoting from dirk's diff:
- open(F, '<', $file) || die("$file: $!\n");

Oh, but it can't die here unless the filesystem is corrupt. And
in that case, it really should die instead of doing more damage...

there are more graceful ways of handling error conditions.
like jumping out of the handling and returning proper errors.

Sorry, but throwing an exception is exactly the right way.

M.
---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
Follow Ups