Mailinglist Archive: opensuse-buildservice (239 mails)

< Previous Next >
Re: [opensuse-buildservice] RFC: small patch for "osc commit" with big effect
  • From: "Dominique Leuenberger" <Dominique.Leuenberger@xxxxxxxxxxxxx>
  • Date: Tue, 20 May 2008 15:07:37 +0200
  • Message-id: <4832F749.2554.0029.1@xxxxxxxxxxxxx>
Peter,

sorry for top-Posting.. sometimes I could start to hate GroupWise... it does
not always as it's told to do :) So this time it forgets to quote your text
correctly.

so about enforcing the commit messages: I'm perfectly in favor of if... BUT
with a small extension: the .changes files should be updated in the same moment
(or the api should use this info for the %changelog)

Otherwise we start to make the same changes over and over: in the .changes, in
the commit message, and most likely this will lead to useless comments, like
'see changelog' ;)

Dominique


From: Peter Poeml <poeml@xxxxxxx>
To:<opensuse-buildservice@xxxxxxxxxxxx>
Date: 20.05.2008 16:04
Subject: [opensuse-buildservice] RFC: small patch for "osc commit" with big
effect
Hi,

Index: osc/commandline.py
===================================================================
--- osc/commandline.py (revision 4001)
+++ osc/commandline.py (working copy)
@@ -1029,6 +1029,9 @@
${cmd_usage}
${cmd_option_list}
"""
+ if not opts.message and not opts.file:
+ sys.stderr.write('You didn\'t specify a commit message.\n'
+ 'In the future, this will be mandatory.\n')
msg = ''
if opts.message:
msg = opts.message



Later, giving a commit message (-m / -F) will be enforced.

What do people think about this? I think it is good, and I know some
that agree, and I haven't seen anyone disagreeing yet.

We can also make the messages mandatory right away, depending on what
you think...

Thanks,
Peter
--
"WARNING: This bug is visible to non-employees. Please be respectful!"

SUSE LINUX Products GmbH
Research & Development

---------------------------------------------------------------------
To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@xxxxxxxxxxxx
For additional commands, e-mail: opensuse-buildservice+help@xxxxxxxxxxxx

< Previous Next >
References