Mailinglist Archive: opensuse-buildservice (354 mails)

< Previous Next >
Re: [opensuse-buildservice] Webclient running locally (PATCH added)
  • From: Dirk Stoecker <opensuse@xxxxxxxxxxxx>
  • Date: Thu, 8 Feb 2007 17:25:22 +0100 (CET)
  • Message-id: <Pine.LNX.4.64.0702081714020.28578@xxxxxxxxxxxxxxxxx>
On Thu, 8 Feb 2007, David Mayr wrote:

> I applied a (heavily) modified version of your patch.

Ah. Ruby has a switch statement also :-) Already wondered, why there was
such an if-elsif clause in the code.

Also thought about using cascading style sheets, but didn't want to change
that much on first try.

> Just an recommendation for the future: please don't use '$' to start local
> variable names. '$' is used for global variables.

No prefix then. I searched the ruby pages on the net and found nothing
related to variable names on a quick search, so I tried Perl syntax and it
worked.

Two other fixes I found are attached: Adding two links to reduce clicking
effort. No ruby specifics here :-)

Ciao
--
http://www.dstoecker.eu/ (PGP key available)Index: app/views/main/index.rhtml
===================================================================
--- app/views/main/index.rhtml (Revision 1198)
+++ app/views/main/index.rhtml (Arbeitskopie)
@@ -36,6 +36,7 @@
<li><%= link_to "Watched Projects", :controller => "project", :action => :list_my %></li>
<li><%= link_to "Home Project", :controller => "project", :action => :show, :project => "home:#{session[:login]}" %></li>
<li><%= link_to "Search", :controller => 'main', :action => 'search' %></li>
+ <li><%= link_to "Advanced Search", :controller => 'main', :action => 'search_advanced' %></li>
<li><%= link_to "Monitor Build Status", :controller => "monitor", :action => :index %></li>
</ul>
<% else -%>
Index: app/views/project/monitor.rhtml
===================================================================
--- app/views/project/monitor.rhtml (Revision 1198)
+++ app/views/project/monitor.rhtml (Arbeitskopie)
@@ -85,4 +85,5 @@
</p>
<% end -%>

-<%= link_to "[Back to #{@project}]", :action => :show, :project => @project %>
+<p><%= link_to "[Back to #{@project}]", :action => :show, :project => @project %></p>
+<p><%= link_to "[Build Status Monitor]", :controller => "monitor", :action => :index %></p>
< Previous Next >
Follow Ups