[Bug 857134] New: pm-profiler poking at wrong sysfs files

https://bugzilla.novell.com/show_bug.cgi?id=857134

https://bugzilla.novell.com/show_bug.cgi?id=857134#c0


           Summary: pm-profiler poking at wrong sysfs files
    Classification: openSUSE
           Product: openSUSE 13.1
           Version: Final
          Platform: Other
        OS/Version: openSUSE 13.1
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: Other
        AssignedTo: bnc-team-screening@forge.provo.novell.com
        ReportedBy: manfred99@gmx.ch
         QAContact: qa-bugs@suse.de
          Found By: ---
           Blocker: ---


User-Agent:       Opera/9.80 (X11; Linux x86_64) Presto/2.12.388 Version/12.16

What happened to the fixes for bug #737319, 2 years ago?

I get
  /usr/lib/pm-profiler/enable-profile: line 42:
/sys/devices/system/cpu/cpu0/cpufreq/ondemand/up_threshold: No such file or
directory


Fix will be along the lines of the following, I guess:

--- enable-profile.orig 2014-01-01 23:29:07.836926490 +0000
+++ enable-profile      2014-01-01 23:59:28.038139927 +0000
@@ -39,17 +39,15 @@
 }

 function cpufreq_ondemand_up_threshold {
-    echo $CPUFREQ_ONDEMAND_UP_THRESHOLD >
/sys/devices/system/cpu/cpu0/cpufreq/ondemand/up_threshold;
+    echo $CPUFREQ_ONDEMAND_UP_THRESHOLD >
/sys/devices/system/cpu/cpufreq/ondemand/up_threshold
 }

 function cpufreq_ondemand_sampling_rate {
-    echo $CPUFREQ_ONDEMAND_SAMPLING_RATE
>/sys/devices/system/cpu/cpu0/cpufreq/ondemand/sampling_rate;
+    echo $CPUFREQ_ONDEMAND_SAMPLING_RATE >
/sys/devices/system/cpu/cpufreq/ondemand/sampling_rate
 }

 function cpufreq_ondemand_powersave_bias {
-    for I in /sys/devices/system/cpu/cpu0/cpufreq/ondemand/powersave_bias; do
-       echo $CPUFREQ_ONDEMAND_POWERSAVE_BIAS > $I
-    done
+    echo $CPUFREQ_ONDEMAND_POWERSAVE_BIAS >
/sys/devices/system/cpu/cpufreq/ondemand/powersave_bias
 }

 function cpufreq_sched_mc_power_savings {




--- get-current-settings.orig   2014-01-02 00:00:05.421013633 +0000
+++ get-current-settings        2014-01-02 00:06:10.834004652 +0000
@@ -17,50 +17,19 @@

 function get_cpufreq_ondemand_up_threshold {
     Option="CPUFREQ_UP_THRESHOLD"
-    Value=`cat /sys/devices/system/cpu/cpu0/cpufreq/$Governor/up_threshold`
-
-    for I in /sys/devices/system/cpu/cpu[[:digit:]]*; do
-        if [ -d $I/cpufreq/$Governor ]; then
-            Next_Value=`cat $I/cpufreq/$Governor/up_threshold`
-            if [[ $Next_Value != $Value ]]; then
-                echo "Warning: different values: "$Option >&2
-            fi
-        else
-            echo "Warning: different governor on "$I >&2
-        fi
-    done
+    Value=`cat /sys/devices/system/cpu/cpufreq/$Governor/up_threshold`
     echo $Option"="$Value
 }

 function get_cpufreq_ondemand_sampling_rate {
     Option="CPUFREQ_UP_CPUFREQ_SAMPLING_RATE"
-    Value=`cat /sys/devices/system/cpu/cpu0/cpufreq/$Governor/sampling_rate`
-
-    for I in /sys/devices/system/cpu/cpu[[:digit:]]*; do
-        if [ -d $I/cpufreq/$Governor ]; then
-            if [ `cat $I/cpufreq/$Governor/sampling_rate` != $Value ]; then
-                echo "Warning: different values: "$Option >&2
-            fi
-        else
-            echo "Warning: different governor on "$I >&2
-        fi
-    done
+    Value=`cat /sys/devices/system/cpu/cpufreq/$Governor/sampling_rate`
     echo $Option"="$Value
 }

 function get_cpufreq_ondemand_powersave_bias {
     Option="CPUFREQ_ONDEMAND_POWERSAVE_BIAS"
-    Value=`cat /sys/devices/system/cpu/cpu0/cpufreq/$Governor/powersave_bias`
-
-    for I in /sys/devices/system/cpu/cpu[[:digit:]]*; do
-        if [ -d $I/cpufreq/$Governor ]; then
-            if [ `cat $I/cpufreq/$Governor/powersave_bias` != $Value ]; then
-                echo "Warning: different values: "$Option >&2
-            fi
-        else
-            echo "Warning: different governor on "$I >&2
-        fi
-    done
+    Value=`cat /sys/devices/system/cpu/cpufreq/$Governor/powersave_bias`
     echo $Option"="$Value
 }


Reproducible: Always

-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.