https://bugzilla.novell.com/show_bug.cgi?id=792294
https://bugzilla.novell.com/show_bug.cgi?id=792294#c4
Christian Boltz changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
InfoProvider|suse-beta@cboltz.de |
--- Comment #4 from Christian Boltz 2012-12-02 21:37:47 CET ---
Basically yes, but I have some notes:
- the defines are not really needed if they don't depend on suse_version (but
don't hurt)
- maybe you can simplify even more:
%package -n libsmbclient-devel
[...]
%if 0%{?suse_version} > 1020
BuildRequires: pkg-config
%else
BuildRequires: pkgconfig
%endif
-> maybe pkg-config/pkgconfig is worth another define ;-)
%if 0%{?suse_version} && 0%{?suse_version} < 921
Requires: heimdal-devel
Requires: %{libsmbclient_name} = %{version}
%else
%if 0%{?suse_version} && 0%{?suse_version} < 1031
Requires: krb5-devel
Requires: %{libsmbclient_name} = %{version}
%endif
-> do you really want/need to support < 921?
-> move "Requires: %{libsmbclient_name} = %{version}" outside the %if block?
Or is it really not needed for >= 1031?
-> I see two %if, but only one %endif - bug?
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.