https://bugzilla.novell.com/show_bug.cgi?id=759635
https://bugzilla.novell.com/show_bug.cgi?id=759635#c6
--- Comment #6 from Michael Chang 2012-05-02 06:23:41 UTC ---
Hi Agnelo,
Thanks for the patch and debugging into this.
However I did observe some issues that the patch may not be applied, would be
great if you could resolve them?
1. The most serious one would be ". /usr/lib/grub/grub-mkconfig_lib". This
makes os-prober to depend on grub2, and since grub2 has already depended
(required) os-prober, this is so call "loop dependency" and is usually bad.
2. The hard coded path /usr/lib/grub/grub-mkconfig_lib may be changed by grub2
without any notices to any other package as it's not supposed to be used
outside the scope of grub2 (it will happen in factory, as the automake upgrade
forces the grub-mkconfig_lib to be installed to /usr/share.)
3. The fix should better be implemented in the "$types" matching ?
types="$(fs_type "$partitions")" || types=NOT-DETECTED
if [ "$types" = NOT-DETECTED ]; then
...
...
+ elif [ "$types" = ufs ]; then
+ ...
+ ...
elif [ -z "$types" ]; then
...
Thanks.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.