[Bug 723724] Samba initscript always returns success message on start (even on failure)

https://bugzilla.novell.com/show_bug.cgi?id=723724 https://bugzilla.novell.com/show_bug.cgi?id=723724#c1 David Disseldorp changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ddiss@suse.com AssignedTo|samba-maintainers@SuSE.de |ddiss@suse.com --- Comment #1 from David Disseldorp 2011-10-14 11:53:36 UTC --- Thanks for the report Christian, good catch. (In reply to comment #0)

While reading the samba initscript (/etc/init.d/smb) I noticed that it will always return a green "done" success message on "start", even if startproc fails.

This is caused by the "unset" command between startproc and rc_status which resets $? to 0 (success).

..

My understanding is that removing the unset command will not change anything except fixing this bug ;-)

Agreed, but to keep it consistent we can just move the unset down one line. rc_status() will then output and retain the smbd exit status for return with rc_exit(). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.