Mailinglist Archive: opensuse-bugs (4376 mails)

< Previous Next >
[Bug 680430] SCIM is not usable in firefox

https://bugzilla.novell.com/show_bug.cgi?id=680430

https://bugzilla.novell.com/show_bug.cgi?id=680430#c8


Michael Chang <mchang@xxxxxxxxxx> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |mchang@xxxxxxxxxx

--- Comment #8 from Michael Chang <mchang@xxxxxxxxxx> 2011-05-04 03:35:02 UTC
---
The above patch works for me. The culprit might be that scim-bridge didn't
re-register it's type once the type module get "reloaded" (ie. unload and
reload the type plugin). It would only register its type in first time loaded
and never reregister in respond to module reload..

I have no idea about the purpose it omits re-register the type. Another fix
might be g_type_module_use to add use count to the type module thus the
instance is always referenced and never get unloaded. The patch would look like
below.

Index: scim-bridge-0.4.15/client-gtk/scim-bridge-client-imcontext-gtk.c
===================================================================
--- scim-bridge-0.4.15.orig/client-gtk/scim-bridge-client-imcontext-gtk.c
+++ scim-bridge-0.4.15/client-gtk/scim-bridge-client-imcontext-gtk.c
@@ -678,7 +678,10 @@ void scim_bridge_client_imcontext_regist
(GtkObjectInitFunc) scim_bridge_client_imcontext_initialize,
};

- if (!class_type) class_type = g_type_module_register_type (type_module,
GTK_TYPE_IM_CONTEXT, "ScimBridgeClientIMContext", &klass_info, 0);
+ if (!class_type) {
+ class_type = g_type_module_register_type (type_module,
GTK_TYPE_IM_CONTEXT, "ScimBridgeClientIMContext", &klass_info, 0);
+ g_type_module_use (type_module);
+ }
}

But I think patch of Comment#7 should be better and more common. Meanwhile, I
have the test packages in the OBS.

home:michael-chang:branches:openSUSE:11.4:Update:Test scim-bridge

Did anyone has comment for the patches?
Thanks.

--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

< Previous Next >