[Bug 673826] pam_listfile's quiet option wrong behaviour

https://bugzilla.novell.com/show_bug.cgi?id=673826 https://bugzilla.novell.com/show_bug.cgi?id=673826#c4 Vitezslav Cizek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vcizek@novell.com --- Comment #4 from Vitezslav Cizek 2011-02-23 10:42:37 UTC --- (In reply to comment #3)

pam_listfile has the following code:

} else if (!strcmp(mybuf,"quiet")) { quiet = 1;

Which means the option is "quiet" and nothing else. quiet=1 or quiet=yes will not work.

But few lines obove that you can find: junk = strchr(argv[i], '='); if((junk == NULL) || (junk - argv[i]) >= (int) sizeof(mybuf)) { pam_syslog(pamh,LOG_ERR, "Bad option: \"%s\"", argv[i]); continue; } strncpy(mybuf, argv[i], LESSER(junk - argv[i], (int)sizeof(mybuf) - 1)); strncpy(myval, junk + 1, sizeof(myval) - 1); Which strips the =1 and sets mybuf to "quiet", so it does work. The (junk == NULL) test eliminates quiet option without argument. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.